From: Linus Walleij <linus.walleij@linaro.org>
To: Pascal PAILLET-LME <p.paillet@st.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
"olof@lixom.net" <olof@lixom.net>,
"arnd@arndb.de" <arnd@arndb.de>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
"biju.das@bp.renesas.com" <biju.das@bp.renesas.com>,
Yannick FERTRE <yannick.fertre@st.com>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ARM: dts: stm32: add stpmic1 support on stm32mp157c ed1 board
Date: Mon, 8 Apr 2019 14:05:10 +0200 [thread overview]
Message-ID: <CACRpkdZ9evBnvnmidQ2VW=dPUdGBM4Pkzo1VyMfDdQZFe6U7TA@mail.gmail.com> (raw)
In-Reply-To: <1554298852-9955-2-git-send-email-p.paillet@st.com>
On Wed, Apr 3, 2019 at 3:41 PM Pascal PAILLET-LME <p.paillet@st.com> wrote:
> This patch adds stpmic1 support on stm32mp157c ed1 board.
> The STPMIC1 is a PMIC from STMicroelectronics. The STPMIC1 integrates 10
> regulators, 3 power switches, a watchdog and an input for a power on key.
>
> Signed-off-by: Pascal Paillet <p.paillet@st.com>
OK
> + /delete-property/dmas;
> + /delete-property/dma-names;
Maybe you can add a comment both to the commit message and the
DTS file as to why you are doing this?
I hope you are not trying to work around a bug in the driver by
stripping out DMA configuration from the device tree, because then
it is probably a better idea to fix the bug.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Pascal PAILLET-LME <p.paillet@st.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"biju.das@bp.renesas.com" <biju.das@bp.renesas.com>,
Yannick FERTRE <yannick.fertre@st.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"olof@lixom.net" <olof@lixom.net>,
"horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>
Subject: Re: [PATCH 1/3] ARM: dts: stm32: add stpmic1 support on stm32mp157c ed1 board
Date: Mon, 8 Apr 2019 14:05:10 +0200 [thread overview]
Message-ID: <CACRpkdZ9evBnvnmidQ2VW=dPUdGBM4Pkzo1VyMfDdQZFe6U7TA@mail.gmail.com> (raw)
In-Reply-To: <1554298852-9955-2-git-send-email-p.paillet@st.com>
On Wed, Apr 3, 2019 at 3:41 PM Pascal PAILLET-LME <p.paillet@st.com> wrote:
> This patch adds stpmic1 support on stm32mp157c ed1 board.
> The STPMIC1 is a PMIC from STMicroelectronics. The STPMIC1 integrates 10
> regulators, 3 power switches, a watchdog and an input for a power on key.
>
> Signed-off-by: Pascal Paillet <p.paillet@st.com>
OK
> + /delete-property/dmas;
> + /delete-property/dma-names;
Maybe you can add a comment both to the commit message and the
DTS file as to why you are doing this?
I hope you are not trying to work around a bug in the driver by
stripping out DMA configuration from the device tree, because then
it is probably a better idea to fix the bug.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Pascal PAILLET-LME <p.paillet@st.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"biju.das@bp.renesas.com" <biju.das@bp.renesas.com>,
Yannick FERTRE <yannick.fertre@st.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"olof@lixom.net" <olof@lixom.net>,
"horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>
Subject: Re: [PATCH 1/3] ARM: dts: stm32: add stpmic1 support on stm32mp157c ed1 board
Date: Mon, 8 Apr 2019 14:05:10 +0200 [thread overview]
Message-ID: <CACRpkdZ9evBnvnmidQ2VW=dPUdGBM4Pkzo1VyMfDdQZFe6U7TA@mail.gmail.com> (raw)
In-Reply-To: <1554298852-9955-2-git-send-email-p.paillet@st.com>
On Wed, Apr 3, 2019 at 3:41 PM Pascal PAILLET-LME <p.paillet@st.com> wrote:
> This patch adds stpmic1 support on stm32mp157c ed1 board.
> The STPMIC1 is a PMIC from STMicroelectronics. The STPMIC1 integrates 10
> regulators, 3 power switches, a watchdog and an input for a power on key.
>
> Signed-off-by: Pascal Paillet <p.paillet@st.com>
OK
> + /delete-property/dmas;
> + /delete-property/dma-names;
Maybe you can add a comment both to the commit message and the
DTS file as to why you are doing this?
I hope you are not trying to work around a bug in the driver by
stripping out DMA configuration from the device tree, because then
it is probably a better idea to fix the bug.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-08 12:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 13:40 [PATCH 0/3] Add support for STPMIC1 Pascal PAILLET-LME
2019-04-03 13:40 ` Pascal PAILLET-LME
2019-04-03 13:40 ` Pascal PAILLET-LME
2019-04-03 13:40 ` [PATCH 2/3] ARM: dts: stm32: add stpmic1 support on stm32mp157a dk1 board Pascal PAILLET-LME
2019-04-03 13:40 ` Pascal PAILLET-LME
2019-04-03 13:40 ` Pascal PAILLET-LME
2019-04-08 12:06 ` Linus Walleij
2019-04-08 12:06 ` Linus Walleij
2019-04-08 12:06 ` Linus Walleij
2019-04-03 13:40 ` [PATCH 1/3] ARM: dts: stm32: add stpmic1 support on stm32mp157c ed1 board Pascal PAILLET-LME
2019-04-03 13:40 ` Pascal PAILLET-LME
2019-04-03 13:40 ` Pascal PAILLET-LME
2019-04-08 12:05 ` Linus Walleij [this message]
2019-04-08 12:05 ` Linus Walleij
2019-04-08 12:05 ` Linus Walleij
2019-04-08 12:26 ` Pascal PAILLET-LME
2019-04-08 12:26 ` Pascal PAILLET-LME
2019-04-08 13:06 ` Linus Walleij
2019-04-08 13:06 ` Linus Walleij
2019-04-08 13:06 ` Linus Walleij
2019-04-03 13:40 ` [PATCH 3/3] ARM: multi_v7_defconfig: Enable support for STPMIC1 Pascal PAILLET-LME
2019-04-03 13:40 ` Pascal PAILLET-LME
2019-04-03 13:40 ` Pascal PAILLET-LME
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZ9evBnvnmidQ2VW=dPUdGBM4Pkzo1VyMfDdQZFe6U7TA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olof@lixom.net \
--cc=p.paillet@st.com \
--cc=robh+dt@kernel.org \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.