All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
	linux-kernel@vger.kernel.org,
	Viresh Kumar <viresh.kumar@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/6] dma: coh901318_lli: avoid unbalanced locking
Date: Fri, 15 Feb 2013 15:52:10 +0100	[thread overview]
Message-ID: <CACRpkdZ=9pmutR2G+z5kQpjx2O6995OnDU8iN3cqar3TWoX=Lg@mail.gmail.com> (raw)
In-Reply-To: <1360666720-19006-4-git-send-email-andriy.shevchenko@linux.intel.com>

On Tue, Feb 12, 2013 at 11:58 AM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> I have not checked the code but there is a possibility that custom pool->lock
> is not needed at all due to dma_pool contains it's own lock.

Can you please change the description to something like:

"The coh901318_lli allocator releases a lock on the exit path without
taking it first".

Which is what the patch is actually fixing.

After that it's Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] dma: coh901318_lli: avoid unbalanced locking
Date: Fri, 15 Feb 2013 15:52:10 +0100	[thread overview]
Message-ID: <CACRpkdZ=9pmutR2G+z5kQpjx2O6995OnDU8iN3cqar3TWoX=Lg@mail.gmail.com> (raw)
In-Reply-To: <1360666720-19006-4-git-send-email-andriy.shevchenko@linux.intel.com>

On Tue, Feb 12, 2013 at 11:58 AM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> I have not checked the code but there is a possibility that custom pool->lock
> is not needed at all due to dma_pool contains it's own lock.

Can you please change the description to something like:

"The coh901318_lli allocator releases a lock on the exit path without
taking it first".

Which is what the patch is actually fixing.

After that it's Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

  parent reply	other threads:[~2013-02-15 14:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12 10:58 [PATCH 0/6] dma: various fixes in different DMAC drivers Andy Shevchenko
2013-02-12 10:58 ` [PATCH 1/6] of: dma: protect list write operation by spin_lock Andy Shevchenko
2013-02-12 10:58 ` [PATCH 2/6] dmaengine.h: remove redundant else keyword Andy Shevchenko
2013-02-12 15:01   ` Viresh Kumar
2013-02-12 10:58 ` [PATCH 3/6] dma: coh901318_lli: avoid unbalanced locking Andy Shevchenko
2013-02-12 10:58   ` Andy Shevchenko
2013-02-12 15:57   ` Viresh Kumar
2013-02-12 15:57     ` Viresh Kumar
2013-02-15 14:52   ` Linus Walleij [this message]
2013-02-15 14:52     ` Linus Walleij
2013-02-15 14:56     ` Andy Shevchenko
2013-02-15 14:56       ` Andy Shevchenko
2013-02-15 20:52       ` Linus Walleij
2013-02-15 20:52         ` Linus Walleij
2013-02-12 10:58 ` [PATCH 4/6] dma: coh901318_lli: set residue only if dma is in progress Andy Shevchenko
2013-02-12 10:58   ` Andy Shevchenko
2013-02-15 14:53   ` Linus Walleij
2013-02-15 14:53     ` Linus Walleij
2013-02-12 10:58 ` [PATCH 5/6] edma: do not waste memory for dma_mask Andy Shevchenko
2013-02-12 10:58 ` [PATCH 6/6] dma: tegra20-apb-dma: remove unnecessary assignment Andy Shevchenko
2013-02-13 12:40   ` Laxman Dewangan
2013-02-12 16:02 ` [PATCH 0/6] dma: various fixes in different DMAC drivers Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdZ=9pmutR2G+z5kQpjx2O6995OnDU8iN3cqar3TWoX=Lg@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vinod.koul@intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.