* [PATCH -next] gpio: loongson1: remove redundant return value check of platform_get_resource()
@ 2016-09-21 15:07 Wei Yongjun
2016-09-23 13:10 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-09-21 15:07 UTC (permalink / raw)
To: Keguang Zhang, Linus Walleij, Alexandre Courbot
Cc: Wei Yongjun, linux-mips, linux-gpio
From: Wei Yongjun <weiyongjun1@huawei.com>
Remove unneeded error handling on the result of a call
to platform_get_resource() when the value is passed to
devm_ioremap_resource().
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpio/gpio-loongson1.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpio/gpio-loongson1.c b/drivers/gpio/gpio-loongson1.c
index ad0a595..72b6403 100644
--- a/drivers/gpio/gpio-loongson1.c
+++ b/drivers/gpio/gpio-loongson1.c
@@ -56,11 +56,6 @@ static int ls1x_gpio_probe(struct platform_device *pdev)
return -ENOMEM;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- dev_err(dev, "failed to get I/O memory\n");
- return -EINVAL;
- }
-
gpio_reg_base = devm_ioremap_resource(dev, res);
if (IS_ERR(gpio_reg_base))
return PTR_ERR(gpio_reg_base);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] gpio: loongson1: remove redundant return value check of platform_get_resource()
2016-09-21 15:07 [PATCH -next] gpio: loongson1: remove redundant return value check of platform_get_resource() Wei Yongjun
@ 2016-09-23 13:10 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2016-09-23 13:10 UTC (permalink / raw)
To: Wei Yongjun
Cc: Keguang Zhang, Alexandre Courbot, Wei Yongjun, Linux MIPS, linux-gpio
On Wed, Sep 21, 2016 at 5:07 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Remove unneeded error handling on the result of a call
> to platform_get_resource() when the value is passed to
> devm_ioremap_resource().
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-23 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-21 15:07 [PATCH -next] gpio: loongson1: remove redundant return value check of platform_get_resource() Wei Yongjun
2016-09-23 13:10 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.