* [PATCH] pinctrl: bcm: fix kconfig dependency warning when !GPIOLIB
@ 2020-09-14 14:40 Necip Fazil Yildiran
2020-09-29 12:59 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Necip Fazil Yildiran @ 2020-09-14 14:40 UTC (permalink / raw)
To: linus.walleij; +Cc: linux-gpio, linux-kernel, paul, jeho, Necip Fazil Yildiran
When PINCTRL_BCM2835 is enabled and GPIOLIB is disabled, it results in the
following Kbuild warning:
WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
Depends on [n]: GPIOLIB [=n]
Selected by [y]:
- PINCTRL_BCM2835 [=y] && PINCTRL [=y] && OF [=y] && (ARCH_BCM2835 [=n] || ARCH_BRCMSTB [=n] || COMPILE_TEST [=y])
The reason is that PINCTRL_BCM2835 selects GPIOLIB_IRQCHIP without
depending on or selecting GPIOLIB while GPIOLIB_IRQCHIP is subordinate to
GPIOLIB.
Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
Fixes: 85ae9e512f43 ("pinctrl: bcm2835: switch to GPIOLIB_IRQCHIP")
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
---
drivers/pinctrl/bcm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/bcm/Kconfig b/drivers/pinctrl/bcm/Kconfig
index dcf7df797af7..0ed14de0134c 100644
--- a/drivers/pinctrl/bcm/Kconfig
+++ b/drivers/pinctrl/bcm/Kconfig
@@ -23,6 +23,7 @@ config PINCTRL_BCM2835
select PINMUX
select PINCONF
select GENERIC_PINCONF
+ select GPIOLIB
select GPIOLIB_IRQCHIP
default ARCH_BCM2835 || ARCH_BRCMSTB
help
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: bcm: fix kconfig dependency warning when !GPIOLIB
2020-09-14 14:40 [PATCH] pinctrl: bcm: fix kconfig dependency warning when !GPIOLIB Necip Fazil Yildiran
@ 2020-09-29 12:59 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2020-09-29 12:59 UTC (permalink / raw)
To: Necip Fazil Yildiran; +Cc: open list:GPIO SUBSYSTEM, linux-kernel, paul, jeho
On Mon, Sep 14, 2020 at 4:41 PM Necip Fazil Yildiran
<fazilyildiran@gmail.com> wrote:
> When PINCTRL_BCM2835 is enabled and GPIOLIB is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
> Depends on [n]: GPIOLIB [=n]
> Selected by [y]:
> - PINCTRL_BCM2835 [=y] && PINCTRL [=y] && OF [=y] && (ARCH_BCM2835 [=n] || ARCH_BRCMSTB [=n] || COMPILE_TEST [=y])
>
> The reason is that PINCTRL_BCM2835 selects GPIOLIB_IRQCHIP without
> depending on or selecting GPIOLIB while GPIOLIB_IRQCHIP is subordinate to
> GPIOLIB.
>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Fixes: 85ae9e512f43 ("pinctrl: bcm2835: switch to GPIOLIB_IRQCHIP")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Patch applied to non-critical fixes, thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-29 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-14 14:40 [PATCH] pinctrl: bcm: fix kconfig dependency warning when !GPIOLIB Necip Fazil Yildiran
2020-09-29 12:59 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.