From: Linus Walleij <linus.walleij@linaro.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Chen-Yu Tsai <wens@csie.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 3/6] pinctrl: sunxi: Fix variable assignment syntax
Date: Thu, 4 Apr 2019 08:57:08 +0700 [thread overview]
Message-ID: <CACRpkdZSfqwcmLMyFL+Y=pGxyaqr2PPz3aEwGwmAgM_6dbT1fA@mail.gmail.com> (raw)
In-Reply-To: <d2307f2648901d1950a1516ad5ffd70f6d595898.1552591798.git-series.maxime.ripard@bootlin.com>
On Fri, Mar 15, 2019 at 2:33 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> Lines are usually ended with a semi-column in C, yet this was copied from a
> structure declaration to the init variant while keeping the comma at the
> end. Make sure we have a normal syntax, instead of multiple assignments.
>
> Fixes: d83c82ce7ccd ("pinctrl: sunxi: support multiple pin controller")
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Patch applied.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Chen-Yu Tsai <wens@csie.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 3/6] pinctrl: sunxi: Fix variable assignment syntax
Date: Thu, 4 Apr 2019 08:57:08 +0700 [thread overview]
Message-ID: <CACRpkdZSfqwcmLMyFL+Y=pGxyaqr2PPz3aEwGwmAgM_6dbT1fA@mail.gmail.com> (raw)
In-Reply-To: <d2307f2648901d1950a1516ad5ffd70f6d595898.1552591798.git-series.maxime.ripard@bootlin.com>
On Fri, Mar 15, 2019 at 2:33 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> Lines are usually ended with a semi-column in C, yet this was copied from a
> structure declaration to the init variant while keeping the comma at the
> end. Make sure we have a normal syntax, instead of multiple assignments.
>
> Fixes: d83c82ce7ccd ("pinctrl: sunxi: support multiple pin controller")
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Patch applied.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-04 1:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 19:32 [PATCH 0/6] pinctrl: sunxi: Allow to configure pull-up / pull-down from GPIO flags Maxime Ripard
2019-03-14 19:32 ` Maxime Ripard
2019-03-14 19:32 ` [PATCH 1/6] gpio: Set proper argument value to set_config Maxime Ripard
2019-03-14 19:32 ` Maxime Ripard
2019-04-03 16:41 ` Linus Walleij
2019-04-03 16:41 ` Linus Walleij
2019-04-03 18:36 ` Maxime Ripard
2019-04-04 4:56 ` Linus Walleij
2019-04-04 4:56 ` Linus Walleij
2019-03-14 19:32 ` [PATCH 2/6] pinctrl: sunxi: implement pin_config_set Maxime Ripard
2019-03-14 19:32 ` Maxime Ripard
2019-04-04 1:56 ` Linus Walleij
2019-04-04 1:56 ` Linus Walleij
2019-03-14 19:32 ` [PATCH 3/6] pinctrl: sunxi: Fix variable assignment syntax Maxime Ripard
2019-03-14 19:32 ` Maxime Ripard
2019-04-04 1:57 ` Linus Walleij [this message]
2019-04-04 1:57 ` Linus Walleij
2019-03-14 19:32 ` [PATCH 4/6] pinctrl: sunxi: Declare set_config on the GPIO chip Maxime Ripard
2019-03-14 19:32 ` Maxime Ripard
2019-04-04 3:27 ` Linus Walleij
2019-04-04 3:27 ` Linus Walleij
2019-03-14 19:32 ` [PATCH 5/6] ARM: dts: sunxi: Remove pinctrl groups setting bias Maxime Ripard
2019-03-14 19:32 ` Maxime Ripard
2019-04-04 3:29 ` Linus Walleij
2019-04-04 3:29 ` Linus Walleij
2019-03-14 19:32 ` [PATCH 6/6] ARM: dts: sunxi: Remove useless pinctrl nodes Maxime Ripard
2019-03-14 19:32 ` Maxime Ripard
2019-04-04 3:30 ` Linus Walleij
2019-04-04 3:30 ` Linus Walleij
2019-03-15 2:57 ` [PATCH 0/6] pinctrl: sunxi: Allow to configure pull-up / pull-down from GPIO flags Chen-Yu Tsai
2019-03-15 2:57 ` Chen-Yu Tsai
2019-04-02 13:22 ` Maxime Ripard
2019-04-04 7:26 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZSfqwcmLMyFL+Y=pGxyaqr2PPz3aEwGwmAgM_6dbT1fA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.