From: Linus Walleij <linus.walleij@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Dong Aisheng <b29396@freescale.com>,
Denis Carikli <denis@eukrea.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Shawn Guo <shawn.guo@linaro.org>,
Sascha Hauer <kernel@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] pinctrl: imx25: fix numbering for pins
Date: Tue, 3 Feb 2015 14:03:56 +0100 [thread overview]
Message-ID: <CACRpkdZT64A8ZYyVzSM=S-_xRnge4o5ntBeGi2UiOfXPyaEYAA@mail.gmail.com> (raw)
In-Reply-To: <1422402356-12171-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Wed, Jan 28, 2015 at 12:45 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> The pin id for a given tuple listed in a fsl,pins property is calculated
> by dividing the first entry (which is also a register offset) by 4.
> As the first available register is at offset 0x8 and configures the pad
> MX25_PAD_A10 the right id for this pin is 2. All other pins are off by
> one, too.
>
> This patch drops the definition MX25_PAD_RESERVE1 (together with its
> only use) and decrements all following values by 1.
>
> Fixes: b4a87c9b966f ("pinctrl: pinctrl-imx: add imx25 pinctrl driver")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Patch applied with Fabio's Test tag.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: imx25: fix numbering for pins
Date: Tue, 3 Feb 2015 14:03:56 +0100 [thread overview]
Message-ID: <CACRpkdZT64A8ZYyVzSM=S-_xRnge4o5ntBeGi2UiOfXPyaEYAA@mail.gmail.com> (raw)
In-Reply-To: <1422402356-12171-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Wed, Jan 28, 2015 at 12:45 AM, Uwe Kleine-K?nig
<u.kleine-koenig@pengutronix.de> wrote:
> The pin id for a given tuple listed in a fsl,pins property is calculated
> by dividing the first entry (which is also a register offset) by 4.
> As the first available register is at offset 0x8 and configures the pad
> MX25_PAD_A10 the right id for this pin is 2. All other pins are off by
> one, too.
>
> This patch drops the definition MX25_PAD_RESERVE1 (together with its
> only use) and decrements all following values by 1.
>
> Fixes: b4a87c9b966f ("pinctrl: pinctrl-imx: add imx25 pinctrl driver")
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Patch applied with Fabio's Test tag.
Yours,
Linus Walleij
next prev parent reply other threads:[~2015-02-03 13:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 23:24 pinctrl-imx: calculation of pinid bogus for i.MX25 Uwe Kleine-König
2015-01-27 23:24 ` Uwe Kleine-König
2015-01-27 23:45 ` [PATCH] pinctrl: imx25: fix numbering for pins Uwe Kleine-König
2015-01-27 23:45 ` Uwe Kleine-König
2015-01-28 0:39 ` Fabio Estevam
2015-01-28 0:39 ` Fabio Estevam
2015-02-03 13:03 ` Linus Walleij [this message]
2015-02-03 13:03 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZT64A8ZYyVzSM=S-_xRnge4o5ntBeGi2UiOfXPyaEYAA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=b29396@freescale.com \
--cc=denis@eukrea.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.