All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pinctrl/at91: Don't provide a default trigger type
@ 2016-09-06 13:58 ` Marc Zyngier
  0 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2016-09-06 13:58 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Andras Szemzo, linux-arm-kernel, linux-kernel, Nicolas Ferre,
	Jean-Christophe PLAGNIOL-VILLARD

at91 used to set a default trigger type for GPIO interrupts in
order to cope with the old board files. These days are long gone,
and it all gets probed through DT.

Andras Szemzo reported that the Ethernet device on his board was
bailing to be probed, due to a conflict in interrupt trigger.
Surely enough, this is due to this default trigger still being
present, and turning this into a IRQ_TYPE_NONE fixes the issue.

Reported-by: Andras Szemzo <szemzo.andras@gmail.com>
Tested-by: Andras Szemzo <szemzo.andras@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
 drivers/pinctrl/pinctrl-at91.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index 80daead..9f09041 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -1614,7 +1614,7 @@ static int at91_gpio_of_irq_setup(struct platform_device *pdev,
 				   &gpio_irqchip,
 				   0,
 				   handle_edge_irq,
-				   IRQ_TYPE_EDGE_BOTH);
+				   IRQ_TYPE_NONE);
 	if (ret) {
 		dev_err(&pdev->dev, "at91_gpio.%d: Couldn't add irqchip to gpiochip.\n",
 			at91_gpio->pioc_idx);
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] pinctrl/at91: Don't provide a default trigger type
@ 2016-09-06 13:58 ` Marc Zyngier
  0 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2016-09-06 13:58 UTC (permalink / raw)
  To: linux-arm-kernel

at91 used to set a default trigger type for GPIO interrupts in
order to cope with the old board files. These days are long gone,
and it all gets probed through DT.

Andras Szemzo reported that the Ethernet device on his board was
bailing to be probed, due to a conflict in interrupt trigger.
Surely enough, this is due to this default trigger still being
present, and turning this into a IRQ_TYPE_NONE fixes the issue.

Reported-by: Andras Szemzo <szemzo.andras@gmail.com>
Tested-by: Andras Szemzo <szemzo.andras@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
 drivers/pinctrl/pinctrl-at91.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index 80daead..9f09041 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -1614,7 +1614,7 @@ static int at91_gpio_of_irq_setup(struct platform_device *pdev,
 				   &gpio_irqchip,
 				   0,
 				   handle_edge_irq,
-				   IRQ_TYPE_EDGE_BOTH);
+				   IRQ_TYPE_NONE);
 	if (ret) {
 		dev_err(&pdev->dev, "at91_gpio.%d: Couldn't add irqchip to gpiochip.\n",
 			at91_gpio->pioc_idx);
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl/at91: Don't provide a default trigger type
  2016-09-06 13:58 ` Marc Zyngier
@ 2016-09-07  9:59   ` Nicolas Ferre
  -1 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2016-09-07  9:59 UTC (permalink / raw)
  To: Marc Zyngier, Linus Walleij
  Cc: Andras Szemzo, linux-arm-kernel, linux-kernel,
	Jean-Christophe PLAGNIOL-VILLARD

Le 06/09/2016 à 15:58, Marc Zyngier a écrit :
> at91 used to set a default trigger type for GPIO interrupts in
> order to cope with the old board files. These days are long gone,
> and it all gets probed through DT.
> 
> Andras Szemzo reported that the Ethernet device on his board was
> bailing to be probed, due to a conflict in interrupt trigger.
> Surely enough, this is due to this default trigger still being
> present, and turning this into a IRQ_TYPE_NONE fixes the issue.
> 
> Reported-by: Andras Szemzo <szemzo.andras@gmail.com>
> Tested-by: Andras Szemzo <szemzo.andras@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks, bye,

> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
>  drivers/pinctrl/pinctrl-at91.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index 80daead..9f09041 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -1614,7 +1614,7 @@ static int at91_gpio_of_irq_setup(struct platform_device *pdev,
>  				   &gpio_irqchip,
>  				   0,
>  				   handle_edge_irq,
> -				   IRQ_TYPE_EDGE_BOTH);
> +				   IRQ_TYPE_NONE);
>  	if (ret) {
>  		dev_err(&pdev->dev, "at91_gpio.%d: Couldn't add irqchip to gpiochip.\n",
>  			at91_gpio->pioc_idx);
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] pinctrl/at91: Don't provide a default trigger type
@ 2016-09-07  9:59   ` Nicolas Ferre
  0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2016-09-07  9:59 UTC (permalink / raw)
  To: linux-arm-kernel

Le 06/09/2016 ? 15:58, Marc Zyngier a ?crit :
> at91 used to set a default trigger type for GPIO interrupts in
> order to cope with the old board files. These days are long gone,
> and it all gets probed through DT.
> 
> Andras Szemzo reported that the Ethernet device on his board was
> bailing to be probed, due to a conflict in interrupt trigger.
> Surely enough, this is due to this default trigger still being
> present, and turning this into a IRQ_TYPE_NONE fixes the issue.
> 
> Reported-by: Andras Szemzo <szemzo.andras@gmail.com>
> Tested-by: Andras Szemzo <szemzo.andras@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks, bye,

> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
>  drivers/pinctrl/pinctrl-at91.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index 80daead..9f09041 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -1614,7 +1614,7 @@ static int at91_gpio_of_irq_setup(struct platform_device *pdev,
>  				   &gpio_irqchip,
>  				   0,
>  				   handle_edge_irq,
> -				   IRQ_TYPE_EDGE_BOTH);
> +				   IRQ_TYPE_NONE);
>  	if (ret) {
>  		dev_err(&pdev->dev, "at91_gpio.%d: Couldn't add irqchip to gpiochip.\n",
>  			at91_gpio->pioc_idx);
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl/at91: Don't provide a default trigger type
  2016-09-06 13:58 ` Marc Zyngier
@ 2016-09-12 12:17   ` Linus Walleij
  -1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2016-09-12 12:17 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: Andras Szemzo, linux-arm-kernel, linux-kernel, Nicolas Ferre,
	Jean-Christophe PLAGNIOL-VILLARD

On Tue, Sep 6, 2016 at 3:58 PM, Marc Zyngier <marc.zyngier@arm.com> wrote:

> at91 used to set a default trigger type for GPIO interrupts in
> order to cope with the old board files. These days are long gone,
> and it all gets probed through DT.
>
> Andras Szemzo reported that the Ethernet device on his board was
> bailing to be probed, due to a conflict in interrupt trigger.
> Surely enough, this is due to this default trigger still being
> present, and turning this into a IRQ_TYPE_NONE fixes the issue.
>
> Reported-by: Andras Szemzo <szemzo.andras@gmail.com>
> Tested-by: Andras Szemzo <szemzo.andras@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

Patch applied with Nico's ACK.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] pinctrl/at91: Don't provide a default trigger type
@ 2016-09-12 12:17   ` Linus Walleij
  0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2016-09-12 12:17 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Sep 6, 2016 at 3:58 PM, Marc Zyngier <marc.zyngier@arm.com> wrote:

> at91 used to set a default trigger type for GPIO interrupts in
> order to cope with the old board files. These days are long gone,
> and it all gets probed through DT.
>
> Andras Szemzo reported that the Ethernet device on his board was
> bailing to be probed, due to a conflict in interrupt trigger.
> Surely enough, this is due to this default trigger still being
> present, and turning this into a IRQ_TYPE_NONE fixes the issue.
>
> Reported-by: Andras Szemzo <szemzo.andras@gmail.com>
> Tested-by: Andras Szemzo <szemzo.andras@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

Patch applied with Nico's ACK.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-12 12:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-06 13:58 [PATCH] pinctrl/at91: Don't provide a default trigger type Marc Zyngier
2016-09-06 13:58 ` Marc Zyngier
2016-09-07  9:59 ` Nicolas Ferre
2016-09-07  9:59   ` Nicolas Ferre
2016-09-12 12:17 ` Linus Walleij
2016-09-12 12:17   ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.