* [PATCH 0/2] pinctrl: nand: meson: fix missing data pins
@ 2018-05-09 22:08 ` Yixun Lan
0 siblings, 0 replies; 15+ messages in thread
From: Yixun Lan @ 2018-05-09 22:08 UTC (permalink / raw)
To: linus-amlogic
Hi Linus
We found the data pins of NAND controller are actually mising from
the nand pinctrl group in the GXBB, GXL SoC driver, these two patches
will fix these issue.
I have prepared the two patches separated with different Fix tag,
but I can squash them into one patch if you prefer, since the meson nand
driver has never been pushed into mainline (so probably the Fix tag is
useless).
Btw, the patches are formated on top your 'for-next' branch,
and I'm fine with this merged as for-next.
Thanks
Yixun Lan (2):
pinctrl: nand: meson-gxbb: fix missing data pins
pinctrl: nand: meson-gxl: fix missing data pins
drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 4 ++--
drivers/pinctrl/meson/pinctrl-meson-gxl.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
--
2.17.0
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/2] pinctrl: nand: meson: fix missing data pins
@ 2018-05-09 22:08 ` Yixun Lan
0 siblings, 0 replies; 15+ messages in thread
From: Yixun Lan @ 2018-05-09 22:08 UTC (permalink / raw)
To: linux-arm-kernel
Hi Linus
We found the data pins of NAND controller are actually mising from
the nand pinctrl group in the GXBB, GXL SoC driver, these two patches
will fix these issue.
I have prepared the two patches separated with different Fix tag,
but I can squash them into one patch if you prefer, since the meson nand
driver has never been pushed into mainline (so probably the Fix tag is
useless).
Btw, the patches are formated on top your 'for-next' branch,
and I'm fine with this merged as for-next.
Thanks
Yixun Lan (2):
pinctrl: nand: meson-gxbb: fix missing data pins
pinctrl: nand: meson-gxl: fix missing data pins
drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 4 ++--
drivers/pinctrl/meson/pinctrl-meson-gxl.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
--
2.17.0
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/2] pinctrl: nand: meson: fix missing data pins
@ 2018-05-09 22:08 ` Yixun Lan
0 siblings, 0 replies; 15+ messages in thread
From: Yixun Lan @ 2018-05-09 22:08 UTC (permalink / raw)
To: Linus Walleij
Cc: Yixun Lan, Kevin Hilman, Carlo Caione, Jerome Brunet,
Xingyu Chen, Liang Yang, linux-gpio, linux-amlogic,
linux-arm-kernel, linux-kernel
Hi Linus
We found the data pins of NAND controller are actually mising from
the nand pinctrl group in the GXBB, GXL SoC driver, these two patches
will fix these issue.
I have prepared the two patches separated with different Fix tag,
but I can squash them into one patch if you prefer, since the meson nand
driver has never been pushed into mainline (so probably the Fix tag is
useless).
Btw, the patches are formated on top your 'for-next' branch,
and I'm fine with this merged as for-next.
Thanks
Yixun Lan (2):
pinctrl: nand: meson-gxbb: fix missing data pins
pinctrl: nand: meson-gxl: fix missing data pins
drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 4 ++--
drivers/pinctrl/meson/pinctrl-meson-gxl.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
--
2.17.0
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/2] pinctrl: nand: meson-gxbb: fix missing data pins
2018-05-09 22:08 ` Yixun Lan
(?)
(?)
@ 2018-05-09 22:08 ` Yixun Lan
-1 siblings, 0 replies; 15+ messages in thread
From: Yixun Lan @ 2018-05-09 22:08 UTC (permalink / raw)
To: Linus Walleij
Cc: Yixun Lan, Kevin Hilman, Carlo Caione, Jerome Brunet,
Xingyu Chen, Liang Yang, linux-gpio, linux-amlogic,
linux-arm-kernel, linux-kernel
The data pin 0-7 of the NAND controller are actually missing from
the nand pinctrl group, so we fix it here.
Fixes: cd1e3b01c7d3 ("pinctrl: amlogic: gxbb: add nand pins")
Reported-by: Liang Yang <liang.yang@amlogic.com>
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
index 9079020259c5..2c97a2e07a5f 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
@@ -627,8 +627,8 @@ static const char * const sdio_groups[] = {
};
static const char * const nand_groups[] = {
- "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale", "nand_cle",
- "nand_wen_clk", "nand_ren_wr", "nand_dqs",
+ "emmc_nand_d07", "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale",
+ "nand_cle", "nand_wen_clk", "nand_ren_wr", "nand_dqs",
};
static const char * const uart_a_groups[] = {
--
2.17.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 1/2] pinctrl: nand: meson-gxbb: fix missing data pins
@ 2018-05-09 22:08 ` Yixun Lan
0 siblings, 0 replies; 15+ messages in thread
From: Yixun Lan @ 2018-05-09 22:08 UTC (permalink / raw)
To: linus-amlogic
The data pin 0-7 of the NAND controller are actually missing from
the nand pinctrl group, so we fix it here.
Fixes: cd1e3b01c7d3 ("pinctrl: amlogic: gxbb: add nand pins")
Reported-by: Liang Yang <liang.yang@amlogic.com>
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
index 9079020259c5..2c97a2e07a5f 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
@@ -627,8 +627,8 @@ static const char * const sdio_groups[] = {
};
static const char * const nand_groups[] = {
- "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale", "nand_cle",
- "nand_wen_clk", "nand_ren_wr", "nand_dqs",
+ "emmc_nand_d07", "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale",
+ "nand_cle", "nand_wen_clk", "nand_ren_wr", "nand_dqs",
};
static const char * const uart_a_groups[] = {
--
2.17.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 1/2] pinctrl: nand: meson-gxbb: fix missing data pins
@ 2018-05-09 22:08 ` Yixun Lan
0 siblings, 0 replies; 15+ messages in thread
From: Yixun Lan @ 2018-05-09 22:08 UTC (permalink / raw)
To: linux-arm-kernel
The data pin 0-7 of the NAND controller are actually missing from
the nand pinctrl group, so we fix it here.
Fixes: cd1e3b01c7d3 ("pinctrl: amlogic: gxbb: add nand pins")
Reported-by: Liang Yang <liang.yang@amlogic.com>
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
index 9079020259c5..2c97a2e07a5f 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
@@ -627,8 +627,8 @@ static const char * const sdio_groups[] = {
};
static const char * const nand_groups[] = {
- "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale", "nand_cle",
- "nand_wen_clk", "nand_ren_wr", "nand_dqs",
+ "emmc_nand_d07", "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale",
+ "nand_cle", "nand_wen_clk", "nand_ren_wr", "nand_dqs",
};
static const char * const uart_a_groups[] = {
--
2.17.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 1/2] pinctrl: nand: meson-gxbb: fix missing data pins
@ 2018-05-09 22:08 ` Yixun Lan
0 siblings, 0 replies; 15+ messages in thread
From: Yixun Lan @ 2018-05-09 22:08 UTC (permalink / raw)
To: Linus Walleij
Cc: Yixun Lan, Kevin Hilman, Carlo Caione, Jerome Brunet,
Xingyu Chen, Liang Yang, linux-gpio, linux-amlogic,
linux-arm-kernel, linux-kernel
The data pin 0-7 of the NAND controller are actually missing from
the nand pinctrl group, so we fix it here.
Fixes: cd1e3b01c7d3 ("pinctrl: amlogic: gxbb: add nand pins")
Reported-by: Liang Yang <liang.yang@amlogic.com>
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
index 9079020259c5..2c97a2e07a5f 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
@@ -627,8 +627,8 @@ static const char * const sdio_groups[] = {
};
static const char * const nand_groups[] = {
- "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale", "nand_cle",
- "nand_wen_clk", "nand_ren_wr", "nand_dqs",
+ "emmc_nand_d07", "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale",
+ "nand_cle", "nand_wen_clk", "nand_ren_wr", "nand_dqs",
};
static const char * const uart_a_groups[] = {
--
2.17.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 1/2] pinctrl: nand: meson-gxbb: fix missing data pins
2018-05-09 22:08 ` Yixun Lan
(?)
@ 2018-05-16 14:23 ` Linus Walleij
-1 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2018-05-16 14:23 UTC (permalink / raw)
To: Yixun Lan
Cc: Kevin Hilman, Carlo Caione, Jerome Brunet, Xingyu Chen,
Liang Yang, open list:GPIO SUBSYSTEM,
open list:ARM/Amlogic Meson...,
Linux ARM, linux-kernel
On Thu, May 10, 2018 at 12:08 AM, Yixun Lan <yixun.lan@amlogic.com> wrote:
> The data pin 0-7 of the NAND controller are actually missing from
> the nand pinctrl group, so we fix it here.
>
> Fixes: cd1e3b01c7d3 ("pinctrl: amlogic: gxbb: add nand pins")
> Reported-by: Liang Yang <liang.yang@amlogic.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 1/2] pinctrl: nand: meson-gxbb: fix missing data pins
@ 2018-05-16 14:23 ` Linus Walleij
0 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2018-05-16 14:23 UTC (permalink / raw)
To: linus-amlogic
On Thu, May 10, 2018 at 12:08 AM, Yixun Lan <yixun.lan@amlogic.com> wrote:
> The data pin 0-7 of the NAND controller are actually missing from
> the nand pinctrl group, so we fix it here.
>
> Fixes: cd1e3b01c7d3 ("pinctrl: amlogic: gxbb: add nand pins")
> Reported-by: Liang Yang <liang.yang@amlogic.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 1/2] pinctrl: nand: meson-gxbb: fix missing data pins
@ 2018-05-16 14:23 ` Linus Walleij
0 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2018-05-16 14:23 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, May 10, 2018 at 12:08 AM, Yixun Lan <yixun.lan@amlogic.com> wrote:
> The data pin 0-7 of the NAND controller are actually missing from
> the nand pinctrl group, so we fix it here.
>
> Fixes: cd1e3b01c7d3 ("pinctrl: amlogic: gxbb: add nand pins")
> Reported-by: Liang Yang <liang.yang@amlogic.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] pinctrl: nand: meson-gxl: fix missing data pins
2018-05-09 22:08 ` Yixun Lan
(?)
(?)
@ 2018-05-09 22:08 ` Yixun Lan
-1 siblings, 0 replies; 15+ messages in thread
From: Yixun Lan @ 2018-05-09 22:08 UTC (permalink / raw)
To: Linus Walleij
Cc: Yixun Lan, Kevin Hilman, Carlo Caione, Jerome Brunet,
Xingyu Chen, Liang Yang, linux-gpio, linux-amlogic,
linux-arm-kernel, linux-kernel
The data pin 0-7 of the NAND controller are actually missing from
the nand pinctrl group, so we fix it here.
Fixes: 0f15f500ff2c ("pinctrl: meson: Add GXL pinctrl definitions")
Reported-by: Liang Yang <liang.yang@amlogic.com>
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
drivers/pinctrl/meson/pinctrl-meson-gxl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
index b3786cde963d..7dae1d7bf6b0 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-gxl.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
@@ -617,8 +617,8 @@ static const char * const sdio_groups[] = {
};
static const char * const nand_groups[] = {
- "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale", "nand_cle",
- "nand_wen_clk", "nand_ren_wr", "nand_dqs",
+ "emmc_nand_d07", "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale",
+ "nand_cle", "nand_wen_clk", "nand_ren_wr", "nand_dqs",
};
static const char * const uart_a_groups[] = {
--
2.17.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 2/2] pinctrl: nand: meson-gxl: fix missing data pins
@ 2018-05-09 22:08 ` Yixun Lan
0 siblings, 0 replies; 15+ messages in thread
From: Yixun Lan @ 2018-05-09 22:08 UTC (permalink / raw)
To: linus-amlogic
The data pin 0-7 of the NAND controller are actually missing from
the nand pinctrl group, so we fix it here.
Fixes: 0f15f500ff2c ("pinctrl: meson: Add GXL pinctrl definitions")
Reported-by: Liang Yang <liang.yang@amlogic.com>
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
drivers/pinctrl/meson/pinctrl-meson-gxl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
index b3786cde963d..7dae1d7bf6b0 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-gxl.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
@@ -617,8 +617,8 @@ static const char * const sdio_groups[] = {
};
static const char * const nand_groups[] = {
- "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale", "nand_cle",
- "nand_wen_clk", "nand_ren_wr", "nand_dqs",
+ "emmc_nand_d07", "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale",
+ "nand_cle", "nand_wen_clk", "nand_ren_wr", "nand_dqs",
};
static const char * const uart_a_groups[] = {
--
2.17.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 2/2] pinctrl: nand: meson-gxl: fix missing data pins
@ 2018-05-09 22:08 ` Yixun Lan
0 siblings, 0 replies; 15+ messages in thread
From: Yixun Lan @ 2018-05-09 22:08 UTC (permalink / raw)
To: linux-arm-kernel
The data pin 0-7 of the NAND controller are actually missing from
the nand pinctrl group, so we fix it here.
Fixes: 0f15f500ff2c ("pinctrl: meson: Add GXL pinctrl definitions")
Reported-by: Liang Yang <liang.yang@amlogic.com>
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
drivers/pinctrl/meson/pinctrl-meson-gxl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
index b3786cde963d..7dae1d7bf6b0 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-gxl.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
@@ -617,8 +617,8 @@ static const char * const sdio_groups[] = {
};
static const char * const nand_groups[] = {
- "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale", "nand_cle",
- "nand_wen_clk", "nand_ren_wr", "nand_dqs",
+ "emmc_nand_d07", "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale",
+ "nand_cle", "nand_wen_clk", "nand_ren_wr", "nand_dqs",
};
static const char * const uart_a_groups[] = {
--
2.17.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 2/2] pinctrl: nand: meson-gxl: fix missing data pins
@ 2018-05-09 22:08 ` Yixun Lan
0 siblings, 0 replies; 15+ messages in thread
From: Yixun Lan @ 2018-05-09 22:08 UTC (permalink / raw)
To: Linus Walleij
Cc: Yixun Lan, Kevin Hilman, Carlo Caione, Jerome Brunet,
Xingyu Chen, Liang Yang, linux-gpio, linux-amlogic,
linux-arm-kernel, linux-kernel
The data pin 0-7 of the NAND controller are actually missing from
the nand pinctrl group, so we fix it here.
Fixes: 0f15f500ff2c ("pinctrl: meson: Add GXL pinctrl definitions")
Reported-by: Liang Yang <liang.yang@amlogic.com>
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
drivers/pinctrl/meson/pinctrl-meson-gxl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
index b3786cde963d..7dae1d7bf6b0 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-gxl.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
@@ -617,8 +617,8 @@ static const char * const sdio_groups[] = {
};
static const char * const nand_groups[] = {
- "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale", "nand_cle",
- "nand_wen_clk", "nand_ren_wr", "nand_dqs",
+ "emmc_nand_d07", "nand_ce0", "nand_ce1", "nand_rb0", "nand_ale",
+ "nand_cle", "nand_wen_clk", "nand_ren_wr", "nand_dqs",
};
static const char * const uart_a_groups[] = {
--
2.17.0
^ permalink raw reply related [flat|nested] 15+ messages in thread