* [PATCH] leds: ipaq needs LEDS_CLASS
@ 2015-01-28 20:05 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2015-01-28 20:05 UTC (permalink / raw)
To: Bryan Wu
Cc: Linus Walleij, Richard Purdie, linux-leds, Philipp Zabel,
Paul Parsons, linux-arm-kernel
All other drivers have a dependency on this already, but this one
does not, which can lead to a link error when LEDS_CLASS is not set.
drivers/built-in.o: In function `micro_leds_remove':
:(.text+0x13d1bc): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `micro_leds_probe':
:(.text+0x13d3d0): undefined reference to `led_classdev_register'
This patch adds the missing dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 95029dfd311a..927bb4491e1c 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -144,6 +144,7 @@ config LEDS_SUNFIRE
config LEDS_IPAQ_MICRO
tristate "LED Support for the Compaq iPAQ h3xxx"
+ depends on LEDS_CLASS
depends on MFD_IPAQ_MICRO
help
Choose this option if you want to use the notification LED on
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] leds: ipaq needs LEDS_CLASS
@ 2015-01-28 20:05 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2015-01-28 20:05 UTC (permalink / raw)
To: linux-arm-kernel
All other drivers have a dependency on this already, but this one
does not, which can lead to a link error when LEDS_CLASS is not set.
drivers/built-in.o: In function `micro_leds_remove':
:(.text+0x13d1bc): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `micro_leds_probe':
:(.text+0x13d3d0): undefined reference to `led_classdev_register'
This patch adds the missing dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 95029dfd311a..927bb4491e1c 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -144,6 +144,7 @@ config LEDS_SUNFIRE
config LEDS_IPAQ_MICRO
tristate "LED Support for the Compaq iPAQ h3xxx"
+ depends on LEDS_CLASS
depends on MFD_IPAQ_MICRO
help
Choose this option if you want to use the notification LED on
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: ipaq needs LEDS_CLASS
2015-01-28 20:05 ` Arnd Bergmann
@ 2015-01-29 9:24 ` Linus Walleij
-1 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2015-01-29 9:24 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bryan Wu, Richard Purdie, linux-leds, linux-arm-kernel,
Philipp Zabel, Paul Parsons
On Wed, Jan 28, 2015 at 9:05 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> All other drivers have a dependency on this already, but this one
> does not, which can lead to a link error when LEDS_CLASS is not set.
>
> drivers/built-in.o: In function `micro_leds_remove':
> :(.text+0x13d1bc): undefined reference to `led_classdev_unregister'
> drivers/built-in.o: In function `micro_leds_probe':
> :(.text+0x13d3d0): undefined reference to `led_classdev_register'
>
> This patch adds the missing dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Sorry for screwing up...
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] leds: ipaq needs LEDS_CLASS
@ 2015-01-29 9:24 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2015-01-29 9:24 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 28, 2015 at 9:05 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> All other drivers have a dependency on this already, but this one
> does not, which can lead to a link error when LEDS_CLASS is not set.
>
> drivers/built-in.o: In function `micro_leds_remove':
> :(.text+0x13d1bc): undefined reference to `led_classdev_unregister'
> drivers/built-in.o: In function `micro_leds_probe':
> :(.text+0x13d3d0): undefined reference to `led_classdev_register'
>
> This patch adds the missing dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Sorry for screwing up...
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-29 9:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28 20:05 [PATCH] leds: ipaq needs LEDS_CLASS Arnd Bergmann
2015-01-28 20:05 ` Arnd Bergmann
2015-01-29 9:24 ` Linus Walleij
2015-01-29 9:24 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.