* [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency
@ 2017-05-29 12:57 Arnd Bergmann
2017-05-29 12:57 ` [PATCH 2/2] pinctrl: " Arnd Bergmann
2017-05-29 16:45 ` [PATCH 1/2] gpio: " Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Arnd Bergmann @ 2017-05-29 12:57 UTC (permalink / raw)
To: Linus Walleij; +Cc: Paul Cercueil, Arnd Bergmann, linux-gpio, linux-kernel
The driver cannot access the of_node field when CONFIG_OF is disabled:
drivers/gpio/gpio-ingenic.c: In function 'ingenic_gpio_probe':
drivers/gpio/gpio-ingenic.c:324:10: error: 'struct gpio_chip' has no member named 'of_node'
Fixes: b0653ce39a0d ("gpio: Add gpio-ingenic driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpio/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index fe25de1b187c..436c38cdb297 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -245,6 +245,7 @@ config GPIO_ICH
config GPIO_INGENIC
tristate "Ingenic JZ47xx SoCs GPIO support"
depends on MACH_INGENIC || COMPILE_TEST
+ depends on OF
select GPIOLIB_IRQCHIP
help
Say yes here to support the GPIO functionality present on the
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] pinctrl: ingenic: add CONFIG_OF dependency
2017-05-29 12:57 [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency Arnd Bergmann
@ 2017-05-29 12:57 ` Arnd Bergmann
2017-05-29 16:45 ` [PATCH 1/2] gpio: " Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2017-05-29 12:57 UTC (permalink / raw)
To: Linus Walleij; +Cc: Paul Cercueil, Arnd Bergmann, linux-gpio, linux-kernel
The driver failts to build when CONFIG_OF is disabled:
drivers/pinctrl/pinctrl-ingenic.c:467:20: error: 'pinconf_generic_dt_node_to_map_all' undeclared here (not in a function); did you mean 'pinconf_generic_dump_config'?
drivers/pinctrl/pinctrl-ingenic.c:468:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
Fixes: b5c23aa46537 ("pinctrl: add a pinctrl driver for the Ingenic jz47xx SoCs")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index abc1cef7ad96..332bd303da36 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -313,6 +313,7 @@ config PINCTRL_INGENIC
bool "Pinctrl driver for the Ingenic JZ47xx SoCs"
default y
depends on MACH_INGENIC || COMPILE_TEST
+ depends on OF
select GENERIC_PINCONF
select GENERIC_PINCTRL_GROUPS
select GENERIC_PINMUX_FUNCTIONS
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency
2017-05-29 12:57 [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency Arnd Bergmann
2017-05-29 12:57 ` [PATCH 2/2] pinctrl: " Arnd Bergmann
@ 2017-05-29 16:45 ` Linus Walleij
2017-05-30 9:03 ` Geert Uytterhoeven
1 sibling, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2017-05-29 16:45 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Paul Cercueil, linux-gpio, linux-kernel
On Mon, May 29, 2017 at 2:57 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The driver cannot access the of_node field when CONFIG_OF is disabled:
>
> drivers/gpio/gpio-ingenic.c: In function 'ingenic_gpio_probe':
> drivers/gpio/gpio-ingenic.c:324:10: error: 'struct gpio_chip' has no member named 'of_node'
>
> Fixes: b0653ce39a0d ("gpio: Add gpio-ingenic driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I already sent a combined patch fixing these two deps earlier today,
good that we are several at it :)
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency
2017-05-29 16:45 ` [PATCH 1/2] gpio: " Linus Walleij
@ 2017-05-30 9:03 ` Geert Uytterhoeven
2017-05-30 9:57 ` Linus Walleij
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2017-05-30 9:03 UTC (permalink / raw)
To: Linus Walleij; +Cc: Arnd Bergmann, Paul Cercueil, linux-gpio, linux-kernel
On Mon, May 29, 2017 at 6:45 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, May 29, 2017 at 2:57 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
>> The driver cannot access the of_node field when CONFIG_OF is disabled:
>>
>> drivers/gpio/gpio-ingenic.c: In function 'ingenic_gpio_probe':
>> drivers/gpio/gpio-ingenic.c:324:10: error: 'struct gpio_chip' has no member named 'of_node'
>>
>> Fixes: b0653ce39a0d ("gpio: Add gpio-ingenic driver")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I already sent a combined patch fixing these two deps earlier today,
> good that we are several at it :)
Hmm... issues like these are actually the reasons why the of_node member
of struct device does not depend on CONFIG_OF?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency
2017-05-30 9:03 ` Geert Uytterhoeven
@ 2017-05-30 9:57 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2017-05-30 9:57 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Arnd Bergmann, Paul Cercueil, linux-gpio, linux-kernel
On Tue, May 30, 2017 at 11:03 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Mon, May 29, 2017 at 6:45 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Mon, May 29, 2017 at 2:57 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>
>>> The driver cannot access the of_node field when CONFIG_OF is disabled:
>>>
>>> drivers/gpio/gpio-ingenic.c: In function 'ingenic_gpio_probe':
>>> drivers/gpio/gpio-ingenic.c:324:10: error: 'struct gpio_chip' has no member named 'of_node'
>>>
>>> Fixes: b0653ce39a0d ("gpio: Add gpio-ingenic driver")
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> I already sent a combined patch fixing these two deps earlier today,
>> good that we are several at it :)
>
> Hmm... issues like these are actually the reasons why the of_node member
> of struct device does not depend on CONFIG_OF?
It's a bit of kludginess-vs-footprint thing I guess, you gain a pointer,
you loose a bit of Kconfig and #ifdefs.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-30 9:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-29 12:57 [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency Arnd Bergmann
2017-05-29 12:57 ` [PATCH 2/2] pinctrl: " Arnd Bergmann
2017-05-29 16:45 ` [PATCH 1/2] gpio: " Linus Walleij
2017-05-30 9:03 ` Geert Uytterhoeven
2017-05-30 9:57 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.