[PATCH] pinctrl/pinctrl-u300: remove unneeded devm_kfree call

[PATCH] pinctrl/pinctrl-u300: remove unneeded devm_kfree call

[Devendra Naga]

the allocated memory will be destroyed at the driver unload time,
automatically if driver uses the devm_ functions, so no need of
doing devm_kfree at the error path

Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
---
 drivers/pinctrl/pinctrl-u300.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-u300.c b/drivers/pinctrl/pinctrl-u300.c
index a7ad8c1..309f5b9 100644
--- a/drivers/pinctrl/pinctrl-u300.c
+++ b/drivers/pinctrl/pinctrl-u300.c
@@ -1121,10 +1121,8 @@ static int __devinit u300_pmx_probe(struct platform_device *pdev)
 	upmx->dev = &pdev->dev;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res) {
-		ret = -ENOENT;
-		goto out_no_resource;
-	}
+	if (!res)
+		return -ENOENT;
 	upmx->phybase = res->start;
 	upmx->physize = resource_size(res);
 
@@ -1165,8 +1163,6 @@ out_no_remap:
 	platform_set_drvdata(pdev, NULL);
 out_no_memregion:
 	release_mem_region(upmx->phybase, upmx->physize);
-out_no_resource:
-	devm_kfree(&pdev->dev, upmx);
 	return ret;
 }
 
-- 
1.7.9.5

Re: [PATCH] pinctrl/pinctrl-u300: remove unneeded devm_kfree call

[Linus Walleij]

On Sat, Jul 21, 2012 at 10:37 AM, Devendra Naga
<develkernel412222@gmail.com> wrote:

> the allocated memory will be destroyed at the driver unload time,
> automatically if driver uses the devm_ functions, so no need of
> doing devm_kfree at the error path
>
> Signed-off-by: Devendra Naga <develkernel412222@gmail.com>

Applied.

Thanks!
Linus Walleij