All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	Michael Walle <michael@walle.cc>,
	Florian Fainelli <f.fainelli@gmail.com>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	Jonas Gorski <jonas.gorski@gmail.com>,
	Necip Fazil Yildiran <fazilyildiran@gmail.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v9 00/22] pinctrl: add BCM63XX pincontrol support
Date: Thu, 8 Apr 2021 15:55:58 +0200	[thread overview]
Message-ID: <CACRpkdZubgHyBqPnZxOw7QXgf=AHMcb1E0Y7bj5v3v_Am+3Ttw@mail.gmail.com> (raw)
In-Reply-To: <609f038d-3037-5cda-b489-f0816eb95658@gmail.com>

On Tue, Mar 30, 2021 at 10:57 AM Álvaro Fernández Rojas
<noltari@gmail.com> wrote:

> > Now, what about a patch set for the IRQ support? :)
>
> If you could give me some guidance on that matter it would be much
> appreciated, because your comments [1] are now outdated since I switched
> to GPIO_REGMAP
> [1]
> http://patchwork.ozlabs.org/project/linux-gpio/patch/20210225164216.21124-3-noltari@gmail.com/

I think it mostly holds: GPIOLIB_IRQCHIP should always be used if there
is a reasonably straight-forward interrupts whether cascaded or hierarchical.
Very few exceptions there. If there is one IRQ line per GPIO
line, the hierarchical support should be used as outlined. GPIO_REGMAP
should be mostly (famous last words) orthogonal.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	 Lee Jones <lee.jones@linaro.org>,
	Michael Walle <michael@walle.cc>,
	 Florian Fainelli <f.fainelli@gmail.com>,
	 bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	 Jonas Gorski <jonas.gorski@gmail.com>,
	Necip Fazil Yildiran <fazilyildiran@gmail.com>,
	 Andy Shevchenko <andy.shevchenko@gmail.com>,
	 "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v9 00/22] pinctrl: add BCM63XX pincontrol support
Date: Thu, 8 Apr 2021 15:55:58 +0200	[thread overview]
Message-ID: <CACRpkdZubgHyBqPnZxOw7QXgf=AHMcb1E0Y7bj5v3v_Am+3Ttw@mail.gmail.com> (raw)
In-Reply-To: <609f038d-3037-5cda-b489-f0816eb95658@gmail.com>

On Tue, Mar 30, 2021 at 10:57 AM Álvaro Fernández Rojas
<noltari@gmail.com> wrote:

> > Now, what about a patch set for the IRQ support? :)
>
> If you could give me some guidance on that matter it would be much
> appreciated, because your comments [1] are now outdated since I switched
> to GPIO_REGMAP
> [1]
> http://patchwork.ozlabs.org/project/linux-gpio/patch/20210225164216.21124-3-noltari@gmail.com/

I think it mostly holds: GPIOLIB_IRQCHIP should always be used if there
is a reasonably straight-forward interrupts whether cascaded or hierarchical.
Very few exceptions there. If there is one IRQ line per GPIO
line, the hierarchical support should be used as outlined. GPIO_REGMAP
should be mostly (famous last words) orthogonal.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-08 13:56 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24  8:19 [PATCH v9 00/22] pinctrl: add BCM63XX pincontrol support Álvaro Fernández Rojas
2021-03-24  8:19 ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 01/22] gpio: guard gpiochip_irqchip_add_domain() with GPIOLIB_IRQCHIP Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-26 13:14   ` Bartosz Golaszewski
2021-03-26 13:14     ` Bartosz Golaszewski
2021-03-29 10:24     ` Linus Walleij
2021-03-29 10:24       ` Linus Walleij
2021-03-24  8:19 ` [PATCH v9 02/22] gpio: regmap: set gpio_chip of_node Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-26 13:14   ` Bartosz Golaszewski
2021-03-26 13:14     ` Bartosz Golaszewski
2021-03-24  8:19 ` [PATCH v9 03/22] dt-bindings: improve BCM6345 GPIO binding documentation Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-26 20:09   ` Rob Herring
2021-03-26 20:09     ` Rob Herring
2021-03-24  8:19 ` [PATCH v9 04/22] pinctrl: bcm: add bcm63xx base code Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 05/22] dt-bindings: add BCM6328 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 06/22] dt-bindings: add BCM6328 GPIO sysctl " Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 07/22] pinctrl: add a pincontrol driver for BCM6328 Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 08/22] dt-bindings: add BCM6358 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 09/22] dt-bindings: add BCM6358 GPIO sysctl " Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 10/22] pinctrl: add a pincontrol driver for BCM6358 Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 11/22] dt-bindings: add BCM6362 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 12/22] dt-bindings: add BCM6362 GPIO sysctl " Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 13/22] pinctrl: add a pincontrol driver for BCM6362 Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 14/22] dt-bindings: add BCM6368 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 15/22] dt-bindings: add BCM6368 GPIO sysctl " Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 16/22] pinctrl: add a pincontrol driver for BCM6368 Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 17/22] dt-bindings: add BCM63268 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-26 20:09   ` Rob Herring
2021-03-26 20:09     ` Rob Herring
2021-03-24  8:19 ` [PATCH v9 18/22] dt-bindings: add BCM63268 GPIO sysctl " Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 19/22] pinctrl: add a pincontrol driver for BCM63268 Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 20/22] dt-bindings: add BCM6318 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-26 20:10   ` Rob Herring
2021-03-26 20:10     ` Rob Herring
2021-03-24  8:19 ` [PATCH v9 21/22] dt-bindings: add BCM6318 GPIO sysctl " Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-24  8:19 ` [PATCH v9 22/22] pinctrl: add a pincontrol driver for BCM6318 Álvaro Fernández Rojas
2021-03-24  8:19   ` Álvaro Fernández Rojas
2021-03-29 10:19 ` [PATCH v9 00/22] pinctrl: add BCM63XX pincontrol support Linus Walleij
2021-03-29 10:19   ` Linus Walleij
2021-03-30  8:57   ` Álvaro Fernández Rojas
2021-03-30  8:57     ` Álvaro Fernández Rojas
2021-04-08 13:55     ` Linus Walleij [this message]
2021-04-08 13:55       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdZubgHyBqPnZxOw7QXgf=AHMcb1E0Y7bj5v3v_Am+3Ttw@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=fazilyildiran@gmail.com \
    --cc=jonas.gorski@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=noltari@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.