* [PATCH v1 1/1] pinctrl: core: Fix kernel doc string for pin_get_name()
@ 2021-04-15 12:35 Andy Shevchenko
2021-04-21 23:56 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2021-04-15 12:35 UTC (permalink / raw)
To: Andy Shevchenko, Linus Walleij, Drew Fustini, linux-gpio, linux-kernel
Cc: Dong Aisheng
The kernel doc string mistakenly advertises the pin_get_name_from_id().
Fix it, otherwise kernel doc validator is not happy:
.../core.c:168: warning: expecting prototype for pin_get_name_from_id(). Prototype was for pin_get_name() instead
Fixes: dcb5dbc305b9 ("pinctrl: show pin name for pingroups in sysfs")
Cc: Dong Aisheng <dong.aisheng@linaro.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 92955c5e0e0b..3d779fd81e7c 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -160,7 +160,7 @@ int pin_get_from_name(struct pinctrl_dev *pctldev, const char *name)
}
/**
- * pin_get_name_from_id() - look up a pin name from a pin id
+ * pin_get_name() - look up a pin name from a pin id
* @pctldev: the pin control device to lookup the pin on
* @pin: pin number/id to look up
*/
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: core: Fix kernel doc string for pin_get_name()
2021-04-15 12:35 [PATCH v1 1/1] pinctrl: core: Fix kernel doc string for pin_get_name() Andy Shevchenko
@ 2021-04-21 23:56 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2021-04-21 23:56 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Drew Fustini, open list:GPIO SUBSYSTEM, linux-kernel, Dong Aisheng
On Thu, Apr 15, 2021 at 2:35 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> The kernel doc string mistakenly advertises the pin_get_name_from_id().
> Fix it, otherwise kernel doc validator is not happy:
>
> .../core.c:168: warning: expecting prototype for pin_get_name_from_id(). Prototype was for pin_get_name() instead
>
> Fixes: dcb5dbc305b9 ("pinctrl: show pin name for pingroups in sysfs")
> Cc: Dong Aisheng <dong.aisheng@linaro.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied, thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-21 23:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-15 12:35 [PATCH v1 1/1] pinctrl: core: Fix kernel doc string for pin_get_name() Andy Shevchenko
2021-04-21 23:56 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.