* [PATCH RFT] gpio: exar: Set proper output level in exar_direction_output
@ 2017-02-26 14:36 Axel Lin
2017-03-14 13:56 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2017-02-26 14:36 UTC (permalink / raw)
To: Linus Walleij; +Cc: Sudip Mukherjee, Alexandre Courbot, linux-gpio, Axel Lin
Current code does not set output level in exar_direction_output, fix it.
Also move the direction_output/direction_input code block to avoid forward
declaration for exar_set_value().
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Sudip,
I don't have this h/w, so please review and test if this patch works.
thanks,
Axel
drivers/gpio/gpio-exar.c | 23 ++++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c
index 05c8946..0810767 100644
--- a/drivers/gpio/gpio-exar.c
+++ b/drivers/gpio/gpio-exar.c
@@ -59,17 +59,6 @@ static int exar_set_direction(struct gpio_chip *chip, int direction,
return 0;
}
-static int exar_direction_output(struct gpio_chip *chip, unsigned int offset,
- int value)
-{
- return exar_set_direction(chip, 0, offset);
-}
-
-static int exar_direction_input(struct gpio_chip *chip, unsigned int offset)
-{
- return exar_set_direction(chip, 1, offset);
-}
-
static int exar_get(struct gpio_chip *chip, unsigned int reg)
{
struct exar_gpio_chip *exar_gpio = gpiochip_get_data(chip);
@@ -116,6 +105,18 @@ static void exar_set_value(struct gpio_chip *chip, unsigned int offset,
exar_update(chip, addr, value, offset % 8);
}
+static int exar_direction_output(struct gpio_chip *chip, unsigned int offset,
+ int value)
+{
+ exar_set_value(chip, offset, value);
+ return exar_set_direction(chip, 0, offset);
+}
+
+static int exar_direction_input(struct gpio_chip *chip, unsigned int offset)
+{
+ return exar_set_direction(chip, 1, offset);
+}
+
static int gpio_exar_probe(struct platform_device *pdev)
{
struct pci_dev *pcidev = platform_get_drvdata(pdev);
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RFT] gpio: exar: Set proper output level in exar_direction_output
2017-02-26 14:36 [PATCH RFT] gpio: exar: Set proper output level in exar_direction_output Axel Lin
@ 2017-03-14 13:56 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2017-03-14 13:56 UTC (permalink / raw)
To: Axel Lin; +Cc: Sudip Mukherjee, Alexandre Courbot, linux-gpio
On Sun, Feb 26, 2017 at 3:36 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Current code does not set output level in exar_direction_output, fix it.
> Also move the direction_output/direction_input code block to avoid forward
> declaration for exar_set_value().
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi Sudip,
> I don't have this h/w, so please review and test if this patch works.
> thanks,
> Axel
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-14 13:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-26 14:36 [PATCH RFT] gpio: exar: Set proper output level in exar_direction_output Axel Lin
2017-03-14 13:56 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.