All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Stijn Devriendt <highguy@gmail.com>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Grant Likely <grant.likely@secretlab.ca>,
	Lee Jones <lee.jones@linaro.org>,
	Stephen Warren <swarren@nvidia.com>,
	Joe Perches <joe@perches.com>,
	Russell King <linux@arm.linux.org.uk>,
	Linaro Dev <linaro-dev@lists.linaro.org>
Subject: Re: [PATCH 1/4 v4] drivers: create a pin control subsystem
Date: Fri, 2 Sep 2011 09:57:28 +0200	[thread overview]
Message-ID: <CACRpkdZy0LokSNmzb-9FnAkc-61gp+_G07JuTxTEssqSUjtcVg@mail.gmail.com> (raw)
In-Reply-To: <CAOY=C6F7x+8UJv+0wChch4SAiRd+PRVgdCbZQ1_Db21uc-_9Bw@mail.gmail.com>

On Fri, Sep 2, 2011 at 9:02 AM, Stijn Devriendt <highguy@gmail.com> wrote:
> On Fri, Aug 19, 2011 at 11:53 AM, Linus Walleij
> <linus.walleij@stericsson.com> wrote:

>> +       if (desc->mux_requested) {
>> +               pr_err("pin already requested\n");
>> +               goto out;
>> +       }
>
> Isn't locking missing here?

You're right, I have now introduced a spinlock to the pin descriptor
and take that before reading or writing descriptor fields like this.

Thanks!
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4 v4] drivers: create a pin control subsystem
Date: Fri, 2 Sep 2011 09:57:28 +0200	[thread overview]
Message-ID: <CACRpkdZy0LokSNmzb-9FnAkc-61gp+_G07JuTxTEssqSUjtcVg@mail.gmail.com> (raw)
In-Reply-To: <CAOY=C6F7x+8UJv+0wChch4SAiRd+PRVgdCbZQ1_Db21uc-_9Bw@mail.gmail.com>

On Fri, Sep 2, 2011 at 9:02 AM, Stijn Devriendt <highguy@gmail.com> wrote:
> On Fri, Aug 19, 2011 at 11:53 AM, Linus Walleij
> <linus.walleij@stericsson.com> wrote:

>> + ? ? ? if (desc->mux_requested) {
>> + ? ? ? ? ? ? ? pr_err("pin already requested\n");
>> + ? ? ? ? ? ? ? goto out;
>> + ? ? ? }
>
> Isn't locking missing here?

You're right, I have now introduced a spinlock to the pin descriptor
and take that before reading or writing descriptor fields like this.

Thanks!
Linus Walleij

  reply	other threads:[~2011-09-02  7:57 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-19  9:53 [PATCH 1/4 v4] drivers: create a pin control subsystem Linus Walleij
2011-08-19  9:53 ` Linus Walleij
2011-08-19 10:48 ` Jamie Iles
2011-08-19 10:48   ` Jamie Iles
2011-08-19 14:04   ` Linus Walleij
2011-08-19 14:04     ` Linus Walleij
2011-08-19 14:26     ` Jamie Iles
2011-08-19 14:26       ` Jamie Iles
2011-08-21 14:24       ` Jamie Iles
2011-08-21 14:24         ` Jamie Iles
2011-08-22 12:38         ` Linus Walleij
2011-08-22 12:38           ` Linus Walleij
2011-08-22 12:54           ` Jamie Iles
2011-08-22 12:54             ` Jamie Iles
2011-08-19 14:36     ` Arnd Bergmann
2011-08-19 14:36       ` Arnd Bergmann
2011-08-19 16:52       ` Greg KH
2011-08-19 16:52         ` Greg KH
2011-08-22 12:29         ` Linus Walleij
2011-08-22 12:29           ` Linus Walleij
2011-08-21 14:53 ` Barry Song
2011-08-21 14:53   ` Barry Song
2011-08-24  6:24 ` Barry Song
2011-08-24  6:24   ` Barry Song
2011-08-24  7:41   ` Linus Walleij
2011-08-24  7:41     ` Linus Walleij
2011-08-24 18:29 ` Stephen Warren
2011-08-24 18:29   ` Stephen Warren
2011-08-25 10:12   ` Linus Walleij
2011-08-25 10:12     ` Linus Walleij
2011-08-25 11:04     ` Sascha Hauer
2011-08-25 11:04       ` Sascha Hauer
2011-08-25 11:58       ` Linus Walleij
2011-08-25 11:58         ` Linus Walleij
2011-08-25 12:07         ` Sascha Hauer
2011-08-25 12:07           ` Sascha Hauer
2011-08-25 15:12     ` David Brown
2011-08-25 15:12       ` David Brown
2011-08-25 18:14       ` Gregory Bean
2011-08-25 18:14         ` Gregory Bean
2011-08-25 19:13     ` Stephen Warren
2011-08-25 19:13       ` Stephen Warren
2011-08-26  8:35       ` Linus Walleij
2011-08-26  8:35         ` Linus Walleij
2011-08-26 17:33         ` Stephen Warren
2011-08-26 17:33           ` Stephen Warren
2011-08-29  8:40           ` Linus Walleij
2011-08-29  8:40             ` Linus Walleij
2011-08-26  3:12 ` Barry Song
2011-08-26  3:12   ` Barry Song
2011-08-26  8:36   ` Linus Walleij
2011-08-26  8:36     ` Linus Walleij
2011-09-02  7:02 ` Stijn Devriendt
2011-09-02  7:02   ` Stijn Devriendt
2011-09-02  7:57   ` Linus Walleij [this message]
2011-09-02  7:57     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZy0LokSNmzb-9FnAkc-61gp+_G07JuTxTEssqSUjtcVg@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=grant.likely@secretlab.ca \
    --cc=highguy@gmail.com \
    --cc=joe@perches.com \
    --cc=lee.jones@linaro.org \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.