* [PATCH] regulator: ab8500: Remove external regulator init() clauses
@ 2013-05-22 13:07 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2013-05-22 13:07 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: arnd, linus.walleij, srinidhi.kasagar, Lee Jones, Mark Brown
The driver no longer needs to worry about which platform can and can't
use external regulators successfully. Instead platform code will hold
back external regulator initialisation data in the use-cases where the
driver isn't applicable.
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/regulator/ab8500.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
index f6656b8..b6270f5 100644
--- a/drivers/regulator/ab8500.c
+++ b/drivers/regulator/ab8500.c
@@ -3156,12 +3156,10 @@ static int ab8500_regulator_probe(struct platform_device *pdev)
return err;
}
- if (!is_ab8505(ab8500)) {
- /* register external regulators (before Vaux1, 2 and 3) */
- err = ab8500_ext_regulator_init(pdev);
- if (err)
- return err;
- }
+ /* register external regulators (before Vaux1, 2 and 3) */
+ err = ab8500_ext_regulator_init(pdev);
+ if (err)
+ return err;
/* register all regulators */
for (i = 0; i < abx500_regulator.info_size; i++) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] regulator: ab8500: Remove external regulator init() clauses
@ 2013-05-22 13:07 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2013-05-22 13:07 UTC (permalink / raw)
To: linux-arm-kernel
The driver no longer needs to worry about which platform can and can't
use external regulators successfully. Instead platform code will hold
back external regulator initialisation data in the use-cases where the
driver isn't applicable.
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/regulator/ab8500.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
index f6656b8..b6270f5 100644
--- a/drivers/regulator/ab8500.c
+++ b/drivers/regulator/ab8500.c
@@ -3156,12 +3156,10 @@ static int ab8500_regulator_probe(struct platform_device *pdev)
return err;
}
- if (!is_ab8505(ab8500)) {
- /* register external regulators (before Vaux1, 2 and 3) */
- err = ab8500_ext_regulator_init(pdev);
- if (err)
- return err;
- }
+ /* register external regulators (before Vaux1, 2 and 3) */
+ err = ab8500_ext_regulator_init(pdev);
+ if (err)
+ return err;
/* register all regulators */
for (i = 0; i < abx500_regulator.info_size; i++) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: ab8500: Remove external regulator init() clauses
2013-05-22 13:07 ` Lee Jones
@ 2013-05-22 13:20 ` Linus Walleij
-1 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-05-22 13:20 UTC (permalink / raw)
To: Lee Jones
Cc: linux-arm-kernel, linux-kernel, Arnd Bergmann, Linus WALLEIJ,
Srinidhi KASAGAR, Mark Brown
On Wed, May 22, 2013 at 3:07 PM, Lee Jones <lee.jones@linaro.org> wrote:
> The driver no longer needs to worry about which platform can and can't
> use external regulators successfully. Instead platform code will hold
> back external regulator initialisation data in the use-cases where the
> driver isn't applicable.
>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] regulator: ab8500: Remove external regulator init() clauses
@ 2013-05-22 13:20 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-05-22 13:20 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 22, 2013 at 3:07 PM, Lee Jones <lee.jones@linaro.org> wrote:
> The driver no longer needs to worry about which platform can and can't
> use external regulators successfully. Instead platform code will hold
> back external regulator initialisation data in the use-cases where the
> driver isn't applicable.
>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-22 13:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-22 13:07 [PATCH] regulator: ab8500: Remove external regulator init() clauses Lee Jones
2013-05-22 13:07 ` Lee Jones
2013-05-22 13:20 ` Linus Walleij
2013-05-22 13:20 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.