[PATCH] mmc: Export host capabilities to debugfs.

[PATCH] mmc: Export host capabilities to debugfs.

[Harish Jenny K N]

This patch exports the host capabilities to debugfs

Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
---
 drivers/mmc/core/debugfs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
index c51e0c0..fa2df7f 100644
--- a/drivers/mmc/core/debugfs.c
+++ b/drivers/mmc/core/debugfs.c
@@ -289,6 +289,9 @@ void mmc_add_card_debugfs(struct mmc_card *card)
 
 	card->debugfs_root = root;
 
+	if (!debugfs_create_x32("host_caps", S_IRUSR, root, (u32 *)&host->caps))
+		goto err;
+
 	if (!debugfs_create_x32("state", S_IRUSR, root, &card->state))
 		goto err;
 
-- 
1.9.1

[PATCH] mmc: Export host capabilities to debugfs.

[Harish Jenny K N]

This patch exports the host capabilities to debugfs

Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
---
 drivers/mmc/core/debugfs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
index c51e0c0..fa2df7f 100644
--- a/drivers/mmc/core/debugfs.c
+++ b/drivers/mmc/core/debugfs.c
@@ -289,6 +289,9 @@ void mmc_add_card_debugfs(struct mmc_card *card)
 
 	card->debugfs_root = root;
 
+	if (!debugfs_create_x32("host_caps", S_IRUSR, root, (u32 *)&host->caps))
+		goto err;
+
 	if (!debugfs_create_x32("state", S_IRUSR, root, &card->state))
 		goto err;
 
-- 
1.9.1

Re: [PATCH] mmc: Export host capabilities to debugfs.

[Linus Walleij]

On Thu, Mar 1, 2018 at 2:17 PM, Harish Jenny K N
<harish_kandiga@mentor.com> wrote:

Thanks for your patch!

> This patch exports the host capabilities to debugfs
>
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>

Is there a corresponding patch to the mmc utils to make use
of the exported information? An opaque u32 seems pretty hard
to interpret.

Yours,
Linus Walleij

Re: [PATCH] mmc: Export host capabilities to debugfs.

[Harish Jenny K N]

On Thursday 01 March 2018 07:54 PM, Linus Walleij wrote:
> On Thu, Mar 1, 2018 at 2:17 PM, Harish Jenny K N
> <harish_kandiga@mentor.com> wrote:
>
> Thanks for your patch!
>
>> This patch exports the host capabilities to debugfs
>>
>> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
>> Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
> Is there a corresponding patch to the mmc utils to make use
> of the exported information? An opaque u32 seems pretty hard
> to interpret.
>
> Yours,
> Linus Walleij
A sample patch "[RFC PATCH] mmc-utils: host_caps: Add parser to read host capabilities" is submitted.

Thanks,
Harish Jenny K N

Re: [PATCH] mmc: Export host capabilities to debugfs.

[Linus Walleij]

On Fri, Mar 2, 2018 at 2:17 PM, Harish Jenny K N
<harish_kandiga@mentor.com> wrote:
> On Thursday 01 March 2018 07:54 PM, Linus Walleij wrote:
>> On Thu, Mar 1, 2018 at 2:17 PM, Harish Jenny K N
>> <harish_kandiga@mentor.com> wrote:
>>
>> Thanks for your patch!
>>
>>> This patch exports the host capabilities to debugfs
>>>
>>> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
>>> Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
>> Is there a corresponding patch to the mmc utils to make use
>> of the exported information? An opaque u32 seems pretty hard
>> to interpret.
>>
>> Yours,
>> Linus Walleij
>
> A sample patch "[RFC PATCH] mmc-utils: host_caps: Add parser to read host capabilities" is submitted.

Nice! :)

Good work.

Yours,
Linus Walleij

Re: [PATCH] mmc: Export host capabilities to debugfs.

[Vladimir Zapolskiy]

Hi Harish,

On 03/01/2018 03:17 PM, Harish Jenny K N wrote:
> This patch exports the host capabilities to debugfs
> 
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
> ---

would you mind to restore the authorship to Abbas Raza and send v2?

Thank you in advance.

--
With best wishes,
Vladimir

Re: [PATCH] mmc: Export host capabilities to debugfs.

[Vladimir Zapolskiy]

Hi Harish,

On 03/01/2018 03:17 PM, Harish Jenny K N wrote:
> This patch exports the host capabilities to debugfs
> 
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
> ---

would you mind to restore the authorship to Abbas Raza and send v2?

Thank you in advance.

--
With best wishes,
Vladimir

Re: [PATCH] mmc: Export host capabilities to debugfs.

[Harish Jenny K N]

On Saturday 03 March 2018 10:02 PM, Vladimir Zapolskiy wrote:
> Hi Harish,
>
> On 03/01/2018 03:17 PM, Harish Jenny K N wrote:
>> This patch exports the host capabilities to debugfs
>>
>> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
>> Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
>> ---
> would you mind to restore the authorship to Abbas Raza and send v2?
Sure. Abbas had left Mentor and this was being done as part of new project.
Still, I will resend the patch by changing the Author.

Thanks,
Harish

Re: [PATCH] mmc: Export host capabilities to debugfs.

[Harish Jenny K N]

On Saturday 03 March 2018 10:02 PM, Vladimir Zapolskiy wrote:
> Hi Harish,
>
> On 03/01/2018 03:17 PM, Harish Jenny K N wrote:
>> This patch exports the host capabilities to debugfs
>>
>> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
>> Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
>> ---
> would you mind to restore the authorship to Abbas Raza and send v2?
Sure. Abbas had left Mentor and this was being done as part of new project.
Still, I will resend the patch by changing the Author.

Thanks,
Harish

[PATCH] mmc: Export host capabilities to debugfs.

[Harish Jenny K N]

From: Abbas Raza <Abbas_Raza@mentor.com>

This patch exports the host capabilities to debugfs

Signed-off-by: Abbas Raza <Abbas_Raza@mentor.com>
Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
[Harish: Added caps2, moved creation to mmc_add_host_debugfs]
Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
---

Changes in v4:
- Moved the creation of nodes to mmc_add_host_debugfs
- Exported caps2
- Renamed host_caps to caps

Changes in v3:
- Removed typecasting of &host->caps to (u32 *)

Changes in v2:
- Changed Author

 drivers/mmc/core/debugfs.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
index c51e0c0..d2275c5 100644
--- a/drivers/mmc/core/debugfs.c
+++ b/drivers/mmc/core/debugfs.c
@@ -243,6 +243,12 @@ void mmc_add_host_debugfs(struct mmc_host *host)
 	if (!debugfs_create_file("ios", S_IRUSR, root, host, &mmc_ios_fops))
 		goto err_node;

+	if (!debugfs_create_x32("caps", S_IRUSR, root, &host->caps))
+		goto err_node;
+
+	if (!debugfs_create_x32("caps2", S_IRUSR, root, &host->caps2))
+		goto err_node;
+
 	if (!debugfs_create_file("clock", S_IRUSR | S_IWUSR, root, host,
 			&mmc_clock_fops))
 		goto err_node;
--
1.9.1

[PATCH] mmc: Export host capabilities to debugfs.

[Harish Jenny K N]

From: Abbas Raza <Abbas_Raza@mentor.com>

This patch exports the host capabilities to debugfs

Signed-off-by: Abbas Raza <Abbas_Raza@mentor.com>
Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
[Harish: Added caps2, moved creation to mmc_add_host_debugfs]
Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
---

Changes in v4:
- Moved the creation of nodes to mmc_add_host_debugfs
- Exported caps2
- Renamed host_caps to caps

Changes in v3:
- Removed typecasting of &host->caps to (u32 *)

Changes in v2:
- Changed Author

 drivers/mmc/core/debugfs.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
index c51e0c0..d2275c5 100644
--- a/drivers/mmc/core/debugfs.c
+++ b/drivers/mmc/core/debugfs.c
@@ -243,6 +243,12 @@ void mmc_add_host_debugfs(struct mmc_host *host)
 	if (!debugfs_create_file("ios", S_IRUSR, root, host, &mmc_ios_fops))
 		goto err_node;

+	if (!debugfs_create_x32("caps", S_IRUSR, root, &host->caps))
+		goto err_node;
+
+	if (!debugfs_create_x32("caps2", S_IRUSR, root, &host->caps2))
+		goto err_node;
+
 	if (!debugfs_create_file("clock", S_IRUSR | S_IWUSR, root, host,
 			&mmc_clock_fops))
 		goto err_node;
--
1.9.1