All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm: sunxi: fix f1c100s pinctrl function.
@ 2022-05-04 11:59 ` IotaHydrae
  0 siblings, 0 replies; 6+ messages in thread
From: IotaHydrae @ 2022-05-04 11:59 UTC (permalink / raw)
  To: Linus Walleij, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
	linux-gpio, linux-arm-kernel, linux-sunxi, linux-kernel
  Cc: IotaHydrae

1. change suniv f1c100s pinctrl,PD14 multiplexing function lvds1 to uart2

When the pin PD13 and PD14 is setting up to uart2 function in dts,
there's an error occurred:
1c20800.pinctrl: unsupported function uart2 on pin PD14

Because 'uart2' is not any one multiplexing option of PD14,
and pinctrl don't know how to configure it.

So change the pin PD14 lvds1 function to uart2.

Signed-off-by: IotaHydrae <writeforever@foxmail.com>
---
 drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c b/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
index 2801ca706273..68a5b627fb9b 100644
--- a/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
+++ b/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
@@ -204,7 +204,7 @@ static const struct sunxi_desc_pin suniv_f1c100s_pins[] = {
 		  SUNXI_FUNCTION(0x0, "gpio_in"),
 		  SUNXI_FUNCTION(0x1, "gpio_out"),
 		  SUNXI_FUNCTION(0x2, "lcd"),		/* D20 */
-		  SUNXI_FUNCTION(0x3, "lvds1"),		/* RX */
+		  SUNXI_FUNCTION(0x3, "uart2"),		/* RX */
 		  SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 14)),
 	SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 15),
 		  SUNXI_FUNCTION(0x0, "gpio_in"),
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] arm: sunxi: fix f1c100s pinctrl function.
@ 2022-05-04 11:59 ` IotaHydrae
  0 siblings, 0 replies; 6+ messages in thread
From: IotaHydrae @ 2022-05-04 11:59 UTC (permalink / raw)
  To: Linus Walleij, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
	linux-gpio, linux-arm-kernel, linux-sunxi, linux-kernel
  Cc: IotaHydrae

1. change suniv f1c100s pinctrl,PD14 multiplexing function lvds1 to uart2

When the pin PD13 and PD14 is setting up to uart2 function in dts,
there's an error occurred:
1c20800.pinctrl: unsupported function uart2 on pin PD14

Because 'uart2' is not any one multiplexing option of PD14,
and pinctrl don't know how to configure it.

So change the pin PD14 lvds1 function to uart2.

Signed-off-by: IotaHydrae <writeforever@foxmail.com>
---
 drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c b/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
index 2801ca706273..68a5b627fb9b 100644
--- a/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
+++ b/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
@@ -204,7 +204,7 @@ static const struct sunxi_desc_pin suniv_f1c100s_pins[] = {
 		  SUNXI_FUNCTION(0x0, "gpio_in"),
 		  SUNXI_FUNCTION(0x1, "gpio_out"),
 		  SUNXI_FUNCTION(0x2, "lcd"),		/* D20 */
-		  SUNXI_FUNCTION(0x3, "lvds1"),		/* RX */
+		  SUNXI_FUNCTION(0x3, "uart2"),		/* RX */
 		  SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 14)),
 	SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 15),
 		  SUNXI_FUNCTION(0x0, "gpio_in"),
-- 
2.32.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm: sunxi: fix f1c100s pinctrl function.
  2022-05-04 11:59 ` IotaHydrae
@ 2022-05-04 12:55   ` Andre Przywara
  -1 siblings, 0 replies; 6+ messages in thread
From: Andre Przywara @ 2022-05-04 12:55 UTC (permalink / raw)
  To: IotaHydrae
  Cc: Linus Walleij, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
	linux-gpio, linux-arm-kernel, linux-sunxi, linux-kernel

On Wed,  4 May 2022 19:59:04 +0800
IotaHydrae <writeforever@foxmail.com> wrote:

Hi,

thanks for the patch!

I think the subject should start with: "pinctrl: sunxi:", also please
mention the UART in there.

> 1. change suniv f1c100s pinctrl,PD14 multiplexing function lvds1 to uart2
> 
> When the pin PD13 and PD14 is setting up to uart2 function in dts,
> there's an error occurred:
> 1c20800.pinctrl: unsupported function uart2 on pin PD14
> 
> Because 'uart2' is not any one multiplexing option of PD14,
> and pinctrl don't know how to configure it.
> 
> So change the pin PD14 lvds1 function to uart2.
> 
> Signed-off-by: IotaHydrae <writeforever@foxmail.com>

Compared against the manual, looks correct:

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

P.S. I used to opportunity to check all other functions as well, apart
from one error in the comments they were correct. Will send a patch.

> ---
>  drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c b/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
> index 2801ca706273..68a5b627fb9b 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
> @@ -204,7 +204,7 @@ static const struct sunxi_desc_pin suniv_f1c100s_pins[] = {
>  		  SUNXI_FUNCTION(0x0, "gpio_in"),
>  		  SUNXI_FUNCTION(0x1, "gpio_out"),
>  		  SUNXI_FUNCTION(0x2, "lcd"),		/* D20 */
> -		  SUNXI_FUNCTION(0x3, "lvds1"),		/* RX */
> +		  SUNXI_FUNCTION(0x3, "uart2"),		/* RX */
>  		  SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 14)),
>  	SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 15),
>  		  SUNXI_FUNCTION(0x0, "gpio_in"),


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm: sunxi: fix f1c100s pinctrl function.
@ 2022-05-04 12:55   ` Andre Przywara
  0 siblings, 0 replies; 6+ messages in thread
From: Andre Przywara @ 2022-05-04 12:55 UTC (permalink / raw)
  To: IotaHydrae
  Cc: Linus Walleij, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
	linux-gpio, linux-arm-kernel, linux-sunxi, linux-kernel

On Wed,  4 May 2022 19:59:04 +0800
IotaHydrae <writeforever@foxmail.com> wrote:

Hi,

thanks for the patch!

I think the subject should start with: "pinctrl: sunxi:", also please
mention the UART in there.

> 1. change suniv f1c100s pinctrl,PD14 multiplexing function lvds1 to uart2
> 
> When the pin PD13 and PD14 is setting up to uart2 function in dts,
> there's an error occurred:
> 1c20800.pinctrl: unsupported function uart2 on pin PD14
> 
> Because 'uart2' is not any one multiplexing option of PD14,
> and pinctrl don't know how to configure it.
> 
> So change the pin PD14 lvds1 function to uart2.
> 
> Signed-off-by: IotaHydrae <writeforever@foxmail.com>

Compared against the manual, looks correct:

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

P.S. I used to opportunity to check all other functions as well, apart
from one error in the comments they were correct. Will send a patch.

> ---
>  drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c b/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
> index 2801ca706273..68a5b627fb9b 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
> @@ -204,7 +204,7 @@ static const struct sunxi_desc_pin suniv_f1c100s_pins[] = {
>  		  SUNXI_FUNCTION(0x0, "gpio_in"),
>  		  SUNXI_FUNCTION(0x1, "gpio_out"),
>  		  SUNXI_FUNCTION(0x2, "lcd"),		/* D20 */
> -		  SUNXI_FUNCTION(0x3, "lvds1"),		/* RX */
> +		  SUNXI_FUNCTION(0x3, "uart2"),		/* RX */
>  		  SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 14)),
>  	SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 15),
>  		  SUNXI_FUNCTION(0x0, "gpio_in"),


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm: sunxi: fix f1c100s pinctrl function.
  2022-05-04 11:59 ` IotaHydrae
@ 2022-05-13 23:05   ` Linus Walleij
  -1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2022-05-13 23:05 UTC (permalink / raw)
  To: IotaHydrae
  Cc: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-gpio,
	linux-arm-kernel, linux-sunxi, linux-kernel

On Wed, May 4, 2022 at 1:59 PM IotaHydrae <writeforever@foxmail.com> wrote:

> 1. change suniv f1c100s pinctrl,PD14 multiplexing function lvds1 to uart2
>
> When the pin PD13 and PD14 is setting up to uart2 function in dts,
> there's an error occurred:
> 1c20800.pinctrl: unsupported function uart2 on pin PD14
>
> Because 'uart2' is not any one multiplexing option of PD14,
> and pinctrl don't know how to configure it.
>
> So change the pin PD14 lvds1 function to uart2.
>
> Signed-off-by: IotaHydrae <writeforever@foxmail.com>

Thanks, fixed up the subject as indicated by Andre
and applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm: sunxi: fix f1c100s pinctrl function.
@ 2022-05-13 23:05   ` Linus Walleij
  0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2022-05-13 23:05 UTC (permalink / raw)
  To: IotaHydrae
  Cc: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-gpio,
	linux-arm-kernel, linux-sunxi, linux-kernel

On Wed, May 4, 2022 at 1:59 PM IotaHydrae <writeforever@foxmail.com> wrote:

> 1. change suniv f1c100s pinctrl,PD14 multiplexing function lvds1 to uart2
>
> When the pin PD13 and PD14 is setting up to uart2 function in dts,
> there's an error occurred:
> 1c20800.pinctrl: unsupported function uart2 on pin PD14
>
> Because 'uart2' is not any one multiplexing option of PD14,
> and pinctrl don't know how to configure it.
>
> So change the pin PD14 lvds1 function to uart2.
>
> Signed-off-by: IotaHydrae <writeforever@foxmail.com>

Thanks, fixed up the subject as indicated by Andre
and applied.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-13 23:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-04 11:59 [PATCH] arm: sunxi: fix f1c100s pinctrl function IotaHydrae
2022-05-04 11:59 ` IotaHydrae
2022-05-04 12:55 ` Andre Przywara
2022-05-04 12:55   ` Andre Przywara
2022-05-13 23:05 ` Linus Walleij
2022-05-13 23:05   ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.