* [PATCH][V2] pinctrl: actions: fix unsigned less than zero comparison
@ 2018-07-02 12:47 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2018-07-02 12:47 UTC (permalink / raw)
To: Andreas Färber, Manivannan Sadhasivam, Linus Walleij,
linux-arm-kernel, linux-gpio
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The check to see if platform_get_irq failed is performed on the
unsigned value of pctrl->irq[i] and the check is never true because
an unsigned cannot be less than zero. Fix this by assinging the
signed int ret to the return of platform_get_irq and checking ret
instead.
Detected by CoverityScan, CID#1470247 ("Unsigned comparison against 0")
Fixes: 6c5d0736e9c0 ("pinctrl: actions: Add interrupt support for OWL S900 SoC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
V2: move pctrl->irq[i] = ret assignment below the check on ret, thanks
to Manivannan Sadhasivam for suggesting this change.
---
drivers/pinctrl/actions/pinctrl-owl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c
index 4fa9cc377b3b..24dc57fcac51 100644
--- a/drivers/pinctrl/actions/pinctrl-owl.c
+++ b/drivers/pinctrl/actions/pinctrl-owl.c
@@ -1026,11 +1026,10 @@ int owl_pinctrl_probe(struct platform_device *pdev,
}
for (i = 0; i < pctrl->num_irq ; i++) {
- pctrl->irq[i] = platform_get_irq(pdev, i);
- if (pctrl->irq[i] < 0) {
- ret = pctrl->irq[i];
+ ret = platform_get_irq(pdev, i);
+ if (ret < 0)
goto err_exit;
- }
+ pctrl->irq[i] = ret;
}
ret = owl_gpio_init(pctrl);
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH][V2] pinctrl: actions: fix unsigned less than zero comparison
@ 2018-07-02 12:47 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2018-07-02 12:47 UTC (permalink / raw)
To: linux-arm-kernel
From: Colin Ian King <colin.king@canonical.com>
The check to see if platform_get_irq failed is performed on the
unsigned value of pctrl->irq[i] and the check is never true because
an unsigned cannot be less than zero. Fix this by assinging the
signed int ret to the return of platform_get_irq and checking ret
instead.
Detected by CoverityScan, CID#1470247 ("Unsigned comparison against 0")
Fixes: 6c5d0736e9c0 ("pinctrl: actions: Add interrupt support for OWL S900 SoC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
V2: move pctrl->irq[i] = ret assignment below the check on ret, thanks
to Manivannan Sadhasivam for suggesting this change.
---
drivers/pinctrl/actions/pinctrl-owl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c
index 4fa9cc377b3b..24dc57fcac51 100644
--- a/drivers/pinctrl/actions/pinctrl-owl.c
+++ b/drivers/pinctrl/actions/pinctrl-owl.c
@@ -1026,11 +1026,10 @@ int owl_pinctrl_probe(struct platform_device *pdev,
}
for (i = 0; i < pctrl->num_irq ; i++) {
- pctrl->irq[i] = platform_get_irq(pdev, i);
- if (pctrl->irq[i] < 0) {
- ret = pctrl->irq[i];
+ ret = platform_get_irq(pdev, i);
+ if (ret < 0)
goto err_exit;
- }
+ pctrl->irq[i] = ret;
}
ret = owl_gpio_init(pctrl);
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH][V2] pinctrl: actions: fix unsigned less than zero comparison
@ 2018-07-02 12:47 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2018-07-02 12:47 UTC (permalink / raw)
To: linux-arm-kernel
From: Colin Ian King <colin.king@canonical.com>
The check to see if platform_get_irq failed is performed on the
unsigned value of pctrl->irq[i] and the check is never true because
an unsigned cannot be less than zero. Fix this by assinging the
signed int ret to the return of platform_get_irq and checking ret
instead.
Detected by CoverityScan, CID#1470247 ("Unsigned comparison against 0")
Fixes: 6c5d0736e9c0 ("pinctrl: actions: Add interrupt support for OWL S900 SoC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
V2: move pctrl->irq[i] = ret assignment below the check on ret, thanks
to Manivannan Sadhasivam for suggesting this change.
---
drivers/pinctrl/actions/pinctrl-owl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c
index 4fa9cc377b3b..24dc57fcac51 100644
--- a/drivers/pinctrl/actions/pinctrl-owl.c
+++ b/drivers/pinctrl/actions/pinctrl-owl.c
@@ -1026,11 +1026,10 @@ int owl_pinctrl_probe(struct platform_device *pdev,
}
for (i = 0; i < pctrl->num_irq ; i++) {
- pctrl->irq[i] = platform_get_irq(pdev, i);
- if (pctrl->irq[i] < 0) {
- ret = pctrl->irq[i];
+ ret = platform_get_irq(pdev, i);
+ if (ret < 0)
goto err_exit;
- }
+ pctrl->irq[i] = ret;
}
ret = owl_gpio_init(pctrl);
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH][V2] pinctrl: actions: fix unsigned less than zero comparison
2018-07-02 12:47 ` Colin King
(?)
@ 2018-07-02 13:02 ` Manivannan Sadhasivam
-1 siblings, 0 replies; 9+ messages in thread
From: Manivannan Sadhasivam @ 2018-07-02 13:02 UTC (permalink / raw)
To: Colin King
Cc: Andreas Färber, Linus Walleij, linux-arm-kernel, linux-gpio,
kernel-janitors, linux-kernel
On Mon, Jul 02, 2018 at 01:47:08PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check to see if platform_get_irq failed is performed on the
> unsigned value of pctrl->irq[i] and the check is never true because
> an unsigned cannot be less than zero. Fix this by assinging the
> signed int ret to the return of platform_get_irq and checking ret
> instead.
>
> Detected by CoverityScan, CID#1470247 ("Unsigned comparison against 0")
>
> Fixes: 6c5d0736e9c0 ("pinctrl: actions: Add interrupt support for OWL S900 SoC")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks!
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Regards,
Mani
> ---
>
> V2: move pctrl->irq[i] = ret assignment below the check on ret, thanks
> to Manivannan Sadhasivam for suggesting this change.
>
> ---
> drivers/pinctrl/actions/pinctrl-owl.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c
> index 4fa9cc377b3b..24dc57fcac51 100644
> --- a/drivers/pinctrl/actions/pinctrl-owl.c
> +++ b/drivers/pinctrl/actions/pinctrl-owl.c
> @@ -1026,11 +1026,10 @@ int owl_pinctrl_probe(struct platform_device *pdev,
> }
>
> for (i = 0; i < pctrl->num_irq ; i++) {
> - pctrl->irq[i] = platform_get_irq(pdev, i);
> - if (pctrl->irq[i] < 0) {
> - ret = pctrl->irq[i];
> + ret = platform_get_irq(pdev, i);
> + if (ret < 0)
> goto err_exit;
> - }
> + pctrl->irq[i] = ret;
> }
>
> ret = owl_gpio_init(pctrl);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH][V2] pinctrl: actions: fix unsigned less than zero comparison
@ 2018-07-02 13:02 ` Manivannan Sadhasivam
0 siblings, 0 replies; 9+ messages in thread
From: Manivannan Sadhasivam @ 2018-07-02 13:02 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 02, 2018 at 01:47:08PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check to see if platform_get_irq failed is performed on the
> unsigned value of pctrl->irq[i] and the check is never true because
> an unsigned cannot be less than zero. Fix this by assinging the
> signed int ret to the return of platform_get_irq and checking ret
> instead.
>
> Detected by CoverityScan, CID#1470247 ("Unsigned comparison against 0")
>
> Fixes: 6c5d0736e9c0 ("pinctrl: actions: Add interrupt support for OWL S900 SoC")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks!
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Regards,
Mani
> ---
>
> V2: move pctrl->irq[i] = ret assignment below the check on ret, thanks
> to Manivannan Sadhasivam for suggesting this change.
>
> ---
> drivers/pinctrl/actions/pinctrl-owl.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c
> index 4fa9cc377b3b..24dc57fcac51 100644
> --- a/drivers/pinctrl/actions/pinctrl-owl.c
> +++ b/drivers/pinctrl/actions/pinctrl-owl.c
> @@ -1026,11 +1026,10 @@ int owl_pinctrl_probe(struct platform_device *pdev,
> }
>
> for (i = 0; i < pctrl->num_irq ; i++) {
> - pctrl->irq[i] = platform_get_irq(pdev, i);
> - if (pctrl->irq[i] < 0) {
> - ret = pctrl->irq[i];
> + ret = platform_get_irq(pdev, i);
> + if (ret < 0)
> goto err_exit;
> - }
> + pctrl->irq[i] = ret;
> }
>
> ret = owl_gpio_init(pctrl);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][V2] pinctrl: actions: fix unsigned less than zero comparison
@ 2018-07-02 13:02 ` Manivannan Sadhasivam
0 siblings, 0 replies; 9+ messages in thread
From: Manivannan Sadhasivam @ 2018-07-02 13:14 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 02, 2018 at 01:47:08PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check to see if platform_get_irq failed is performed on the
> unsigned value of pctrl->irq[i] and the check is never true because
> an unsigned cannot be less than zero. Fix this by assinging the
> signed int ret to the return of platform_get_irq and checking ret
> instead.
>
> Detected by CoverityScan, CID#1470247 ("Unsigned comparison against 0")
>
> Fixes: 6c5d0736e9c0 ("pinctrl: actions: Add interrupt support for OWL S900 SoC")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks!
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Regards,
Mani
> ---
>
> V2: move pctrl->irq[i] = ret assignment below the check on ret, thanks
> to Manivannan Sadhasivam for suggesting this change.
>
> ---
> drivers/pinctrl/actions/pinctrl-owl.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c
> index 4fa9cc377b3b..24dc57fcac51 100644
> --- a/drivers/pinctrl/actions/pinctrl-owl.c
> +++ b/drivers/pinctrl/actions/pinctrl-owl.c
> @@ -1026,11 +1026,10 @@ int owl_pinctrl_probe(struct platform_device *pdev,
> }
>
> for (i = 0; i < pctrl->num_irq ; i++) {
> - pctrl->irq[i] = platform_get_irq(pdev, i);
> - if (pctrl->irq[i] < 0) {
> - ret = pctrl->irq[i];
> + ret = platform_get_irq(pdev, i);
> + if (ret < 0)
> goto err_exit;
> - }
> + pctrl->irq[i] = ret;
> }
>
> ret = owl_gpio_init(pctrl);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][V2] pinctrl: actions: fix unsigned less than zero comparison
2018-07-02 12:47 ` Colin King
(?)
@ 2018-07-02 14:06 ` Linus Walleij
-1 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2018-07-02 14:06 UTC (permalink / raw)
To: Colin King
Cc: Andreas Färber, Manivannan Sadhasivam, Linux ARM,
open list:GPIO SUBSYSTEM, kernel-janitors, linux-kernel
On Mon, Jul 2, 2018 at 2:47 PM Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check to see if platform_get_irq failed is performed on the
> unsigned value of pctrl->irq[i] and the check is never true because
> an unsigned cannot be less than zero. Fix this by assinging the
> signed int ret to the return of platform_get_irq and checking ret
> instead.
>
> Detected by CoverityScan, CID#1470247 ("Unsigned comparison against 0")
>
> Fixes: 6c5d0736e9c0 ("pinctrl: actions: Add interrupt support for OWL S900 SoC")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>
> V2: move pctrl->irq[i] = ret assignment below the check on ret, thanks
> to Manivannan Sadhasivam for suggesting this change.
Patch applied with Manivannan's ACK!
(Hope it's the right version now.)
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][V2] pinctrl: actions: fix unsigned less than zero comparison
@ 2018-07-02 14:06 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2018-07-02 14:06 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 2, 2018 at 2:47 PM Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check to see if platform_get_irq failed is performed on the
> unsigned value of pctrl->irq[i] and the check is never true because
> an unsigned cannot be less than zero. Fix this by assinging the
> signed int ret to the return of platform_get_irq and checking ret
> instead.
>
> Detected by CoverityScan, CID#1470247 ("Unsigned comparison against 0")
>
> Fixes: 6c5d0736e9c0 ("pinctrl: actions: Add interrupt support for OWL S900 SoC")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>
> V2: move pctrl->irq[i] = ret assignment below the check on ret, thanks
> to Manivannan Sadhasivam for suggesting this change.
Patch applied with Manivannan's ACK!
(Hope it's the right version now.)
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH][V2] pinctrl: actions: fix unsigned less than zero comparison
@ 2018-07-02 14:06 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2018-07-02 14:06 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 2, 2018 at 2:47 PM Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check to see if platform_get_irq failed is performed on the
> unsigned value of pctrl->irq[i] and the check is never true because
> an unsigned cannot be less than zero. Fix this by assinging the
> signed int ret to the return of platform_get_irq and checking ret
> instead.
>
> Detected by CoverityScan, CID#1470247 ("Unsigned comparison against 0")
>
> Fixes: 6c5d0736e9c0 ("pinctrl: actions: Add interrupt support for OWL S900 SoC")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>
> V2: move pctrl->irq[i] = ret assignment below the check on ret, thanks
> to Manivannan Sadhasivam for suggesting this change.
Patch applied with Manivannan's ACK!
(Hope it's the right version now.)
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-07-02 14:06 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-02 12:47 [PATCH][V2] pinctrl: actions: fix unsigned less than zero comparison Colin King
2018-07-02 12:47 ` Colin King
2018-07-02 12:47 ` Colin King
2018-07-02 13:02 ` Manivannan Sadhasivam
2018-07-02 13:14 ` Manivannan Sadhasivam
2018-07-02 13:02 ` Manivannan Sadhasivam
2018-07-02 14:06 ` Linus Walleij
2018-07-02 14:06 ` Linus Walleij
2018-07-02 14:06 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.