All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Rickard ANDERSSON <rickard.andersson@stericsson.com>,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Andrew Victor <linux@maxim.org.za>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	"Nori, Sekhar" <nsekhar@ti.com>,
	ext Kevin Hilman <khilman@deeprootsystems.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Shawn Guo <shawn.guo@linaro.org>,
	ext Tony Lindgren <tony@atomide.com>,
	Ben Dooks <ben-linux@fluff.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Srinidhi KASAGAR <srinidhi.kasagar@stericsson.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 8/8] ARM: ux500: move cpuidle drivers to drivers/cpuidle/
Date: Wed, 26 Jun 2013 22:42:54 +0200	[thread overview]
Message-ID: <CACRpkda4NqFaniYP=bXZar+_0nM0c4b7OuKy4D_vYdfSORGQTg@mail.gmail.com> (raw)
In-Reply-To: <1372241747-21083-9-git-send-email-b.zolnierkie@samsung.com>

On Wed, Jun 26, 2013 at 12:15 PM, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:

--- a/arch/arm/mach-ux500/cpuidle
-#include "db8500-regs.h"
-#include "id.h"
> +++ b/drivers/cpuidle/cpuidle-ux500.c
(...)
> +#include "../../arch/arm/mach-ux500/db8500-regs.h"
> +#include "../../arch/arm/mach-ux500/id.h"

Well that was creative. NACK.

If you want to move the driver you need to come up with
proper interfaces making the move clean, not just move the files
and make them compile somewhere else I think.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] ARM: ux500: move cpuidle drivers to drivers/cpuidle/
Date: Wed, 26 Jun 2013 22:42:54 +0200	[thread overview]
Message-ID: <CACRpkda4NqFaniYP=bXZar+_0nM0c4b7OuKy4D_vYdfSORGQTg@mail.gmail.com> (raw)
In-Reply-To: <1372241747-21083-9-git-send-email-b.zolnierkie@samsung.com>

On Wed, Jun 26, 2013 at 12:15 PM, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:

--- a/arch/arm/mach-ux500/cpuidle
-#include "db8500-regs.h"
-#include "id.h"
> +++ b/drivers/cpuidle/cpuidle-ux500.c
(...)
> +#include "../../arch/arm/mach-ux500/db8500-regs.h"
> +#include "../../arch/arm/mach-ux500/id.h"

Well that was creative. NACK.

If you want to move the driver you need to come up with
proper interfaces making the move clean, not just move the files
and make them compile somewhere else I think.

Yours,
Linus Walleij

  reply	other threads:[~2013-06-26 20:42 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-26 10:15 [PATCH 0/8] ARM: move cpuidle drivers to drivers/cpuidle/ Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 1/8] ARM: at91: move cpuidle driver " Bartlomiej Zolnierkiewicz
2013-06-26 10:15   ` Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 2/8] ARM: davinci: " Bartlomiej Zolnierkiewicz
2013-06-26 10:15   ` Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 3/8] ARM: imx: move cpuidle drivers " Bartlomiej Zolnierkiewicz
2013-06-26 10:15   ` Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 4/8] ARM: OMAP: " Bartlomiej Zolnierkiewicz
2013-06-26 10:15   ` Bartlomiej Zolnierkiewicz
2013-06-27  8:06   ` Tony Lindgren
2013-06-27  8:06     ` Tony Lindgren
2013-06-27 17:25     ` Kevin Hilman
2013-06-27 17:25       ` Kevin Hilman
2013-06-27 15:36   ` Santosh Shilimkar
2013-06-27 15:36     ` Santosh Shilimkar
2013-06-26 10:15 ` [PATCH 5/8] ARM: S3C64XX: move cpuidle driver " Bartlomiej Zolnierkiewicz
2013-06-26 10:15   ` Bartlomiej Zolnierkiewicz
2013-07-22  3:33   ` Kukjin Kim
2013-07-22  3:33     ` Kukjin Kim
2013-06-26 10:15 ` [PATCH 6/8] ARM: shmobile: " Bartlomiej Zolnierkiewicz
2013-06-26 10:15   ` Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 7/8] ARM: tegra: move cpuidle drivers " Bartlomiej Zolnierkiewicz
2013-06-26 10:15   ` Bartlomiej Zolnierkiewicz
2013-06-26 18:24   ` Stephen Warren
2013-06-26 18:24     ` Stephen Warren
2013-06-26 10:15 ` [PATCH 8/8] ARM: ux500: " Bartlomiej Zolnierkiewicz
2013-06-26 10:15   ` Bartlomiej Zolnierkiewicz
2013-06-26 20:42   ` Linus Walleij [this message]
2013-06-26 20:42     ` Linus Walleij
2013-06-26 21:28     ` Arnd Bergmann
2013-06-26 21:28       ` Arnd Bergmann
2013-06-26 10:59 ` [PATCH 0/8] ARM: " Daniel Lezcano
2013-06-26 10:59   ` Daniel Lezcano
2013-06-26 12:22   ` Bartlomiej Zolnierkiewicz
2013-06-26 12:22     ` Bartlomiej Zolnierkiewicz
2013-06-26 13:05     ` Daniel Lezcano
2013-06-26 13:05       ` Daniel Lezcano
2013-06-26 14:40       ` Bartlomiej Zolnierkiewicz
2013-06-26 14:40         ` Bartlomiej Zolnierkiewicz
2013-06-26 16:57         ` Daniel Lezcano
2013-06-26 16:57           ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkda4NqFaniYP=bXZar+_0nM0c4b7OuKy4D_vYdfSORGQTg@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=ben-linux@fluff.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=horms@verge.net.au \
    --cc=kernel@pengutronix.de \
    --cc=kgene.kim@samsung.com \
    --cc=khilman@deeprootsystems.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@maxim.org.za \
    --cc=magnus.damm@gmail.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=nsekhar@ti.com \
    --cc=olof@lixom.net \
    --cc=plagnioj@jcrosoft.com \
    --cc=rickard.andersson@stericsson.com \
    --cc=rjw@sisk.pl \
    --cc=shawn.guo@linaro.org \
    --cc=srinidhi.kasagar@stericsson.com \
    --cc=swarren@wwwdotorg.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.