From: Linus Walleij <linus.walleij@linaro.org> To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, Sascha Hauer <kernel@pengutronix.de> Cc: "Niklas Söderlund" <niso@kth.se>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>, "Magnus Damm" <magnus.damm@gmail.com> Subject: Re: [RFC/PATCH] pinctrl: sh-pfc: Accept standard function, pins and groups properties Date: Wed, 04 Feb 2015 08:40:48 +0000 [thread overview] Message-ID: <CACRpkda6H7hbgXhmSbgtwOC_8PbHnES5syp-YEp1+V6s5Ym6Cw@mail.gmail.com> (raw) In-Reply-To: <1422390694-12389-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> On Tue, Jan 27, 2015 at 9:31 PM, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > The "function", "pins" and "groups" pinmux and pinctrl properties have > been standardized. Support them in addition to the custom "renesas,*" > properties. New-style and old-style properties can't be mixed in DT. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> (...) >> Would be nice if the PFC driver could be augmented to also accept the >> now standard bindings "groups" and "function" simply :) we're adding parse >> functions for those to the core. > > Something like this ? Yes :) > Please note two differences between the Renesas PFC bindings and the standard > bindings: > > - The standard bindings state that a pinctrl node must contain either a "pins" > property or a "groups" property, while the Renesas bindings allows for both > to coexist in the same node. Sascha also says this makes sense for him so I guess I'm getting a bit soft on the issue. > - The standard bindings don't allow a pinmux node to contain a "pins" property, > while the Renesas bindings do. Does that mean "pins" affect the muxing or that "pins" is about some per-pin config shoveled into the same node? The former is not OK, the latter is. > mmcif_pins: mmcif { > mux { > - renesas,groups = "mmc0_data8_0", "mmc0_ctrl_0"; > - renesas,function = "mmc0"; > + groups = "mmc0_data8_0", "mmc0_ctrl_0"; > + function = "mmc0"; > }; So that looks just very nice. > cfg { > - renesas,groups = "mmc0_data8_0"; > - renesas,pins = "PORT279"; > + groups = "mmc0_data8_0"; > + pins = "PORT279"; > bias-pull-up; And here I can't see the use of "groups" in this node since it doesn't match a function. It's a bit ambiguous what "groups" mean when you run into it like this. Yours, Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org> To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, Sascha Hauer <kernel@pengutronix.de> Cc: "Niklas Söderlund" <niso@kth.se>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>, "Magnus Damm" <magnus.damm@gmail.com> Subject: Re: [RFC/PATCH] pinctrl: sh-pfc: Accept standard function, pins and groups properties Date: Wed, 4 Feb 2015 09:40:48 +0100 [thread overview] Message-ID: <CACRpkda6H7hbgXhmSbgtwOC_8PbHnES5syp-YEp1+V6s5Ym6Cw@mail.gmail.com> (raw) In-Reply-To: <1422390694-12389-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> On Tue, Jan 27, 2015 at 9:31 PM, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > The "function", "pins" and "groups" pinmux and pinctrl properties have > been standardized. Support them in addition to the custom "renesas,*" > properties. New-style and old-style properties can't be mixed in DT. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> (...) >> Would be nice if the PFC driver could be augmented to also accept the >> now standard bindings "groups" and "function" simply :) we're adding parse >> functions for those to the core. > > Something like this ? Yes :) > Please note two differences between the Renesas PFC bindings and the standard > bindings: > > - The standard bindings state that a pinctrl node must contain either a "pins" > property or a "groups" property, while the Renesas bindings allows for both > to coexist in the same node. Sascha also says this makes sense for him so I guess I'm getting a bit soft on the issue. > - The standard bindings don't allow a pinmux node to contain a "pins" property, > while the Renesas bindings do. Does that mean "pins" affect the muxing or that "pins" is about some per-pin config shoveled into the same node? The former is not OK, the latter is. > mmcif_pins: mmcif { > mux { > - renesas,groups = "mmc0_data8_0", "mmc0_ctrl_0"; > - renesas,function = "mmc0"; > + groups = "mmc0_data8_0", "mmc0_ctrl_0"; > + function = "mmc0"; > }; So that looks just very nice. > cfg { > - renesas,groups = "mmc0_data8_0"; > - renesas,pins = "PORT279"; > + groups = "mmc0_data8_0"; > + pins = "PORT279"; > bias-pull-up; And here I can't see the use of "groups" in this node since it doesn't match a function. It's a bit ambiguous what "groups" mean when you run into it like this. Yours, Linus Walleij
next prev parent reply other threads:[~2015-02-04 8:40 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-18 12:20 [PATCH v2 0/4] Add emev2 pinmux support Niklas Söderlund 2015-01-18 12:20 ` Niklas Söderlund 2015-01-18 12:20 ` [PATCH v2 2/4] sh-pfc: " Niklas Söderlund 2015-01-18 12:20 ` Niklas Söderlund 2015-01-22 22:37 ` Laurent Pinchart 2015-01-22 22:37 ` Laurent Pinchart 2015-01-25 13:48 ` Niklas Söderlund 2015-01-25 13:48 ` Niklas Söderlund [not found] ` <20150125134823.GA26657-ofJ5d6taAgLV0csKaCxRng@public.gmane.org> 2015-01-25 15:55 ` Laurent Pinchart 2015-01-25 15:55 ` Laurent Pinchart 2015-01-25 15:55 ` Laurent Pinchart 2015-01-25 13:49 ` [PATCH v3] " Niklas Söderlund 2015-01-25 13:49 ` Niklas Söderlund 2015-01-25 13:49 ` Niklas Söderlund 2015-01-25 16:05 ` Laurent Pinchart 2015-01-25 16:05 ` Laurent Pinchart 2015-01-27 7:52 ` Linus Walleij 2015-01-27 7:52 ` Linus Walleij 2015-01-18 12:20 ` [PATCH v2 3/4] ARM: shmobile: emev2: Add PFC information to emev2.dtsi Niklas Söderlund 2015-01-18 12:20 ` Niklas Söderlund 2015-01-22 21:50 ` Laurent Pinchart 2015-01-22 21:50 ` Laurent Pinchart 2015-01-27 7:53 ` Linus Walleij 2015-01-27 7:53 ` Linus Walleij [not found] ` <1421583604-27256-1-git-send-email-niso-UNjuZkX4dYU@public.gmane.org> 2015-01-18 12:20 ` [PATCH v2 1/4] sh-pfc: add macro to define pinmux without function Niklas Söderlund 2015-01-18 12:20 ` Niklas Söderlund 2015-01-18 12:20 ` Niklas Söderlund [not found] ` <1421583604-27256-2-git-send-email-niso-UNjuZkX4dYU@public.gmane.org> 2015-01-22 21:50 ` Laurent Pinchart 2015-01-22 21:50 ` Laurent Pinchart 2015-01-22 21:50 ` Laurent Pinchart 2015-01-27 7:48 ` Linus Walleij 2015-01-27 7:48 ` Linus Walleij 2015-01-18 12:20 ` [PATCH v2 4/4] ARM: shmobile: emev2-kzm9d: Add PFC information for uart1 Niklas Söderlund 2015-01-18 12:20 ` Niklas Söderlund 2015-01-18 12:20 ` Niklas Söderlund 2015-01-27 7:55 ` Linus Walleij 2015-01-27 7:55 ` Linus Walleij 2015-01-27 20:31 ` [RFC/PATCH] pinctrl: sh-pfc: Accept standard function, pins and groups properties Laurent Pinchart 2015-01-27 20:31 ` Laurent Pinchart 2015-01-27 20:40 ` Geert Uytterhoeven 2015-01-27 20:40 ` Geert Uytterhoeven 2015-02-04 8:40 ` Linus Walleij [this message] 2015-02-04 8:40 ` Linus Walleij [not found] ` <CACRpkda6H7hbgXhmSbgtwOC_8PbHnES5syp-YEp1+V6s5Ym6Cw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-02-04 9:53 ` Laurent Pinchart 2015-02-04 9:53 ` Laurent Pinchart 2015-02-04 9:53 ` Laurent Pinchart 2015-03-01 12:19 ` Laurent Pinchart 2015-03-01 12:19 ` Laurent Pinchart 2015-03-06 10:39 ` Linus Walleij 2015-03-06 10:39 ` Linus Walleij [not found] ` <CACRpkdbepTKxMFVpTo7ZmjYE1beF5XOMOQarszaDGojerNQqMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-06-09 14:35 ` Geert Uytterhoeven 2015-06-09 14:35 ` Geert Uytterhoeven 2015-06-09 14:35 ` Geert Uytterhoeven [not found] ` <CAMuHMdWp4iBGtR2EiYMa03hwJrSOpq9dB==yDgt+OwjCebuFMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-06-10 8:46 ` Linus Walleij 2015-06-10 8:46 ` Linus Walleij 2015-06-10 8:46 ` Linus Walleij 2015-01-27 20:35 ` [PATCH v2 4/4] ARM: shmobile: emev2-kzm9d: Add PFC information for uart1 Laurent Pinchart 2015-01-27 20:35 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACRpkda6H7hbgXhmSbgtwOC_8PbHnES5syp-YEp1+V6s5Ym6Cw@mail.gmail.com \ --to=linus.walleij@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=kernel@pengutronix.de \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=niso@kth.se \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.