* [PATCH] pinctrl: add pwm37 to bm1880_pctrl_groups
@ 2020-04-28 11:55 ` Jason Yan
0 siblings, 0 replies; 6+ messages in thread
From: Jason Yan @ 2020-04-28 11:55 UTC (permalink / raw)
To: manivannan.sadhasivam, linus.walleij, linux-arm-kernel, linux-gpio
Cc: Jason Yan
The 'pwm37' is not added to bm1880_pctrl_groups, which triggers a gcc
build warning:
drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined
but not used [-Wunused-const-variable=]
static const unsigned int pwm37_pins[] = { 110 };
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/pinctrl/pinctrl-bm1880.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c
index f7dff4f14101..d1a7d9836787 100644
--- a/drivers/pinctrl/pinctrl-bm1880.c
+++ b/drivers/pinctrl/pinctrl-bm1880.c
@@ -408,6 +408,7 @@ static const struct bm1880_pctrl_group bm1880_pctrl_groups[] = {
BM1880_PINCTRL_GRP(pwm34),
BM1880_PINCTRL_GRP(pwm35),
BM1880_PINCTRL_GRP(pwm36),
+ BM1880_PINCTRL_GRP(pwm37),
BM1880_PINCTRL_GRP(i2c0),
BM1880_PINCTRL_GRP(i2c1),
BM1880_PINCTRL_GRP(i2c2),
--
2.21.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] pinctrl: add pwm37 to bm1880_pctrl_groups
@ 2020-04-28 11:55 ` Jason Yan
0 siblings, 0 replies; 6+ messages in thread
From: Jason Yan @ 2020-04-28 11:55 UTC (permalink / raw)
To: manivannan.sadhasivam, linus.walleij, linux-arm-kernel, linux-gpio
Cc: Jason Yan
The 'pwm37' is not added to bm1880_pctrl_groups, which triggers a gcc
build warning:
drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined
but not used [-Wunused-const-variable=]
static const unsigned int pwm37_pins[] = { 110 };
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/pinctrl/pinctrl-bm1880.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c
index f7dff4f14101..d1a7d9836787 100644
--- a/drivers/pinctrl/pinctrl-bm1880.c
+++ b/drivers/pinctrl/pinctrl-bm1880.c
@@ -408,6 +408,7 @@ static const struct bm1880_pctrl_group bm1880_pctrl_groups[] = {
BM1880_PINCTRL_GRP(pwm34),
BM1880_PINCTRL_GRP(pwm35),
BM1880_PINCTRL_GRP(pwm36),
+ BM1880_PINCTRL_GRP(pwm37),
BM1880_PINCTRL_GRP(i2c0),
BM1880_PINCTRL_GRP(i2c1),
BM1880_PINCTRL_GRP(i2c2),
--
2.21.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: add pwm37 to bm1880_pctrl_groups
2020-04-28 11:55 ` Jason Yan
@ 2020-04-28 12:06 ` Manivannan Sadhasivam
-1 siblings, 0 replies; 6+ messages in thread
From: Manivannan Sadhasivam @ 2020-04-28 12:06 UTC (permalink / raw)
To: Jason Yan; +Cc: linus.walleij, linux-arm-kernel, linux-gpio
On Tue, Apr 28, 2020 at 07:55:43PM +0800, Jason Yan wrote:
> The 'pwm37' is not added to bm1880_pctrl_groups, which triggers a gcc
> build warning:
>
> drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined
> but not used [-Wunused-const-variable=]
> static const unsigned int pwm37_pins[] = { 110 };
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/pinctrl/pinctrl-bm1880.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c
> index f7dff4f14101..d1a7d9836787 100644
> --- a/drivers/pinctrl/pinctrl-bm1880.c
> +++ b/drivers/pinctrl/pinctrl-bm1880.c
> @@ -408,6 +408,7 @@ static const struct bm1880_pctrl_group bm1880_pctrl_groups[] = {
> BM1880_PINCTRL_GRP(pwm34),
> BM1880_PINCTRL_GRP(pwm35),
> BM1880_PINCTRL_GRP(pwm36),
> + BM1880_PINCTRL_GRP(pwm37),
> BM1880_PINCTRL_GRP(i2c0),
> BM1880_PINCTRL_GRP(i2c1),
> BM1880_PINCTRL_GRP(i2c2),
> --
> 2.21.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: add pwm37 to bm1880_pctrl_groups
@ 2020-04-28 12:06 ` Manivannan Sadhasivam
0 siblings, 0 replies; 6+ messages in thread
From: Manivannan Sadhasivam @ 2020-04-28 12:06 UTC (permalink / raw)
To: Jason Yan; +Cc: linux-gpio, linus.walleij, linux-arm-kernel
On Tue, Apr 28, 2020 at 07:55:43PM +0800, Jason Yan wrote:
> The 'pwm37' is not added to bm1880_pctrl_groups, which triggers a gcc
> build warning:
>
> drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined
> but not used [-Wunused-const-variable=]
> static const unsigned int pwm37_pins[] = { 110 };
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/pinctrl/pinctrl-bm1880.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c
> index f7dff4f14101..d1a7d9836787 100644
> --- a/drivers/pinctrl/pinctrl-bm1880.c
> +++ b/drivers/pinctrl/pinctrl-bm1880.c
> @@ -408,6 +408,7 @@ static const struct bm1880_pctrl_group bm1880_pctrl_groups[] = {
> BM1880_PINCTRL_GRP(pwm34),
> BM1880_PINCTRL_GRP(pwm35),
> BM1880_PINCTRL_GRP(pwm36),
> + BM1880_PINCTRL_GRP(pwm37),
> BM1880_PINCTRL_GRP(i2c0),
> BM1880_PINCTRL_GRP(i2c1),
> BM1880_PINCTRL_GRP(i2c2),
> --
> 2.21.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: add pwm37 to bm1880_pctrl_groups
2020-04-28 11:55 ` Jason Yan
@ 2020-04-28 14:29 ` Linus Walleij
-1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2020-04-28 14:29 UTC (permalink / raw)
To: Jason Yan; +Cc: Manivannan Sadhasivam, Linux ARM, open list:GPIO SUBSYSTEM
On Tue, Apr 28, 2020 at 1:56 PM Jason Yan <yanaijie@huawei.com> wrote:
> The 'pwm37' is not added to bm1880_pctrl_groups, which triggers a gcc
> build warning:
>
> drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined
> but not used [-Wunused-const-variable=]
> static const unsigned int pwm37_pins[] = { 110 };
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: add pwm37 to bm1880_pctrl_groups
@ 2020-04-28 14:29 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2020-04-28 14:29 UTC (permalink / raw)
To: Jason Yan; +Cc: open list:GPIO SUBSYSTEM, Linux ARM, Manivannan Sadhasivam
On Tue, Apr 28, 2020 at 1:56 PM Jason Yan <yanaijie@huawei.com> wrote:
> The 'pwm37' is not added to bm1880_pctrl_groups, which triggers a gcc
> build warning:
>
> drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined
> but not used [-Wunused-const-variable=]
> static const unsigned int pwm37_pins[] = { 110 };
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Patch applied!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-28 14:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28 11:55 [PATCH] pinctrl: add pwm37 to bm1880_pctrl_groups Jason Yan
2020-04-28 11:55 ` Jason Yan
2020-04-28 12:06 ` Manivannan Sadhasivam
2020-04-28 12:06 ` Manivannan Sadhasivam
2020-04-28 14:29 ` Linus Walleij
2020-04-28 14:29 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.