All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] pinctrl: sh-pfc: checker: Fix miscalculation of number of states
Date: Tue, 22 Feb 2022 16:27:00 +0100	[thread overview]
Message-ID: <CACRpkdaJAEivz_RVGCyDvwJtDnb7E+mpxt8a66TicZW=oNttNw@mail.gmail.com> (raw)
In-Reply-To: <6d8a6a05564f38f9d20464c1c17f96e52740cf6a.1645460429.git.geert+renesas@glider.be>

On Mon, Feb 21, 2022 at 5:22 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:

> The checker failed to validate all enum IDs in the description of a
> register with fixed-width register fields, due to a miscalculation of
> the number of described states: each register field of n bits can have
> "1 << n" possible states, not "1".
>
> Increase SH_PFC_MAX_ENUMS accordingly, now more enum IDs are checked
> (SH-Mobile AG5 has more than 4000 enum IDs defined).
>
> Fixes: 12d057bad683b1c6 ("pinctrl: sh-pfc: checker: Add check for enum ID conflicts")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> To be queued in renesas-pinctrl-for-v5.18.

I certainly trust you to generally do what is best for the Renesas drivers.

I have a question about this checker infrastructure because it is obviously
a piece of really valuable code for Renesas.

How general is this checker? Do we have other drivers in the kernel that
would benefit from it or is it completely Renesas-specific?

If it has general value I think it should be moved to be one floor down,
with the pinctrl framework, if possible. But I don't know the details.

Yours,
Linus Walleij

  reply	other threads:[~2022-02-22 15:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 16:21 [PATCH] pinctrl: sh-pfc: checker: Fix miscalculation of number of states Geert Uytterhoeven
2022-02-22 15:27 ` Linus Walleij [this message]
2022-02-22 15:37   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdaJAEivz_RVGCyDvwJtDnb7E+mpxt8a66TicZW=oNttNw@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.