* [PATCH] gpio: davinci: fix build warning when !CONFIG_OF
@ 2018-05-29 14:51 ` Sekhar Nori
0 siblings, 0 replies; 3+ messages in thread
From: Sekhar Nori @ 2018-05-29 14:51 UTC (permalink / raw)
To: Keerthy, Linus Walleij; +Cc: linux-gpio, linux-kernel, Sekhar Nori
This nukes the following warning that is seen when building without
OF support:
drivers/gpio/gpio-davinci.c:437:25: warning: ‘keystone_gpio_get_irq_chip’ defined but not used [-Wunused-function]
static struct irq_chip *keystone_gpio_get_irq_chip(unsigned int irq)
^~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
drivers/gpio/gpio-davinci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 987126c4c6f6..b574ecff7761 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -610,14 +610,12 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
return 0;
}
-#if IS_ENABLED(CONFIG_OF)
static const struct of_device_id davinci_gpio_ids[] = {
{ .compatible = "ti,keystone-gpio", keystone_gpio_get_irq_chip},
{ .compatible = "ti,dm6441-gpio", davinci_gpio_get_irq_chip},
{ /* sentinel */ },
};
MODULE_DEVICE_TABLE(of, davinci_gpio_ids);
-#endif
static struct platform_driver davinci_gpio_driver = {
.probe = davinci_gpio_probe,
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] gpio: davinci: fix build warning when !CONFIG_OF
@ 2018-05-29 14:51 ` Sekhar Nori
0 siblings, 0 replies; 3+ messages in thread
From: Sekhar Nori @ 2018-05-29 14:51 UTC (permalink / raw)
To: Keerthy, Linus Walleij; +Cc: linux-gpio, linux-kernel, Sekhar Nori
This nukes the following warning that is seen when building without
OF support:
drivers/gpio/gpio-davinci.c:437:25: warning: ‘keystone_gpio_get_irq_chip’ defined but not used [-Wunused-function]
static struct irq_chip *keystone_gpio_get_irq_chip(unsigned int irq)
^~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
drivers/gpio/gpio-davinci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 987126c4c6f6..b574ecff7761 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -610,14 +610,12 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
return 0;
}
-#if IS_ENABLED(CONFIG_OF)
static const struct of_device_id davinci_gpio_ids[] = {
{ .compatible = "ti,keystone-gpio", keystone_gpio_get_irq_chip},
{ .compatible = "ti,dm6441-gpio", davinci_gpio_get_irq_chip},
{ /* sentinel */ },
};
MODULE_DEVICE_TABLE(of, davinci_gpio_ids);
-#endif
static struct platform_driver davinci_gpio_driver = {
.probe = davinci_gpio_probe,
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: davinci: fix build warning when !CONFIG_OF
2018-05-29 14:51 ` Sekhar Nori
(?)
@ 2018-05-30 7:11 ` Linus Walleij
-1 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-05-30 7:11 UTC (permalink / raw)
To: Sekhar Nori; +Cc: Keerthy, open list:GPIO SUBSYSTEM, linux-kernel
On Tue, May 29, 2018 at 4:51 PM, Sekhar Nori <nsekhar@ti.com> wrote:
> This nukes the following warning that is seen when building without
> OF support:
>
> drivers/gpio/gpio-davinci.c:437:25: warning: ‘keystone_gpio_get_irq_chip’ defined but not used [-Wunused-function]
> static struct irq_chip *keystone_gpio_get_irq_chip(unsigned int irq)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-30 7:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-29 14:51 [PATCH] gpio: davinci: fix build warning when !CONFIG_OF Sekhar Nori
2018-05-29 14:51 ` Sekhar Nori
2018-05-30 7:11 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.