* [PATCH -next] pinctrl: pinctrl-microchip-sgpio: Mark some symbols with static keyword
@ 2020-11-24 11:42 ` Zou Wei
0 siblings, 0 replies; 4+ messages in thread
From: Zou Wei @ 2020-11-24 11:42 UTC (permalink / raw)
To: lars.povlsen, Steen.Hegelund, UNGLinuxDriver, linus.walleij
Cc: linux-arm-kernel, linux-gpio, linux-kernel, Zou Wei
Fix the following sparse warnings:
drivers/pinctrl/pinctrl-microchip-sgpio.c:63:31: warning: symbol 'properties_luton' was not declared. Should it be static?
drivers/pinctrl/pinctrl-microchip-sgpio.c:68:31: warning: symbol 'properties_ocelot' was not declared. Should it be static?
drivers/pinctrl/pinctrl-microchip-sgpio.c:73:31: warning: symbol 'properties_sparx5' was not declared. Should it be static?
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/pinctrl/pinctrl-microchip-sgpio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c
index d6c31cc..e182419 100644
--- a/drivers/pinctrl/pinctrl-microchip-sgpio.c
+++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c
@@ -60,17 +60,17 @@ struct sgpio_properties {
#define SGPIO_SPARX5_CLK_FREQ GENMASK(19, 8)
#define SGPIO_SPARX5_BIT_SOURCE GENMASK(23, 12)
-const struct sgpio_properties properties_luton = {
+static const struct sgpio_properties properties_luton = {
.arch = SGPIO_ARCH_LUTON,
.regoff = { 0x00, 0x09, 0x29, 0x2a, 0x2b },
};
-const struct sgpio_properties properties_ocelot = {
+static const struct sgpio_properties properties_ocelot = {
.arch = SGPIO_ARCH_OCELOT,
.regoff = { 0x00, 0x06, 0x26, 0x04, 0x05 },
};
-const struct sgpio_properties properties_sparx5 = {
+static const struct sgpio_properties properties_sparx5 = {
.arch = SGPIO_ARCH_SPARX5,
.regoff = { 0x00, 0x06, 0x26, 0x04, 0x05 },
};
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] pinctrl: pinctrl-microchip-sgpio: Mark some symbols with static keyword
@ 2020-11-24 11:42 ` Zou Wei
0 siblings, 0 replies; 4+ messages in thread
From: Zou Wei @ 2020-11-24 11:42 UTC (permalink / raw)
To: lars.povlsen, Steen.Hegelund, UNGLinuxDriver, linus.walleij
Cc: linux-gpio, Zou Wei, linux-kernel, linux-arm-kernel
Fix the following sparse warnings:
drivers/pinctrl/pinctrl-microchip-sgpio.c:63:31: warning: symbol 'properties_luton' was not declared. Should it be static?
drivers/pinctrl/pinctrl-microchip-sgpio.c:68:31: warning: symbol 'properties_ocelot' was not declared. Should it be static?
drivers/pinctrl/pinctrl-microchip-sgpio.c:73:31: warning: symbol 'properties_sparx5' was not declared. Should it be static?
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/pinctrl/pinctrl-microchip-sgpio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c
index d6c31cc..e182419 100644
--- a/drivers/pinctrl/pinctrl-microchip-sgpio.c
+++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c
@@ -60,17 +60,17 @@ struct sgpio_properties {
#define SGPIO_SPARX5_CLK_FREQ GENMASK(19, 8)
#define SGPIO_SPARX5_BIT_SOURCE GENMASK(23, 12)
-const struct sgpio_properties properties_luton = {
+static const struct sgpio_properties properties_luton = {
.arch = SGPIO_ARCH_LUTON,
.regoff = { 0x00, 0x09, 0x29, 0x2a, 0x2b },
};
-const struct sgpio_properties properties_ocelot = {
+static const struct sgpio_properties properties_ocelot = {
.arch = SGPIO_ARCH_OCELOT,
.regoff = { 0x00, 0x06, 0x26, 0x04, 0x05 },
};
-const struct sgpio_properties properties_sparx5 = {
+static const struct sgpio_properties properties_sparx5 = {
.arch = SGPIO_ARCH_SPARX5,
.regoff = { 0x00, 0x06, 0x26, 0x04, 0x05 },
};
--
2.6.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] pinctrl: pinctrl-microchip-sgpio: Mark some symbols with static keyword
2020-11-24 11:42 ` Zou Wei
@ 2020-12-04 8:56 ` Linus Walleij
-1 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2020-12-04 8:56 UTC (permalink / raw)
To: Zou Wei
Cc: Lars Povlsen, Steen Hegelund, Microchip Linux Driver Support,
Linux ARM, open list:GPIO SUBSYSTEM, linux-kernel
On Tue, Nov 24, 2020 at 12:31 PM Zou Wei <zou_wei@huawei.com> wrote:
> Fix the following sparse warnings:
>
> drivers/pinctrl/pinctrl-microchip-sgpio.c:63:31: warning: symbol 'properties_luton' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-microchip-sgpio.c:68:31: warning: symbol 'properties_ocelot' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-microchip-sgpio.c:73:31: warning: symbol 'properties_sparx5' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Patch applied, thanks Zou!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] pinctrl: pinctrl-microchip-sgpio: Mark some symbols with static keyword
@ 2020-12-04 8:56 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2020-12-04 8:56 UTC (permalink / raw)
To: Zou Wei
Cc: Steen Hegelund, linux-kernel, Microchip Linux Driver Support,
open list:GPIO SUBSYSTEM, Lars Povlsen, Linux ARM
On Tue, Nov 24, 2020 at 12:31 PM Zou Wei <zou_wei@huawei.com> wrote:
> Fix the following sparse warnings:
>
> drivers/pinctrl/pinctrl-microchip-sgpio.c:63:31: warning: symbol 'properties_luton' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-microchip-sgpio.c:68:31: warning: symbol 'properties_ocelot' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-microchip-sgpio.c:73:31: warning: symbol 'properties_sparx5' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Patch applied, thanks Zou!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-04 8:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-24 11:42 [PATCH -next] pinctrl: pinctrl-microchip-sgpio: Mark some symbols with static keyword Zou Wei
2020-11-24 11:42 ` Zou Wei
2020-12-04 8:56 ` Linus Walleij
2020-12-04 8:56 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.