From: Linus Walleij <linus.walleij@linaro.org>
To: Drew Fustini <drew@pdp7.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Drew Fustini <drew@beagleboard.org>,
Kent Gibson <warthog618@gmail.com>,
Jason Kridner <jkridner@beagleboard.org>,
Robert Nelson <robertcnelson@beagleboard.org>
Subject: Re: gpio-omap: add support gpiolib bias (pull-up/down) flags?
Date: Thu, 12 Mar 2020 11:43:00 +0100 [thread overview]
Message-ID: <CACRpkdaPoMGZ7jGh6j4dYexx+qCcoMQ37vS7kbpf=3TtcA9zQQ@mail.gmail.com> (raw)
In-Reply-To: <CAEf4M_Du6Egn-3nZHtSnMMwohc+-DyEdtWU5DqSJi71+nDthFw@mail.gmail.com>
Hi Drew,
On Sun, Mar 8, 2020 at 2:07 PM Drew Fustini <drew@pdp7.com> wrote:
> I would like the BeagleBone, which has the TI AM3358 SoC, to be able
> to use the bias flags as well. The AM3358 uses the gpio-omap GPIO
> driver. However, gpio-omap does not support these flags [8].
>
> Do you have any feedback on whether this is possible to implement?
Do we have a datasheet for this GPIO block somewhere? Should
be the datasheet for the ASIC.
We already have the required .set_config() callback on the OMAP
driver, it's just that it only uses it for debounce.
The driver is a bit convoluted with register offsets in a struct
omap_gpio_reg_offs depending on variant, but if they have
a register for this I'd say just get hacking.
If the GPIO driver is using pin control as back-end you are
looking at something more complex similar to what Intel is
doing inside drivers/pinctrl/intel/pinctrl-intel.c: this driver
is just calling up to gpiochip_generic_config() which will
try to configure the lines behind the GPIO using pin config,
which works if the proper ranges are defined so the
framework can map a GPIO line to a pin control pin.
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-03-12 10:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 13:08 gpio-omap: add support gpiolib bias (pull-up/down) flags? Drew Fustini
2020-03-12 10:43 ` Linus Walleij [this message]
2020-03-13 0:39 ` Drew Fustini
2020-03-13 5:23 ` Haojian Zhuang
2020-04-13 12:39 ` Drew Fustini
2020-04-15 13:15 ` Grygorii Strashko
2020-04-15 13:20 ` Robert Nelson
2020-04-15 13:47 ` Grygorii Strashko
2020-04-15 13:59 ` Robert Nelson
2020-04-15 23:37 ` Drew Fustini
2020-04-16 12:03 ` Linus Walleij
2020-04-16 16:07 ` Drew Fustini
2020-04-16 14:16 ` Grygorii Strashko
2020-04-17 10:37 ` Linus Walleij
2020-04-16 16:32 ` Tony Lindgren
2020-04-23 13:17 ` Drew Fustini
2020-04-23 16:42 ` Tony Lindgren
2020-04-24 17:32 ` Drew Fustini
2020-04-24 17:49 ` Tony Lindgren
2020-05-25 13:17 ` Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdaPoMGZ7jGh6j4dYexx+qCcoMQ37vS7kbpf=3TtcA9zQQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=brgl@bgdev.pl \
--cc=drew@beagleboard.org \
--cc=drew@pdp7.com \
--cc=grygorii.strashko@ti.com \
--cc=jkridner@beagleboard.org \
--cc=khilman@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robertcnelson@beagleboard.org \
--cc=ssantosh@kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.