* [PATCH] pinctrl: coh901: Fix error checking in u300_gpio_to_irq
@ 2013-03-28 16:18 Axel Lin
2013-04-03 12:31 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2013-03-28 16:18 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-kernel
The pointer "port" is always not NULL if gpio->port_list is not empty.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/pinctrl-coh901.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-coh901.c b/drivers/pinctrl/pinctrl-coh901.c
index 86887850..edde3ac 100644
--- a/drivers/pinctrl/pinctrl-coh901.c
+++ b/drivers/pinctrl/pinctrl-coh901.c
@@ -318,13 +318,16 @@ static int u300_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
struct u300_gpio_port *port = NULL;
struct list_head *p;
int retirq;
+ bool found = false;
list_for_each(p, &gpio->port_list) {
port = list_entry(p, struct u300_gpio_port, node);
- if (port->number == portno)
+ if (port->number == portno) {
+ found = true;
break;
+ }
}
- if (port == NULL) {
+ if (!found) {
dev_err(gpio->dev, "could not locate port for GPIO %d IRQ\n",
offset);
return -EINVAL;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: coh901: Fix error checking in u300_gpio_to_irq
2013-03-28 16:18 [PATCH] pinctrl: coh901: Fix error checking in u300_gpio_to_irq Axel Lin
@ 2013-04-03 12:31 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2013-04-03 12:31 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel
On Thu, Mar 28, 2013 at 5:18 PM, Axel Lin <axel.lin@ingics.com> wrote:
> The pointer "port" is always not NULL if gpio->port_list is not empty.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Excellent catch Axel, thanks!!
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-03 12:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-28 16:18 [PATCH] pinctrl: coh901: Fix error checking in u300_gpio_to_irq Axel Lin
2013-04-03 12:31 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.