From: Linus Walleij <linus.walleij@linaro.org> To: Marc Zyngier <maz@kernel.org> Cc: Daniel Palmer <daniel@0x0f.com>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2 3/5] gpio: msc313: MStar MSC313 GPIO driver Date: Wed, 11 Nov 2020 15:09:19 +0100 [thread overview] Message-ID: <CACRpkdaTknFRSm4pcSf-v7Be8A_SnMMrhegu6W67gUjOJVLEBQ@mail.gmail.com> (raw) In-Reply-To: <bc0ab2f10bb72fe5b455ca12958f6444@kernel.org> On Tue, Nov 10, 2020 at 3:19 PM Marc Zyngier <maz@kernel.org> wrote: > On 2020-11-10 14:02, Linus Walleij wrote: > >> Probably nothing more than setting the callback to > >> irq_chip_set_affinity_parent, > > > > Hm, is this something all GPIO irqchips used on SMP systems > > should be doing? Or just hierarchical ones? > > Probably only the hierarchical ones. I'd expect the non-hierarchical > GPIOs to be muxed behind a single interrupt, which makes it impossible > to move a single GPIO around, and moving the mux interrupt would break > userspace's expectations that interrupts move independently of each > others. I found two suspects and sent patches. I think I might have some more candidates down in pinctrl. I do have some hierarchical IRQ that is on UP systems, I suppose these are not affected. Yours, Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org> To: Marc Zyngier <maz@kernel.org> Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Daniel Palmer <daniel@0x0f.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org> Subject: Re: [PATCH v2 3/5] gpio: msc313: MStar MSC313 GPIO driver Date: Wed, 11 Nov 2020 15:09:19 +0100 [thread overview] Message-ID: <CACRpkdaTknFRSm4pcSf-v7Be8A_SnMMrhegu6W67gUjOJVLEBQ@mail.gmail.com> (raw) In-Reply-To: <bc0ab2f10bb72fe5b455ca12958f6444@kernel.org> On Tue, Nov 10, 2020 at 3:19 PM Marc Zyngier <maz@kernel.org> wrote: > On 2020-11-10 14:02, Linus Walleij wrote: > >> Probably nothing more than setting the callback to > >> irq_chip_set_affinity_parent, > > > > Hm, is this something all GPIO irqchips used on SMP systems > > should be doing? Or just hierarchical ones? > > Probably only the hierarchical ones. I'd expect the non-hierarchical > GPIOs to be muxed behind a single interrupt, which makes it impossible > to move a single GPIO around, and moving the mux interrupt would break > userspace's expectations that interrupts move independently of each > others. I found two suspects and sent patches. I think I might have some more candidates down in pinctrl. I do have some hierarchical IRQ that is on UP systems, I suppose these are not affected. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-11 14:10 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-19 14:10 [PATCH v2 0/5] Add GPIO support for MStar/SigmaStar ARMv7 Daniel Palmer 2020-10-19 14:10 ` [PATCH v2 1/5] dt-bindings: gpio: Add a binding header for the MSC313 GPIO driver Daniel Palmer 2020-10-26 13:46 ` Rob Herring 2020-10-26 15:15 ` Daniel Palmer 2020-10-19 14:10 ` [PATCH v2 2/5] dt-bindings: gpio: Binding for MStar MSC313 GPIO controller Daniel Palmer 2020-10-26 13:48 ` Rob Herring 2020-10-19 14:10 ` [PATCH v2 3/5] gpio: msc313: MStar MSC313 GPIO driver Daniel Palmer 2020-10-20 12:00 ` Andy Shevchenko 2020-10-20 13:26 ` Daniel Palmer 2020-11-05 9:30 ` Linus Walleij 2020-11-05 9:40 ` Linus Walleij 2020-11-05 12:08 ` Marc Zyngier 2020-11-05 15:23 ` Daniel Palmer 2020-11-05 15:43 ` Marc Zyngier 2020-11-05 15:43 ` Marc Zyngier 2020-11-10 14:02 ` Linus Walleij 2020-11-10 14:02 ` Linus Walleij 2020-11-10 14:19 ` Marc Zyngier 2020-11-10 14:19 ` Marc Zyngier 2020-11-11 14:09 ` Linus Walleij [this message] 2020-11-11 14:09 ` Linus Walleij 2020-11-11 14:19 ` Marc Zyngier 2020-11-11 14:19 ` Marc Zyngier 2020-10-19 14:10 ` [PATCH v2 4/5] ARM: mstar: Add gpio controller to MStar base dtsi Daniel Palmer 2020-11-05 9:43 ` Linus Walleij 2020-10-19 14:10 ` [PATCH v2 5/5] ARM: mstar: Fill in GPIO controller properties for infinity Daniel Palmer 2020-11-05 9:44 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACRpkdaTknFRSm4pcSf-v7Be8A_SnMMrhegu6W67gUjOJVLEBQ@mail.gmail.com \ --to=linus.walleij@linaro.org \ --cc=daniel@0x0f.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maz@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.