All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gpio: moxart: fix build regression
@ 2016-01-07 13:55 ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-01-07 13:55 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-arm-kernel, linux-gpio

A cleanup patch replaced bgpio_chip with gpio_chip but missed
two references to the bgpio_chip:

drivers/gpio/gpio-moxart.c:60:19: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
        gc->bgpio_data = bgc->read_reg(bgc->reg_set);
drivers/gpio/gpio-moxart.c:35:20: note: 'gc' declared here
drivers/gpio/gpio-moxart.c:60:33: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
        gc->bgpio_data = bgc->read_reg(bgc->reg_set);

This adds the missing change.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
---

diff --git a/drivers/gpio/gpio-moxart.c b/drivers/gpio/gpio-moxart.c
index 71c13c4e12b5..ca604538ebf7 100644
--- a/drivers/gpio/gpio-moxart.c
+++ b/drivers/gpio/gpio-moxart.c
@@ -57,7 +57,7 @@ static int moxart_gpio_probe(struct platform_device *pdev)
 	gc->label = "moxart-gpio";
 	gc->request = gpiochip_generic_request;
 	gc->free = gpiochip_generic_free;
-	gc->bgpio_data = bgc->read_reg(bgc->reg_set);
+	gc->bgpio_data = gc->read_reg(gc->reg_set);
 	gc->base = 0;
 	gc->ngpio = 32;
 	gc->parent = dev;


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] gpio: moxart: fix build regression
@ 2016-01-07 13:55 ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-01-07 13:55 UTC (permalink / raw)
  To: linux-arm-kernel

A cleanup patch replaced bgpio_chip with gpio_chip but missed
two references to the bgpio_chip:

drivers/gpio/gpio-moxart.c:60:19: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
        gc->bgpio_data = bgc->read_reg(bgc->reg_set);
drivers/gpio/gpio-moxart.c:35:20: note: 'gc' declared here
drivers/gpio/gpio-moxart.c:60:33: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
        gc->bgpio_data = bgc->read_reg(bgc->reg_set);

This adds the missing change.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
---

diff --git a/drivers/gpio/gpio-moxart.c b/drivers/gpio/gpio-moxart.c
index 71c13c4e12b5..ca604538ebf7 100644
--- a/drivers/gpio/gpio-moxart.c
+++ b/drivers/gpio/gpio-moxart.c
@@ -57,7 +57,7 @@ static int moxart_gpio_probe(struct platform_device *pdev)
 	gc->label = "moxart-gpio";
 	gc->request = gpiochip_generic_request;
 	gc->free = gpiochip_generic_free;
-	gc->bgpio_data = bgc->read_reg(bgc->reg_set);
+	gc->bgpio_data = gc->read_reg(gc->reg_set);
 	gc->base = 0;
 	gc->ngpio = 32;
 	gc->parent = dev;

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] gpio: moxart: fix build regression
  2016-01-07 13:55 ` Arnd Bergmann
@ 2016-01-07 14:03   ` Arnd Bergmann
  -1 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-01-07 14:03 UTC (permalink / raw)
  To: linux-arm-kernel; +Cc: Linus Walleij, linux-gpio, Jonas Jensen

On Thursday 07 January 2016 14:55:34 Arnd Bergmann wrote:
> A cleanup patch replaced bgpio_chip with gpio_chip but missed
> two references to the bgpio_chip:
> 
> drivers/gpio/gpio-moxart.c:60:19: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
>         gc->bgpio_data = bgc->read_reg(bgc->reg_set);
> drivers/gpio/gpio-moxart.c:35:20: note: 'gc' declared here
> drivers/gpio/gpio-moxart.c:60:33: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
>         gc->bgpio_data = bgc->read_reg(bgc->reg_set);
> 
> This adds the missing change.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
> ---

Adding Jonas to Cc, sorry for forgetting him first.

> diff --git a/drivers/gpio/gpio-moxart.c b/drivers/gpio/gpio-moxart.c
> index 71c13c4e12b5..ca604538ebf7 100644
> --- a/drivers/gpio/gpio-moxart.c
> +++ b/drivers/gpio/gpio-moxart.c
> @@ -57,7 +57,7 @@ static int moxart_gpio_probe(struct platform_device *pdev)
>  	gc->label = "moxart-gpio";
>  	gc->request = gpiochip_generic_request;
>  	gc->free = gpiochip_generic_free;
> -	gc->bgpio_data = bgc->read_reg(bgc->reg_set);
> +	gc->bgpio_data = gc->read_reg(gc->reg_set);
>  	gc->base = 0;
>  	gc->ngpio = 32;
>  	gc->parent = dev;
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] gpio: moxart: fix build regression
@ 2016-01-07 14:03   ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-01-07 14:03 UTC (permalink / raw)
  To: linux-arm-kernel

On Thursday 07 January 2016 14:55:34 Arnd Bergmann wrote:
> A cleanup patch replaced bgpio_chip with gpio_chip but missed
> two references to the bgpio_chip:
> 
> drivers/gpio/gpio-moxart.c:60:19: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
>         gc->bgpio_data = bgc->read_reg(bgc->reg_set);
> drivers/gpio/gpio-moxart.c:35:20: note: 'gc' declared here
> drivers/gpio/gpio-moxart.c:60:33: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
>         gc->bgpio_data = bgc->read_reg(bgc->reg_set);
> 
> This adds the missing change.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
> ---

Adding Jonas to Cc, sorry for forgetting him first.

> diff --git a/drivers/gpio/gpio-moxart.c b/drivers/gpio/gpio-moxart.c
> index 71c13c4e12b5..ca604538ebf7 100644
> --- a/drivers/gpio/gpio-moxart.c
> +++ b/drivers/gpio/gpio-moxart.c
> @@ -57,7 +57,7 @@ static int moxart_gpio_probe(struct platform_device *pdev)
>  	gc->label = "moxart-gpio";
>  	gc->request = gpiochip_generic_request;
>  	gc->free = gpiochip_generic_free;
> -	gc->bgpio_data = bgc->read_reg(bgc->reg_set);
> +	gc->bgpio_data = gc->read_reg(gc->reg_set);
>  	gc->base = 0;
>  	gc->ngpio = 32;
>  	gc->parent = dev;
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] gpio: moxart: fix build regression
  2016-01-07 13:55 ` Arnd Bergmann
@ 2016-01-07 15:17   ` Linus Walleij
  -1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2016-01-07 15:17 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: linux-arm-kernel, linux-gpio

On Thu, Jan 7, 2016 at 2:55 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> A cleanup patch replaced bgpio_chip with gpio_chip but missed
> two references to the bgpio_chip:
>
> drivers/gpio/gpio-moxart.c:60:19: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
>         gc->bgpio_data = bgc->read_reg(bgc->reg_set);
> drivers/gpio/gpio-moxart.c:35:20: note: 'gc' declared here
> drivers/gpio/gpio-moxart.c:60:33: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
>         gc->bgpio_data = bgc->read_reg(bgc->reg_set);
>
> This adds the missing change.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")

Patch applied, sorry for the mess...

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] gpio: moxart: fix build regression
@ 2016-01-07 15:17   ` Linus Walleij
  0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2016-01-07 15:17 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Jan 7, 2016 at 2:55 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> A cleanup patch replaced bgpio_chip with gpio_chip but missed
> two references to the bgpio_chip:
>
> drivers/gpio/gpio-moxart.c:60:19: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
>         gc->bgpio_data = bgc->read_reg(bgc->reg_set);
> drivers/gpio/gpio-moxart.c:35:20: note: 'gc' declared here
> drivers/gpio/gpio-moxart.c:60:33: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
>         gc->bgpio_data = bgc->read_reg(bgc->reg_set);
>
> This adds the missing change.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")

Patch applied, sorry for the mess...

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-07 15:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-07 13:55 [PATCH] gpio: moxart: fix build regression Arnd Bergmann
2016-01-07 13:55 ` Arnd Bergmann
2016-01-07 14:03 ` Arnd Bergmann
2016-01-07 14:03   ` Arnd Bergmann
2016-01-07 15:17 ` Linus Walleij
2016-01-07 15:17   ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.