All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] clocksource: dbx500-prcmu: use relaxed readl variant
@ 2013-01-21 12:09 ` Fabio Baltieri
  0 siblings, 0 replies; 10+ messages in thread
From: Fabio Baltieri @ 2013-01-21 12:09 UTC (permalink / raw)
  To: Linus Walleij, John Stultz, Thomas Gleixner
  Cc: linux-arm-kernel, linux-kernel, Rabin Vincent, Fabio Baltieri

From: Rabin Vincent <rabin.vincent@stericsson.com>

Modify clksrc_dbx500_prcmu_read to replace readl() with readl_relaxed().
This speeds up calls to the function by about 40%.

Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
---
 drivers/clocksource/clksrc-dbx500-prcmu.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/clocksource/clksrc-dbx500-prcmu.c b/drivers/clocksource/clksrc-dbx500-prcmu.c
index c26c369..159f54a 100644
--- a/drivers/clocksource/clksrc-dbx500-prcmu.c
+++ b/drivers/clocksource/clksrc-dbx500-prcmu.c
@@ -33,15 +33,14 @@
 
 static void __iomem *clksrc_dbx500_timer_base;
 
-static cycle_t clksrc_dbx500_prcmu_read(struct clocksource *cs)
+static cycle_t notrace clksrc_dbx500_prcmu_read(struct clocksource *cs)
 {
+	void __iomem *base = clksrc_dbx500_timer_base;
 	u32 count, count2;
 
 	do {
-		count = readl(clksrc_dbx500_timer_base +
-			      PRCMU_TIMER_DOWNCOUNT);
-		count2 = readl(clksrc_dbx500_timer_base +
-			       PRCMU_TIMER_DOWNCOUNT);
+		count = readl_relaxed(base + PRCMU_TIMER_DOWNCOUNT);
+		count2 = readl_relaxed(base + PRCMU_TIMER_DOWNCOUNT);
 	} while (count2 != count);
 
 	/* Negate because the timer is a decrementing counter */
-- 
1.7.12.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 1/2] clocksource: dbx500-prcmu: use relaxed readl variant
@ 2013-01-21 12:09 ` Fabio Baltieri
  0 siblings, 0 replies; 10+ messages in thread
From: Fabio Baltieri @ 2013-01-21 12:09 UTC (permalink / raw)
  To: linux-arm-kernel

From: Rabin Vincent <rabin.vincent@stericsson.com>

Modify clksrc_dbx500_prcmu_read to replace readl() with readl_relaxed().
This speeds up calls to the function by about 40%.

Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
---
 drivers/clocksource/clksrc-dbx500-prcmu.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/clocksource/clksrc-dbx500-prcmu.c b/drivers/clocksource/clksrc-dbx500-prcmu.c
index c26c369..159f54a 100644
--- a/drivers/clocksource/clksrc-dbx500-prcmu.c
+++ b/drivers/clocksource/clksrc-dbx500-prcmu.c
@@ -33,15 +33,14 @@
 
 static void __iomem *clksrc_dbx500_timer_base;
 
-static cycle_t clksrc_dbx500_prcmu_read(struct clocksource *cs)
+static cycle_t notrace clksrc_dbx500_prcmu_read(struct clocksource *cs)
 {
+	void __iomem *base = clksrc_dbx500_timer_base;
 	u32 count, count2;
 
 	do {
-		count = readl(clksrc_dbx500_timer_base +
-			      PRCMU_TIMER_DOWNCOUNT);
-		count2 = readl(clksrc_dbx500_timer_base +
-			       PRCMU_TIMER_DOWNCOUNT);
+		count = readl_relaxed(base + PRCMU_TIMER_DOWNCOUNT);
+		count2 = readl_relaxed(base + PRCMU_TIMER_DOWNCOUNT);
 	} while (count2 != count);
 
 	/* Negate because the timer is a decrementing counter */
-- 
1.7.12.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/2] clocksource: dbx500-prcmu: comment cleanup
  2013-01-21 12:09 ` Fabio Baltieri
@ 2013-01-21 12:09   ` Fabio Baltieri
  -1 siblings, 0 replies; 10+ messages in thread
From: Fabio Baltieri @ 2013-01-21 12:09 UTC (permalink / raw)
  To: Linus Walleij, John Stultz, Thomas Gleixner
  Cc: linux-arm-kernel, linux-kernel, Fabio Baltieri

Remove references to the deprecated DB5500 platform.

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
---
 drivers/clocksource/clksrc-dbx500-prcmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/clksrc-dbx500-prcmu.c b/drivers/clocksource/clksrc-dbx500-prcmu.c
index 159f54a..6879a74 100644
--- a/drivers/clocksource/clksrc-dbx500-prcmu.c
+++ b/drivers/clocksource/clksrc-dbx500-prcmu.c
@@ -10,7 +10,7 @@
  * DBx500-PRCMU Timer
  * The PRCMU has 5 timers which are available in a always-on
  * power domain.  We use the Timer 4 for our always-on clock
- * source on DB8500 and Timer 3 on DB5500.
+ * source on DB8500.
  */
 #include <linux/clockchips.h>
 #include <linux/clksrc-dbx500-prcmu.h>
-- 
1.7.12.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/2] clocksource: dbx500-prcmu: comment cleanup
@ 2013-01-21 12:09   ` Fabio Baltieri
  0 siblings, 0 replies; 10+ messages in thread
From: Fabio Baltieri @ 2013-01-21 12:09 UTC (permalink / raw)
  To: linux-arm-kernel

Remove references to the deprecated DB5500 platform.

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
---
 drivers/clocksource/clksrc-dbx500-prcmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/clksrc-dbx500-prcmu.c b/drivers/clocksource/clksrc-dbx500-prcmu.c
index 159f54a..6879a74 100644
--- a/drivers/clocksource/clksrc-dbx500-prcmu.c
+++ b/drivers/clocksource/clksrc-dbx500-prcmu.c
@@ -10,7 +10,7 @@
  * DBx500-PRCMU Timer
  * The PRCMU has 5 timers which are available in a always-on
  * power domain.  We use the Timer 4 for our always-on clock
- * source on DB8500 and Timer 3 on DB5500.
+ * source on DB8500.
  */
 #include <linux/clockchips.h>
 #include <linux/clksrc-dbx500-prcmu.h>
-- 
1.7.12.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] clocksource: dbx500-prcmu: use relaxed readl variant
  2013-01-21 12:09 ` Fabio Baltieri
@ 2013-01-21 12:22   ` Fabio Baltieri
  -1 siblings, 0 replies; 10+ messages in thread
From: Fabio Baltieri @ 2013-01-21 12:22 UTC (permalink / raw)
  To: John Stultz
  Cc: linux-arm-kernel, linux-kernel, Rabin Vincent, Linus Walleij,
	Thomas Gleixner

On Mon, Jan 21, 2013 at 01:09:31PM +0100, Fabio Baltieri wrote:
> From: Rabin Vincent <rabin.vincent@stericsson.com>
> 
> Modify clksrc_dbx500_prcmu_read to replace readl() with readl_relaxed().
> This speeds up calls to the function by about 40%.

Hello John,

these two patches may go in the existing ux500 clksrc branch
together with the nomadik-mtu's patches queued up some time ago.

Can I have your Acked-by for that?

Thanks,
Fabio

-- 
Fabio Baltieri

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/2] clocksource: dbx500-prcmu: use relaxed readl variant
@ 2013-01-21 12:22   ` Fabio Baltieri
  0 siblings, 0 replies; 10+ messages in thread
From: Fabio Baltieri @ 2013-01-21 12:22 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Jan 21, 2013 at 01:09:31PM +0100, Fabio Baltieri wrote:
> From: Rabin Vincent <rabin.vincent@stericsson.com>
> 
> Modify clksrc_dbx500_prcmu_read to replace readl() with readl_relaxed().
> This speeds up calls to the function by about 40%.

Hello John,

these two patches may go in the existing ux500 clksrc branch
together with the nomadik-mtu's patches queued up some time ago.

Can I have your Acked-by for that?

Thanks,
Fabio

-- 
Fabio Baltieri

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] clocksource: dbx500-prcmu: use relaxed readl variant
  2013-01-21 12:22   ` Fabio Baltieri
@ 2013-01-23 10:16     ` Linus Walleij
  -1 siblings, 0 replies; 10+ messages in thread
From: Linus Walleij @ 2013-01-23 10:16 UTC (permalink / raw)
  To: Fabio Baltieri, John Stultz
  Cc: linux-arm-kernel, linux-kernel, Rabin Vincent, Thomas Gleixner

On Mon, Jan 21, 2013 at 1:22 PM, Fabio Baltieri
<fabio.baltieri@linaro.org> wrote:
> On Mon, Jan 21, 2013 at 01:09:31PM +0100, Fabio Baltieri wrote:
>> From: Rabin Vincent <rabin.vincent@stericsson.com>
>>
>> Modify clksrc_dbx500_prcmu_read to replace readl() with readl_relaxed().
>> This speeds up calls to the function by about 40%.
>
> Hello John,
>
> these two patches may go in the existing ux500 clksrc branch
> together with the nomadik-mtu's patches queued up some time ago.
>
> Can I have your Acked-by for that?

Actually now when I look at it these changes are fully orthogonal
to the other stuff, so these two should just go in through John's
timer tree as usual.

John?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/2] clocksource: dbx500-prcmu: use relaxed readl variant
@ 2013-01-23 10:16     ` Linus Walleij
  0 siblings, 0 replies; 10+ messages in thread
From: Linus Walleij @ 2013-01-23 10:16 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Jan 21, 2013 at 1:22 PM, Fabio Baltieri
<fabio.baltieri@linaro.org> wrote:
> On Mon, Jan 21, 2013 at 01:09:31PM +0100, Fabio Baltieri wrote:
>> From: Rabin Vincent <rabin.vincent@stericsson.com>
>>
>> Modify clksrc_dbx500_prcmu_read to replace readl() with readl_relaxed().
>> This speeds up calls to the function by about 40%.
>
> Hello John,
>
> these two patches may go in the existing ux500 clksrc branch
> together with the nomadik-mtu's patches queued up some time ago.
>
> Can I have your Acked-by for that?

Actually now when I look at it these changes are fully orthogonal
to the other stuff, so these two should just go in through John's
timer tree as usual.

John?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] clocksource: dbx500-prcmu: use relaxed readl variant
  2013-01-23 10:16     ` Linus Walleij
@ 2013-02-07  9:04       ` Fabio Baltieri
  -1 siblings, 0 replies; 10+ messages in thread
From: Fabio Baltieri @ 2013-02-07  9:04 UTC (permalink / raw)
  To: John Stultz
  Cc: Linus Walleij, linux-arm-kernel, linux-kernel, Rabin Vincent,
	Thomas Gleixner

On Wed, Jan 23, 2013 at 11:16:19AM +0100, Linus Walleij wrote:
> On Mon, Jan 21, 2013 at 1:22 PM, Fabio Baltieri
> <fabio.baltieri@linaro.org> wrote:
> > On Mon, Jan 21, 2013 at 01:09:31PM +0100, Fabio Baltieri wrote:
> >> From: Rabin Vincent <rabin.vincent@stericsson.com>
> >>
> >> Modify clksrc_dbx500_prcmu_read to replace readl() with readl_relaxed().
> >> This speeds up calls to the function by about 40%.
> >
> > Hello John,
> >
> > these two patches may go in the existing ux500 clksrc branch
> > together with the nomadik-mtu's patches queued up some time ago.
> >
> > Can I have your Acked-by for that?
> 
> Actually now when I look at it these changes are fully orthogonal
> to the other stuff, so these two should just go in through John's
> timer tree as usual.
> 
> John?

Hi John,

any feedback from this two patches?

Thanks,
Fabio

-- 
Fabio Baltieri

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/2] clocksource: dbx500-prcmu: use relaxed readl variant
@ 2013-02-07  9:04       ` Fabio Baltieri
  0 siblings, 0 replies; 10+ messages in thread
From: Fabio Baltieri @ 2013-02-07  9:04 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Jan 23, 2013 at 11:16:19AM +0100, Linus Walleij wrote:
> On Mon, Jan 21, 2013 at 1:22 PM, Fabio Baltieri
> <fabio.baltieri@linaro.org> wrote:
> > On Mon, Jan 21, 2013 at 01:09:31PM +0100, Fabio Baltieri wrote:
> >> From: Rabin Vincent <rabin.vincent@stericsson.com>
> >>
> >> Modify clksrc_dbx500_prcmu_read to replace readl() with readl_relaxed().
> >> This speeds up calls to the function by about 40%.
> >
> > Hello John,
> >
> > these two patches may go in the existing ux500 clksrc branch
> > together with the nomadik-mtu's patches queued up some time ago.
> >
> > Can I have your Acked-by for that?
> 
> Actually now when I look at it these changes are fully orthogonal
> to the other stuff, so these two should just go in through John's
> timer tree as usual.
> 
> John?

Hi John,

any feedback from this two patches?

Thanks,
Fabio

-- 
Fabio Baltieri

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-02-07  9:04 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-21 12:09 [PATCH 1/2] clocksource: dbx500-prcmu: use relaxed readl variant Fabio Baltieri
2013-01-21 12:09 ` Fabio Baltieri
2013-01-21 12:09 ` [PATCH 2/2] clocksource: dbx500-prcmu: comment cleanup Fabio Baltieri
2013-01-21 12:09   ` Fabio Baltieri
2013-01-21 12:22 ` [PATCH 1/2] clocksource: dbx500-prcmu: use relaxed readl variant Fabio Baltieri
2013-01-21 12:22   ` Fabio Baltieri
2013-01-23 10:16   ` Linus Walleij
2013-01-23 10:16     ` Linus Walleij
2013-02-07  9:04     ` Fabio Baltieri
2013-02-07  9:04       ` Fabio Baltieri

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.