* Re: [PATCH v2] USB: FHCI: fix error return code in of_fhci_probe()
2022-11-29 6:41 [PATCH v2] USB: FHCI: fix error return code in of_fhci_probe() Wang Yufen
@ 2022-11-29 6:24 ` wangyufen
2022-12-03 9:52 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: wangyufen @ 2022-11-29 6:24 UTC (permalink / raw)
To: gregkh, linus.walleij, mailhol.vincent; +Cc: linux-usb, linux-kernel
Please ignore.
Thanks.
在 2022/11/29 14:41, Wang Yufen 写道:
> Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
> instead of 0.
>
> Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
> drivers/usb/host/fhci-hcd.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
> index 95a4446..ca4b311 100644
> --- a/drivers/usb/host/fhci-hcd.c
> +++ b/drivers/usb/host/fhci-hcd.c
> @@ -639,8 +639,9 @@ static int of_fhci_probe(struct platform_device *ofdev)
> NULL, i, GPIOD_OUT_LOW);
>
> if (IS_ERR(fhci->gpiods[i])) {
> - dev_err(dev, "incorrect GPIO%d: %ld\n",
> - i, PTR_ERR(fhci->gpiods[i]));
> + ret = PTR_ERR(fhci->gpiods[i])
> + dev_err(dev, "incorrect GPIO%d: %d\n",
> + i, ret);
> goto err_gpios;
> }
> if (!fhci->gpiods[i]) {
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] USB: FHCI: fix error return code in of_fhci_probe()
@ 2022-11-29 6:41 Wang Yufen
2022-11-29 6:24 ` wangyufen
2022-12-03 9:52 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Wang Yufen @ 2022-11-29 6:41 UTC (permalink / raw)
To: gregkh, linus.walleij, mailhol.vincent; +Cc: linux-usb, linux-kernel, wangyufen
Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
instead of 0.
Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
drivers/usb/host/fhci-hcd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
index 95a4446..ca4b311 100644
--- a/drivers/usb/host/fhci-hcd.c
+++ b/drivers/usb/host/fhci-hcd.c
@@ -639,8 +639,9 @@ static int of_fhci_probe(struct platform_device *ofdev)
NULL, i, GPIOD_OUT_LOW);
if (IS_ERR(fhci->gpiods[i])) {
- dev_err(dev, "incorrect GPIO%d: %ld\n",
- i, PTR_ERR(fhci->gpiods[i]));
+ ret = PTR_ERR(fhci->gpiods[i])
+ dev_err(dev, "incorrect GPIO%d: %d\n",
+ i, ret);
goto err_gpios;
}
if (!fhci->gpiods[i]) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] USB: FHCI: fix error return code in of_fhci_probe()
2022-11-29 6:41 [PATCH v2] USB: FHCI: fix error return code in of_fhci_probe() Wang Yufen
2022-11-29 6:24 ` wangyufen
@ 2022-12-03 9:52 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-12-03 9:52 UTC (permalink / raw)
To: Wang Yufen; +Cc: gregkh, mailhol.vincent, linux-usb, linux-kernel
On Tue, Nov 29, 2022 at 7:21 AM Wang Yufen <wangyufen@huawei.com> wrote:
> Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
> instead of 0.
>
> Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-03 9:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-29 6:41 [PATCH v2] USB: FHCI: fix error return code in of_fhci_probe() Wang Yufen
2022-11-29 6:24 ` wangyufen
2022-12-03 9:52 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.