* [PATCH V2] gpio: tegra: read output value when gpio is set in direction_out
@ 2012-11-09 6:04 ` Laxman Dewangan
0 siblings, 0 replies; 6+ messages in thread
From: Laxman Dewangan @ 2012-11-09 6:04 UTC (permalink / raw)
To: linus.walleij, grant.likely
Cc: swarren, linux-kernel, linux-tegra, Laxman Dewangan
Read the output value when gpio is set for the output mode for
gpio_get_value(). Reading input value in direction out does not
give correct value.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
Changes from V1:
- Keep the if part implementation same the else part to have implementation
same kind.
drivers/gpio/gpio-tegra.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index c7c175a..1163cf1 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -135,6 +135,11 @@ static void tegra_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
static int tegra_gpio_get(struct gpio_chip *chip, unsigned offset)
{
+ /* If gpio is in output mode then read from the out value */
+ if ((tegra_gpio_readl(GPIO_OE(offset)) >> GPIO_BIT(offset)) & 1)
+ return (tegra_gpio_readl(GPIO_OUT(offset)) >>
+ GPIO_BIT(offset)) & 0x1;
+
return (tegra_gpio_readl(GPIO_IN(offset)) >> GPIO_BIT(offset)) & 0x1;
}
--
1.7.1.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH V2] gpio: tegra: read output value when gpio is set in direction_out
@ 2012-11-09 6:04 ` Laxman Dewangan
0 siblings, 0 replies; 6+ messages in thread
From: Laxman Dewangan @ 2012-11-09 6:04 UTC (permalink / raw)
To: linus.walleij, grant.likely
Cc: swarren, linux-kernel, linux-tegra, Laxman Dewangan
Read the output value when gpio is set for the output mode for
gpio_get_value(). Reading input value in direction out does not
give correct value.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
Changes from V1:
- Keep the if part implementation same the else part to have implementation
same kind.
drivers/gpio/gpio-tegra.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index c7c175a..1163cf1 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -135,6 +135,11 @@ static void tegra_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
static int tegra_gpio_get(struct gpio_chip *chip, unsigned offset)
{
+ /* If gpio is in output mode then read from the out value */
+ if ((tegra_gpio_readl(GPIO_OE(offset)) >> GPIO_BIT(offset)) & 1)
+ return (tegra_gpio_readl(GPIO_OUT(offset)) >>
+ GPIO_BIT(offset)) & 0x1;
+
return (tegra_gpio_readl(GPIO_IN(offset)) >> GPIO_BIT(offset)) & 0x1;
}
--
1.7.1.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2] gpio: tegra: read output value when gpio is set in direction_out
2012-11-09 6:04 ` Laxman Dewangan
@ 2012-11-09 17:00 ` Stephen Warren
-1 siblings, 0 replies; 6+ messages in thread
From: Stephen Warren @ 2012-11-09 17:00 UTC (permalink / raw)
To: Laxman Dewangan
Cc: linus.walleij-QSEj5FYQhm4dnm+yROfE0A,
grant.likely-s3s/WqlpOiPyB63q8FvJNQ,
swarren-DDmLM1+adcrQT0dZR+AlfA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
On 11/08/2012 11:04 PM, Laxman Dewangan wrote:
> Read the output value when gpio is set for the output mode for
> gpio_get_value(). Reading input value in direction out does not
> give correct value.
Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] gpio: tegra: read output value when gpio is set in direction_out
@ 2012-11-09 17:00 ` Stephen Warren
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Warren @ 2012-11-09 17:00 UTC (permalink / raw)
To: Laxman Dewangan
Cc: linus.walleij, grant.likely, swarren, linux-kernel, linux-tegra
On 11/08/2012 11:04 PM, Laxman Dewangan wrote:
> Read the output value when gpio is set for the output mode for
> gpio_get_value(). Reading input value in direction out does not
> give correct value.
Acked-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] gpio: tegra: read output value when gpio is set in direction_out
2012-11-09 6:04 ` Laxman Dewangan
@ 2012-11-17 20:14 ` Linus Walleij
-1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2012-11-17 20:14 UTC (permalink / raw)
To: Laxman Dewangan
Cc: grant.likely-s3s/WqlpOiPyB63q8FvJNQ,
swarren-DDmLM1+adcrQT0dZR+AlfA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
On Fri, Nov 9, 2012 at 7:04 AM, Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
> Read the output value when gpio is set for the output mode for
> gpio_get_value(). Reading input value in direction out does not
> give correct value.
>
> Signed-off-by: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Applied v2 with Stephen's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] gpio: tegra: read output value when gpio is set in direction_out
@ 2012-11-17 20:14 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2012-11-17 20:14 UTC (permalink / raw)
To: Laxman Dewangan; +Cc: grant.likely, swarren, linux-kernel, linux-tegra
On Fri, Nov 9, 2012 at 7:04 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> Read the output value when gpio is set for the output mode for
> gpio_get_value(). Reading input value in direction out does not
> give correct value.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Applied v2 with Stephen's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-11-17 20:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-09 6:04 [PATCH V2] gpio: tegra: read output value when gpio is set in direction_out Laxman Dewangan
2012-11-09 6:04 ` Laxman Dewangan
[not found] ` <1352441060-31559-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-09 17:00 ` Stephen Warren
2012-11-09 17:00 ` Stephen Warren
2012-11-17 20:14 ` Linus Walleij
2012-11-17 20:14 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.