From: Linus Walleij <linus.walleij@linaro.org>
To: Ben Dooks <ben-linux@fluff.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Stephen Warren <swarren@nvidia.com>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, ccross@android.com, olof@lixom.net,
Thomas Gleixner <tglx@linutronix.de>, Chris Ball <cjb@laptop.org>,
Liam Girdwood <lrg@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it
Date: Fri, 5 Aug 2011 22:25:55 +0200 [thread overview]
Message-ID: <CACRpkdai55JSN+dkaYu96FTDDVSa8bHZFkBS6M1u3gPUDmpE_g@mail.gmail.com> (raw)
In-Reply-To: <20110805103045.GG28651@trinity.fluff.org>
On Fri, Aug 5, 2011 at 12:30 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Fri, Aug 05, 2011 at 10:40:17AM +0100, Russell King - ARM Linux wrote:
>> Trying to go from IRQ to GPIO is not a good idea - most of the
>> IRQ <-> GPIO macros we have today are just plain broken. Many of them
>> just add or subtract a constant, which means non-GPIO IRQs have an
>> apparant GPIO number too. Couple this with the fact that all positive
>> GPIO numbers are valid, and this is a recipe for wrong GPIOs getting
>> used and GPIOs being requested for non-GPIO IRQs.
>
> Yes, and there's a pile without these defined/
And I'm piling a few patches *deleting* irq_to_gpio() from platforms that
define but actually don't use it, like U300 and SA1100.
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it
Date: Fri, 5 Aug 2011 22:25:55 +0200 [thread overview]
Message-ID: <CACRpkdai55JSN+dkaYu96FTDDVSa8bHZFkBS6M1u3gPUDmpE_g@mail.gmail.com> (raw)
In-Reply-To: <20110805103045.GG28651@trinity.fluff.org>
On Fri, Aug 5, 2011 at 12:30 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Fri, Aug 05, 2011 at 10:40:17AM +0100, Russell King - ARM Linux wrote:
>> Trying to go from IRQ to GPIO is not a good idea - most of the
>> IRQ <-> GPIO macros we have today are just plain broken. ?Many of them
>> just add or subtract a constant, which means non-GPIO IRQs have an
>> apparant GPIO number too. ?Couple this with the fact that all positive
>> GPIO numbers are valid, and this is a recipe for wrong GPIOs getting
>> used and GPIOs being requested for non-GPIO IRQs.
>
> Yes, and there's a pile without these defined/
And I'm piling a few patches *deleting* irq_to_gpio() from platforms that
define but actually don't use it, like U300 and SA1100.
Linus Walleij
next prev parent reply other threads:[~2011-08-05 20:25 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 23:00 [RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it Stephen Warren
2011-08-04 23:00 ` Stephen Warren
2011-08-04 23:00 ` Stephen Warren
[not found] ` <1312498820-2275-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-08-04 23:00 ` [PATCH 1/3] irq: " Stephen Warren
2011-08-04 23:00 ` Stephen Warren
2011-08-04 23:00 ` Stephen Warren
2011-08-05 0:01 ` Mark Brown
2011-08-05 0:01 ` Mark Brown
2011-08-05 0:01 ` Mark Brown
[not found] ` <20110805000148.GB13321-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-08-05 3:53 ` Stephen Warren
2011-08-05 3:53 ` Stephen Warren
2011-08-05 3:53 ` Stephen Warren
2011-08-05 5:35 ` Mark Brown
2011-08-05 5:35 ` Mark Brown
2011-08-05 5:35 ` Mark Brown
[not found] ` <20110805053510.GA16956-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-08-05 8:06 ` Ben Dooks
2011-08-05 8:06 ` Ben Dooks
2011-08-05 8:06 ` Ben Dooks
2011-08-05 8:29 ` Mark Brown
2011-08-05 8:29 ` Mark Brown
2011-08-05 8:29 ` Mark Brown
2011-08-05 15:29 ` Stephen Warren
2011-08-05 15:29 ` Stephen Warren
2011-08-05 15:29 ` Stephen Warren
2011-08-05 16:15 ` Mark Brown
2011-08-05 16:15 ` Mark Brown
2011-08-05 16:15 ` Mark Brown
2011-08-05 1:54 ` Rob Herring
2011-08-05 1:54 ` Rob Herring
2011-08-05 4:05 ` Stephen Warren
2011-08-05 4:05 ` Stephen Warren
2011-08-05 4:05 ` Stephen Warren
2011-08-05 7:58 ` Ben Dooks
2011-08-05 7:58 ` Ben Dooks
2011-09-02 8:36 ` Thomas Gleixner
2011-09-02 8:36 ` Thomas Gleixner
2011-09-02 15:24 ` Stephen Warren
2011-09-02 15:24 ` Stephen Warren
2011-09-02 15:24 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF04B327A55C-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-09-02 15:34 ` Stephen Warren
2011-09-02 15:34 ` Stephen Warren
2011-09-02 15:34 ` Stephen Warren
2011-09-02 15:50 ` Thomas Gleixner
2011-09-02 15:50 ` Thomas Gleixner
2011-09-02 15:50 ` Thomas Gleixner
2011-08-04 23:00 ` [PATCH 2/3] mmc: tegra: Don't gpio_request GPIOs used as IRQs Stephen Warren
2011-08-04 23:00 ` Stephen Warren
2011-08-04 23:00 ` Stephen Warren
2011-08-04 23:00 ` [PATCH 3/3] ASoC: jack_add_gpios: " Stephen Warren
2011-08-04 23:00 ` Stephen Warren
2011-08-04 23:00 ` Stephen Warren
2011-08-05 7:55 ` [RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it Ben Dooks
2011-08-05 7:55 ` Ben Dooks
2011-08-05 7:55 ` Ben Dooks
2011-08-05 9:40 ` Russell King - ARM Linux
2011-08-05 9:40 ` Russell King - ARM Linux
[not found] ` <20110805094017.GC20575-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2011-08-05 10:30 ` Ben Dooks
2011-08-05 10:30 ` Ben Dooks
2011-08-05 10:30 ` Ben Dooks
2011-08-05 20:25 ` Linus Walleij [this message]
2011-08-05 20:25 ` Linus Walleij
2011-08-05 15:43 ` Stephen Warren
2011-08-05 15:43 ` Stephen Warren
2011-08-05 15:43 ` Stephen Warren
2011-08-05 19:15 ` Russell King - ARM Linux
2011-08-05 19:15 ` Russell King - ARM Linux
2011-08-05 19:15 ` Russell King - ARM Linux
2011-08-05 19:33 ` Stephen Warren
2011-08-05 19:33 ` Stephen Warren
2011-08-05 19:33 ` Stephen Warren
2011-08-05 21:40 ` Russell King - ARM Linux
2011-08-05 21:40 ` Russell King - ARM Linux
2011-08-05 21:40 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdai55JSN+dkaYu96FTDDVSa8bHZFkBS6M1u3gPUDmpE_g@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ccross@android.com \
--cc=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@ti.com \
--cc=olof@lixom.net \
--cc=swarren@nvidia.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.