All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Soren Brinkmann <soren.brinkmann@xilinx.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Michal Simek <michal.simek@xilinx.com>,
	Russell King <linux@arm.linux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/3] DT binding: gpio-zynq: Document interrupt-controller
Date: Tue, 27 Oct 2015 17:03:29 +0100	[thread overview]
Message-ID: <CACRpkdan7oFcTWSF-fE-BiOsk4Pji7DgimfMji_eb3RGjdA4RQ@mail.gmail.com> (raw)
In-Reply-To: <1445617532-10228-1-git-send-email-soren.brinkmann@xilinx.com>

On Fri, Oct 23, 2015 at 6:25 PM, Soren Brinkmann
<soren.brinkmann@xilinx.com> wrote:

> HW and driver support the GPIO as interrupt-controller. Document that in
> the DT binding.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>

Patch subject augmented and applied.

> +- interrupt-controller : Marks the device node as an interrupt controller.
> +- #interrupt-cells     : Should be 2.  The first cell is the GPIO number.
> +                         The second cell bits[3:0] is used to specify trigger type and level flags:
> +                             1 = low-to-high edge triggered.
> +                             2 = high-to-low edge triggered.
> +                             4 = active high level-sensitive.
> +                             8 = active low level-sensitive.

If these can be or:ed together, e.g 3 = both edges, that needs to be
documented. If they can't the current patch is fine I guess.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] DT binding: gpio-zynq: Document interrupt-controller
Date: Tue, 27 Oct 2015 17:03:29 +0100	[thread overview]
Message-ID: <CACRpkdan7oFcTWSF-fE-BiOsk4Pji7DgimfMji_eb3RGjdA4RQ@mail.gmail.com> (raw)
In-Reply-To: <1445617532-10228-1-git-send-email-soren.brinkmann@xilinx.com>

On Fri, Oct 23, 2015 at 6:25 PM, Soren Brinkmann
<soren.brinkmann@xilinx.com> wrote:

> HW and driver support the GPIO as interrupt-controller. Document that in
> the DT binding.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>

Patch subject augmented and applied.

> +- interrupt-controller : Marks the device node as an interrupt controller.
> +- #interrupt-cells     : Should be 2.  The first cell is the GPIO number.
> +                         The second cell bits[3:0] is used to specify trigger type and level flags:
> +                             1 = low-to-high edge triggered.
> +                             2 = high-to-low edge triggered.
> +                             4 = active high level-sensitive.
> +                             8 = active low level-sensitive.

If these can be or:ed together, e.g 3 = both edges, that needs to be
documented. If they can't the current patch is fine I guess.

Yours,
Linus Walleij

  parent reply	other threads:[~2015-10-27 16:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 16:25 [PATCH 1/3] DT binding: gpio-zynq: Document interrupt-controller Soren Brinkmann
2015-10-23 16:25 ` Soren Brinkmann
2015-10-23 16:25 ` Soren Brinkmann
2015-10-23 16:25 ` [PATCH 2/3] ARM: zynq: DT: Add interrupt-controller property to GPIO Soren Brinkmann
2015-10-23 16:25   ` Soren Brinkmann
2015-10-23 16:25   ` Soren Brinkmann
2015-10-23 16:53   ` Moritz Fischer
2015-10-23 16:53     ` Moritz Fischer
2015-10-27 16:04   ` Linus Walleij
2015-10-27 16:04     ` Linus Walleij
2015-10-27 16:04     ` Linus Walleij
2015-10-29  7:53     ` Michal Simek
2015-10-29  7:53       ` Michal Simek
2015-10-29  7:53       ` Michal Simek
2015-10-23 16:25 ` [PATCH 3/3] ARM64: zynqmp: " Soren Brinkmann
2015-10-23 16:25   ` Soren Brinkmann
2015-10-23 16:25   ` Soren Brinkmann
2015-10-29 16:37   ` Michal Simek
2015-10-29 16:37     ` Michal Simek
2015-10-29 16:37     ` Michal Simek
2015-10-27 16:03 ` Linus Walleij [this message]
2015-10-27 16:03   ` [PATCH 1/3] DT binding: gpio-zynq: Document interrupt-controller Linus Walleij
2015-10-27 16:03   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdan7oFcTWSF-fE-BiOsk4Pji7DgimfMji_eb3RGjdA4RQ@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=michal.simek@xilinx.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=soren.brinkmann@xilinx.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.