[PATCH] gpio: pca953x: Staticise pca953x_get_altdata()

[PATCH] gpio: pca953x: Staticise pca953x_get_altdata()

[Mark Brown]

It's not used outside of the driver so doesn't need to be exported, and
sparse notices this and complains about it.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/gpio/gpio-pca953x.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 147df8a..d3f3e8f 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -546,7 +546,7 @@ static void pca953x_irq_teardown(struct pca953x_chip *chip)
  * Translate OpenFirmware node properties into platform_data
  * WARNING: This is DEPRECATED and will be removed eventually!
  */
-void
+static void
 pca953x_get_alt_pdata(struct i2c_client *client, int *gpio_base, int *invert)
 {
 	struct device_node *node;
@@ -574,7 +574,7 @@ pca953x_get_alt_pdata(struct i2c_client *client, int *gpio_base, int *invert)
 		*invert = *val;
 }
 #else
-void
+static void
 pca953x_get_alt_pdata(struct i2c_client *client, int *gpio_base, int *invert)
 {
 	*gpio_base = -1;
-- 
1.7.7.3

Re: [PATCH] gpio: pca953x: Staticise pca953x_get_altdata()

[Linus Walleij]

On Mon, Nov 21, 2011 at 6:57 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:

> It's not used outside of the driver so doesn't need to be exported, and
> sparse notices this and complains about it.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

OK I've queued this for the -rcs.

Thanks!
Linus Walleij