From: Linus Walleij <linus.walleij@linaro.org> To: Hongwei Zhang <hongweiz@ami.com> Cc: Andrew Jeffery <andrew@aj.id.au>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Joel Stanley <joel@jms.id.au>, linux-aspeed <linux-aspeed@lists.ozlabs.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [v7 2/2] gpio: aspeed: Add SGPIO driver Date: Wed, 14 Aug 2019 10:09:20 +0200 [thread overview] Message-ID: <CACRpkdaojLe3UTc0=66b5J2yrSOo7t8o5bAY=WRscL+met3iWQ@mail.gmail.com> (raw) In-Reply-To: <1564603297-1391-3-git-send-email-hongweiz@ami.com> Hi Hongwei, thanks for your patch! I have now merged the bindings so you only need to respin this patch. On Wed, Jul 31, 2019 at 10:02 PM Hongwei Zhang <hongweiz@ami.com> wrote: > Add SGPIO driver support for Aspeed AST2500 SoC. > > Signed-off-by: Hongwei Zhang <hongweiz@ami.com> > Reviewed-by: Andrew Jeffery <andrew@aj.id.au> I guess I need to go with this, there are some minor things I still want to be fixed: > +static void __aspeed_sgpio_set(struct gpio_chip *gc, unsigned int offset, int val) I don't like __underscore_functions because their semantic is ambiguous. Rename this something like aspeed_sgpio_commit() or whatever best fits the actual use. > +static int aspeed_sgpio_setup_irqs(struct aspeed_sgpio *gpio, > + struct platform_device *pdev) > +{ (...) > + rc = gpiochip_irqchip_add(&gpio->chip, &aspeed_sgpio_irqchip, > + 0, handle_bad_irq, IRQ_TYPE_NONE); (...) > + gpiochip_set_chained_irqchip(&gpio->chip, &aspeed_sgpio_irqchip, > + gpio->irq, aspeed_sgpio_irq_handler); We do not set up chained irqchips like this anymore, sorry. I am currently rewriting all existing chained drivers to pass an initialized irqchip when registering the whole gpio chip. See drivers/gpio/TODO. Here are examples: https://lore.kernel.org/linux-gpio/20190811080539.15647-1-linus.walleij@linaro.org/ https://lore.kernel.org/linux-gpio/20190812132554.18313-1-linus.walleij@linaro.org/ > + /* set all SGPIO pins as input (1). */ > + memset(gpio->dir_in, 0xff, sizeof(gpio->dir_in)); Do the irqchip set-up here, before adding the gpio_chip. > + rc = devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio); > + if (rc < 0) > + return rc; > + > + return aspeed_sgpio_setup_irqs(gpio, pdev); Yours, Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org> To: Hongwei Zhang <hongweiz@ami.com> Cc: linux-aspeed <linux-aspeed@lists.ozlabs.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Andrew Jeffery <andrew@aj.id.au>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Joel Stanley <joel@jms.id.au>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [v7 2/2] gpio: aspeed: Add SGPIO driver Date: Wed, 14 Aug 2019 10:09:20 +0200 [thread overview] Message-ID: <CACRpkdaojLe3UTc0=66b5J2yrSOo7t8o5bAY=WRscL+met3iWQ@mail.gmail.com> (raw) In-Reply-To: <1564603297-1391-3-git-send-email-hongweiz@ami.com> Hi Hongwei, thanks for your patch! I have now merged the bindings so you only need to respin this patch. On Wed, Jul 31, 2019 at 10:02 PM Hongwei Zhang <hongweiz@ami.com> wrote: > Add SGPIO driver support for Aspeed AST2500 SoC. > > Signed-off-by: Hongwei Zhang <hongweiz@ami.com> > Reviewed-by: Andrew Jeffery <andrew@aj.id.au> I guess I need to go with this, there are some minor things I still want to be fixed: > +static void __aspeed_sgpio_set(struct gpio_chip *gc, unsigned int offset, int val) I don't like __underscore_functions because their semantic is ambiguous. Rename this something like aspeed_sgpio_commit() or whatever best fits the actual use. > +static int aspeed_sgpio_setup_irqs(struct aspeed_sgpio *gpio, > + struct platform_device *pdev) > +{ (...) > + rc = gpiochip_irqchip_add(&gpio->chip, &aspeed_sgpio_irqchip, > + 0, handle_bad_irq, IRQ_TYPE_NONE); (...) > + gpiochip_set_chained_irqchip(&gpio->chip, &aspeed_sgpio_irqchip, > + gpio->irq, aspeed_sgpio_irq_handler); We do not set up chained irqchips like this anymore, sorry. I am currently rewriting all existing chained drivers to pass an initialized irqchip when registering the whole gpio chip. See drivers/gpio/TODO. Here are examples: https://lore.kernel.org/linux-gpio/20190811080539.15647-1-linus.walleij@linaro.org/ https://lore.kernel.org/linux-gpio/20190812132554.18313-1-linus.walleij@linaro.org/ > + /* set all SGPIO pins as input (1). */ > + memset(gpio->dir_in, 0xff, sizeof(gpio->dir_in)); Do the irqchip set-up here, before adding the gpio_chip. > + rc = devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio); > + if (rc < 0) > + return rc; > + > + return aspeed_sgpio_setup_irqs(gpio, pdev); Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-14 8:09 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-31 20:01 [v7 0/2] gpio: aspeed: Add SGPIO driver Hongwei Zhang 2019-07-31 20:01 ` Hongwei Zhang 2019-07-31 20:01 ` Hongwei Zhang 2019-07-31 20:01 ` [v7 1/2] dt-bindings: gpio: aspeed: Add SGPIO support Hongwei Zhang 2019-07-31 20:01 ` Hongwei Zhang 2019-07-31 20:01 ` Hongwei Zhang 2019-08-14 7:59 ` Linus Walleij 2019-08-14 7:59 ` Linus Walleij 2019-08-14 7:59 ` Linus Walleij 2019-07-31 20:01 ` [v7 2/2] gpio: aspeed: Add SGPIO driver Hongwei Zhang 2019-07-31 20:01 ` Hongwei Zhang 2019-08-01 2:59 ` Andrew Jeffery 2019-08-01 2:59 ` Andrew Jeffery 2019-08-14 8:09 ` Linus Walleij [this message] 2019-08-14 8:09 ` Linus Walleij 2019-08-21 14:25 ` Hongwei Zhang 2019-08-21 14:25 ` Hongwei Zhang 2019-08-20 21:35 ` Hongwei Zhang 2019-08-20 21:35 ` Hongwei Zhang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACRpkdaojLe3UTc0=66b5J2yrSOo7t8o5bAY=WRscL+met3iWQ@mail.gmail.com' \ --to=linus.walleij@linaro.org \ --cc=andrew@aj.id.au \ --cc=bgolaszewski@baylibre.com \ --cc=hongweiz@ami.com \ --cc=joel@jms.id.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.