From: Linus Walleij <linus.walleij@linaro.org>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>,
Mark Rutland <mark.rutland@arm.com>,
Jaghathiswari Rankappagounder Natarajan <jaghu@google.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH linux v1 4/4] arm: dts: Add dt-binding to support seven segment display on zaius
Date: Fri, 16 Dec 2016 00:07:36 +0100 [thread overview]
Message-ID: <CACRpkdaqKDJstfypP0EL9e=TA-atiJmK9zwrBHfLmEVV8SLuAQ@mail.gmail.com> (raw)
In-Reply-To: <20161214114051.GC14217@n2100.armlinux.org.uk>
On Wed, Dec 14, 2016 at 12:40 PM, Russell King - ARM Linux
<linux@armlinux.org.uk> wrote:
> Looking at this more, it's a SPI driver, presumably because the first
> case where it appeared was on a SPI bus.
>
> However, it's not a SPI device as such, it's a piece of standard,
> general purpose logic that's been around for many years, pre-dating
> the SPI bus.
Indeed.
> I think a much more sensible approach would be to turn the GPIO side
> of the 74x164 driver into a library, which can be re-used by multiple
> bus-specific drivers - one for SPI which allows it to be used in its
> current form, one for our platform bus which takes the GPIO lines for
> the data, clock and clear signals.
>
> I also don't see why they shouldn't use the same compatible - they're
> the same _device_ at the end of the day, just wired up differently.
> It makes the binding documentation a little fun wrt what are required
> and optional properties, but nothing that shouldn't be too difficult.
I agree on both accounts.
Sorry for not seeing this in the first place, I was well aware that this
is a standard component and may be connected in a myriad of ways,
so I should have known better :(
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH linux v1 4/4] arm: dts: Add dt-binding to support seven segment display on zaius
Date: Fri, 16 Dec 2016 00:07:36 +0100 [thread overview]
Message-ID: <CACRpkdaqKDJstfypP0EL9e=TA-atiJmK9zwrBHfLmEVV8SLuAQ@mail.gmail.com> (raw)
In-Reply-To: <20161214114051.GC14217@n2100.armlinux.org.uk>
On Wed, Dec 14, 2016 at 12:40 PM, Russell King - ARM Linux
<linux@armlinux.org.uk> wrote:
> Looking at this more, it's a SPI driver, presumably because the first
> case where it appeared was on a SPI bus.
>
> However, it's not a SPI device as such, it's a piece of standard,
> general purpose logic that's been around for many years, pre-dating
> the SPI bus.
Indeed.
> I think a much more sensible approach would be to turn the GPIO side
> of the 74x164 driver into a library, which can be re-used by multiple
> bus-specific drivers - one for SPI which allows it to be used in its
> current form, one for our platform bus which takes the GPIO lines for
> the data, clock and clear signals.
>
> I also don't see why they shouldn't use the same compatible - they're
> the same _device_ at the end of the day, just wired up differently.
> It makes the binding documentation a little fun wrt what are required
> and optional properties, but nothing that shouldn't be too difficult.
I agree on both accounts.
Sorry for not seeing this in the first place, I was well aware that this
is a standard component and may be connected in a myriad of ways,
so I should have known better :(
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-12-15 23:07 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 7:55 [PATCH linux v1 0/4] Seven segment display support Jaghathiswari Rankappagounder Natarajan
2016-12-14 7:55 ` Jaghathiswari Rankappagounder Natarajan
2016-12-14 7:55 ` [PATCH linux v1 1/4] Documentation: dt-bindings: Document bindings for seven " Jaghathiswari Rankappagounder Natarajan
2016-12-14 7:55 ` Jaghathiswari Rankappagounder Natarajan
2016-12-14 7:55 ` Jaghathiswari Rankappagounder Natarajan
2016-12-14 7:55 ` [PATCH linux v1 2/4] drivers: misc: Character device driver for seven segment display Jaghathiswari Rankappagounder Natarajan
2016-12-14 7:55 ` Jaghathiswari Rankappagounder Natarajan
2016-12-14 7:55 ` Jaghathiswari Rankappagounder Natarajan
2016-12-14 12:32 ` Russell King - ARM Linux
2016-12-14 12:32 ` Russell King - ARM Linux
2016-12-14 12:32 ` Russell King - ARM Linux
2016-12-14 7:55 ` [PATCH linux v1 3/4] drivers: misc: Platform driver for seven segment display support Jaghathiswari Rankappagounder Natarajan
2016-12-14 7:55 ` Jaghathiswari Rankappagounder Natarajan
2016-12-14 7:55 ` [PATCH linux v1 4/4] arm: dts: Add dt-binding to support seven segment display on zaius Jaghathiswari Rankappagounder Natarajan
2016-12-14 7:55 ` Jaghathiswari Rankappagounder Natarajan
2016-12-14 8:55 ` Arnd Bergmann
2016-12-14 8:55 ` Arnd Bergmann
2016-12-14 8:55 ` Arnd Bergmann
2016-12-14 9:00 ` Arnd Bergmann
2016-12-14 9:00 ` Arnd Bergmann
2016-12-14 11:06 ` Russell King - ARM Linux
2016-12-14 11:06 ` Russell King - ARM Linux
2016-12-14 11:06 ` Russell King - ARM Linux
2016-12-14 11:40 ` Russell King - ARM Linux
2016-12-14 11:40 ` Russell King - ARM Linux
2016-12-15 23:07 ` Linus Walleij [this message]
2016-12-15 23:07 ` Linus Walleij
2016-12-15 23:07 ` Linus Walleij
2016-12-15 23:07 ` Linus Walleij
2016-12-14 9:02 ` Joel Stanley
2016-12-14 9:02 ` Joel Stanley
2016-12-14 9:02 ` Joel Stanley
2016-12-14 9:02 ` Joel Stanley
2016-12-14 12:45 ` [PATCH linux v1 0/4] Seven segment display support Thomas Petazzoni
2016-12-14 12:45 ` Thomas Petazzoni
2016-12-14 12:45 ` Thomas Petazzoni
2016-12-14 12:56 ` Greg KH
2016-12-14 12:56 ` Greg KH
2016-12-14 12:56 ` Greg KH
2016-12-14 13:12 ` Neil Armstrong
2016-12-14 13:12 ` Neil Armstrong
2016-12-14 14:15 ` Arnd Bergmann
2016-12-14 14:15 ` Arnd Bergmann
2016-12-14 14:15 ` Arnd Bergmann
2016-12-14 20:05 ` David Daney
2016-12-14 20:05 ` David Daney
2016-12-20 4:06 ` Jaghathiswari Rankappagounder Natarajan
2016-12-20 4:06 ` Jaghathiswari Rankappagounder Natarajan
2016-12-14 16:50 ` Greg KH
2016-12-14 16:50 ` Greg KH
2016-12-14 14:35 ` Patrick Williams
2016-12-14 23:23 ` Rob Lippert
2017-02-07 4:03 Jaghathiswari Rankappagounder Natarajan
2017-02-07 4:03 ` [PATCH linux v1 4/4] arm: dts: Add dt-binding to support seven segment display on zaius Jaghathiswari Rankappagounder Natarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdaqKDJstfypP0EL9e=TA-atiJmK9zwrBHfLmEVV8SLuAQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jaghu@google.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.