* [PATCH] gpio: refactor gpiochip_find() slightly
@ 2016-08-11 16:21 Masahiro Yamada
2016-08-19 8:56 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2016-08-11 16:21 UTC (permalink / raw)
To: linux-gpio
Cc: Masahiro Yamada, Linus Walleij, Alexandre Courbot, linux-kernel
The if...else... block after the loop can be dropped with
a slight refactoring.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/gpio/gpiolib.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 53ff25a..deaf4d4 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1363,19 +1363,15 @@ struct gpio_chip *gpiochip_find(void *data,
void *data))
{
struct gpio_device *gdev;
- struct gpio_chip *chip;
+ struct gpio_chip *chip = NULL;
unsigned long flags;
spin_lock_irqsave(&gpio_lock, flags);
list_for_each_entry(gdev, &gpio_devices, list)
- if (gdev->chip && match(gdev->chip, data))
+ if (gdev->chip && match(gdev->chip, data)) {
+ chip = gdev->chip;
break;
-
- /* No match? */
- if (&gdev->list == &gpio_devices)
- chip = NULL;
- else
- chip = gdev->chip;
+ }
spin_unlock_irqrestore(&gpio_lock, flags);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: refactor gpiochip_find() slightly
2016-08-11 16:21 [PATCH] gpio: refactor gpiochip_find() slightly Masahiro Yamada
@ 2016-08-19 8:56 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2016-08-19 8:56 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-gpio, Alexandre Courbot, linux-kernel
On Thu, Aug 11, 2016 at 6:21 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> The if...else... block after the loop can be dropped with
> a slight refactoring.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-19 8:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-11 16:21 [PATCH] gpio: refactor gpiochip_find() slightly Masahiro Yamada
2016-08-19 8:56 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.