* [PATCH v1] gpio: hisi: delete some unused variables in hisi_gpio_probe()
@ 2020-12-21 8:25 Luo Jiaxing
2020-12-21 10:35 ` Andy Shevchenko
2020-12-27 21:09 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Luo Jiaxing @ 2020-12-21 8:25 UTC (permalink / raw)
To: linus.walleij, andy.shevchenko, andriy.shevchenko
Cc: linux-gpio, linux-kernel
kernel test rebot report that dat, set and clr in hisi_gpio_probe() is
unused variables. So delete it.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
---
drivers/gpio/gpio-hisi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-hisi.c b/drivers/gpio/gpio-hisi.c
index a389780..d2971c9 100644
--- a/drivers/gpio/gpio-hisi.c
+++ b/drivers/gpio/gpio-hisi.c
@@ -254,7 +254,6 @@ static void hisi_gpio_get_pdata(struct device *dev,
static int hisi_gpio_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
- void __iomem *dat, *set, *clr;
struct hisi_gpio *hisi_gpio;
int port_num;
int ret;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] gpio: hisi: delete some unused variables in hisi_gpio_probe()
2020-12-21 8:25 [PATCH v1] gpio: hisi: delete some unused variables in hisi_gpio_probe() Luo Jiaxing
@ 2020-12-21 10:35 ` Andy Shevchenko
2020-12-22 11:33 ` luojiaxing
2020-12-27 21:09 ` Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2020-12-21 10:35 UTC (permalink / raw)
To: Luo Jiaxing
Cc: Linus Walleij, Andy Shevchenko, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List
On Mon, Dec 21, 2020 at 10:25 AM Luo Jiaxing <luojiaxing@huawei.com> wrote:
>
> kernel test rebot report that dat, set and clr in hisi_gpio_probe() is
> unused variables. So delete it.
Fixes: tag?
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] gpio: hisi: delete some unused variables in hisi_gpio_probe()
2020-12-21 10:35 ` Andy Shevchenko
@ 2020-12-22 11:33 ` luojiaxing
0 siblings, 0 replies; 4+ messages in thread
From: luojiaxing @ 2020-12-22 11:33 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, Andy Shevchenko, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List
On 2020/12/21 18:35, Andy Shevchenko wrote:
> On Mon, Dec 21, 2020 at 10:25 AM Luo Jiaxing <luojiaxing@huawei.com> wrote:
>> kernel test rebot report that dat, set and clr in hisi_gpio_probe() is
>> unused variables. So delete it.
> Fixes: tag?
Fixes: 356b01a986a5 ("gpio: gpio-hisi: Add HiSilicon GPIO support")
Should I send v2 to add this tag? or we can ask linus to help to add it
when apply this?
Thanks
Jiaxing
>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] gpio: hisi: delete some unused variables in hisi_gpio_probe()
2020-12-21 8:25 [PATCH v1] gpio: hisi: delete some unused variables in hisi_gpio_probe() Luo Jiaxing
2020-12-21 10:35 ` Andy Shevchenko
@ 2020-12-27 21:09 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2020-12-27 21:09 UTC (permalink / raw)
To: Luo Jiaxing
Cc: Andy Shevchenko, Andy Shevchenko, open list:GPIO SUBSYSTEM, linux-kernel
On Mon, Dec 21, 2020 at 9:25 AM Luo Jiaxing <luojiaxing@huawei.com> wrote:
> kernel test rebot report that dat, set and clr in hisi_gpio_probe() is
> unused variables. So delete it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
I fixed this in the tree before sending the pull request to Torvalds so this
problem is already solved.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-27 21:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-21 8:25 [PATCH v1] gpio: hisi: delete some unused variables in hisi_gpio_probe() Luo Jiaxing
2020-12-21 10:35 ` Andy Shevchenko
2020-12-22 11:33 ` luojiaxing
2020-12-27 21:09 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.