* [PATCH] pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS
@ 2022-03-17 11:44 Jonathan Neuschäfer
2022-03-17 11:47 ` Jonathan Neuschäfer
2022-03-24 0:29 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Jonathan Neuschäfer @ 2022-03-17 11:44 UTC (permalink / raw)
To: linux-gpio
Cc: Jonathan Neuschäfer, kernel test robot, Linus Walleij, linux-kernel
CONFIG_GENERIC_PINCTRL_GROUPS must be selected in order for
struct group_desc to be defined in pinctrl/core.h.
Add the missing select line to CONFIG_PINCTRL_WPCM450.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
drivers/pinctrl/nuvoton/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/nuvoton/Kconfig b/drivers/pinctrl/nuvoton/Kconfig
index 6a3c6f2a73f2d..b48d32912bef1 100644
--- a/drivers/pinctrl/nuvoton/Kconfig
+++ b/drivers/pinctrl/nuvoton/Kconfig
@@ -6,6 +6,7 @@ config PINCTRL_WPCM450
select PINMUX
select PINCONF
select GENERIC_PINCONF
+ select GENERIC_PINCTRL_GROUPS
select GPIOLIB
select GPIO_GENERIC
select GPIOLIB_IRQCHIP
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS
2022-03-17 11:44 [PATCH] pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS Jonathan Neuschäfer
@ 2022-03-17 11:47 ` Jonathan Neuschäfer
2022-03-24 0:29 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Neuschäfer @ 2022-03-17 11:47 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: linux-gpio, kernel test robot, Linus Walleij, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]
On Thu, Mar 17, 2022 at 12:44:12PM +0100, Jonathan Neuschäfer wrote:
> CONFIG_GENERIC_PINCTRL_GROUPS must be selected in order for
> struct group_desc to be defined in pinctrl/core.h.
>
> Add the missing select line to CONFIG_PINCTRL_WPCM450.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Ah well, I forgot
Fixes: a1d1e0e3d80a8 ("pinctrl: nuvoton: Add driver for WPCM450")
which would be appropriate here.
> ---
> drivers/pinctrl/nuvoton/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/nuvoton/Kconfig b/drivers/pinctrl/nuvoton/Kconfig
> index 6a3c6f2a73f2d..b48d32912bef1 100644
> --- a/drivers/pinctrl/nuvoton/Kconfig
> +++ b/drivers/pinctrl/nuvoton/Kconfig
> @@ -6,6 +6,7 @@ config PINCTRL_WPCM450
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
> + select GENERIC_PINCTRL_GROUPS
> select GPIOLIB
> select GPIO_GENERIC
> select GPIOLIB_IRQCHIP
> --
> 2.35.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS
2022-03-17 11:44 [PATCH] pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS Jonathan Neuschäfer
2022-03-17 11:47 ` Jonathan Neuschäfer
@ 2022-03-24 0:29 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-03-24 0:29 UTC (permalink / raw)
To: Jonathan Neuschäfer; +Cc: linux-gpio, kernel test robot, linux-kernel
On Thu, Mar 17, 2022 at 12:44 PM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
> CONFIG_GENERIC_PINCTRL_GROUPS must be selected in order for
> struct group_desc to be defined in pinctrl/core.h.
>
> Add the missing select line to CONFIG_PINCTRL_WPCM450.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Patch applied with the Fixes: tag!
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-24 0:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-17 11:44 [PATCH] pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS Jonathan Neuschäfer
2022-03-17 11:47 ` Jonathan Neuschäfer
2022-03-24 0:29 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.