* [PATCH gpio v1 1/2] gpio: ks8695: fix switch case indentation
@ 2014-09-20 15:14 Varka Bhadram
2014-09-20 15:14 ` [PATCH gpio v1 2/2] gpio: ks8695: fix 'else should follow close brace '}'' Varka Bhadram
2014-09-24 8:57 ` [PATCH gpio v1 1/2] gpio: ks8695: fix switch case indentation Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Varka Bhadram @ 2014-09-20 15:14 UTC (permalink / raw)
To: linux-gpio; +Cc: linus.walleij, gnurou, Varka Bhadram
Signed-off-by: Varka Bhadram <varkab@cdac.in>
---
drivers/gpio/gpio-ks8695.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio-ks8695.c b/drivers/gpio/gpio-ks8695.c
index 464a83d..ba2d2f1 100644
--- a/drivers/gpio/gpio-ks8695.c
+++ b/drivers/gpio/gpio-ks8695.c
@@ -265,16 +265,16 @@ static int ks8695_gpio_show(struct seq_file *s, void *unused)
seq_printf(s, "EXT%i ", i);
switch ((ctrl & intmask[i]) >> (4 * i)) {
- case IOPC_TM_LOW:
- seq_printf(s, "(Low)"); break;
- case IOPC_TM_HIGH:
- seq_printf(s, "(High)"); break;
- case IOPC_TM_RISING:
- seq_printf(s, "(Rising)"); break;
- case IOPC_TM_FALLING:
- seq_printf(s, "(Falling)"); break;
- case IOPC_TM_EDGE:
- seq_printf(s, "(Edges)"); break;
+ case IOPC_TM_LOW:
+ seq_printf(s, "(Low)"); break;
+ case IOPC_TM_HIGH:
+ seq_printf(s, "(High)"); break;
+ case IOPC_TM_RISING:
+ seq_printf(s, "(Rising)"); break;
+ case IOPC_TM_FALLING:
+ seq_printf(s, "(Falling)"); break;
+ case IOPC_TM_EDGE:
+ seq_printf(s, "(Edges)"); break;
}
}
else
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH gpio v1 2/2] gpio: ks8695: fix 'else should follow close brace '}''
2014-09-20 15:14 [PATCH gpio v1 1/2] gpio: ks8695: fix switch case indentation Varka Bhadram
@ 2014-09-20 15:14 ` Varka Bhadram
2014-09-22 9:48 ` Alexandre Courbot
2014-09-24 8:57 ` [PATCH gpio v1 1/2] gpio: ks8695: fix switch case indentation Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Varka Bhadram @ 2014-09-20 15:14 UTC (permalink / raw)
To: linux-gpio; +Cc: linus.walleij, gnurou, Varka Bhadram
Signed-off-by: Varka Bhadram <varkab@cdac.in>
---
drivers/gpio/gpio-ks8695.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio/gpio-ks8695.c b/drivers/gpio/gpio-ks8695.c
index ba2d2f1..10c7377 100644
--- a/drivers/gpio/gpio-ks8695.c
+++ b/drivers/gpio/gpio-ks8695.c
@@ -276,17 +276,14 @@ static int ks8695_gpio_show(struct seq_file *s, void *unused)
case IOPC_TM_EDGE:
seq_printf(s, "(Edges)"); break;
}
- }
- else
+ } else
seq_printf(s, "GPIO\t");
- }
- else if (i <= KS8695_GPIO_5) {
+ } else if (i <= KS8695_GPIO_5) {
if (ctrl & enable[i])
seq_printf(s, "TOUT%i\t", i - KS8695_GPIO_4);
else
seq_printf(s, "GPIO\t");
- }
- else
+ } else
seq_printf(s, "GPIO\t");
seq_printf(s, "\t");
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH gpio v1 2/2] gpio: ks8695: fix 'else should follow close brace '}''
2014-09-20 15:14 ` [PATCH gpio v1 2/2] gpio: ks8695: fix 'else should follow close brace '}'' Varka Bhadram
@ 2014-09-22 9:48 ` Alexandre Courbot
2014-09-27 13:18 ` Varka Bhadram
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Courbot @ 2014-09-22 9:48 UTC (permalink / raw)
To: Varka Bhadram; +Cc: linux-gpio, Linus Walleij, Varka Bhadram
On Sun, Sep 21, 2014 at 12:14 AM, Varka Bhadram <varkabhadram@gmail.com> wrote:
>
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
> drivers/gpio/gpio-ks8695.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ks8695.c b/drivers/gpio/gpio-ks8695.c
> index ba2d2f1..10c7377 100644
> --- a/drivers/gpio/gpio-ks8695.c
> +++ b/drivers/gpio/gpio-ks8695.c
> @@ -276,17 +276,14 @@ static int ks8695_gpio_show(struct seq_file *s, void *unused)
> case IOPC_TM_EDGE:
> seq_printf(s, "(Edges)"); break;
> }
> - }
> - else
> + } else
> seq_printf(s, "GPIO\t");
According to the kernel code formatting guidelines, this should actually be
} else {
seq_printf(s, "GPIO\t");
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH gpio v1 1/2] gpio: ks8695: fix switch case indentation
2014-09-20 15:14 [PATCH gpio v1 1/2] gpio: ks8695: fix switch case indentation Varka Bhadram
2014-09-20 15:14 ` [PATCH gpio v1 2/2] gpio: ks8695: fix 'else should follow close brace '}'' Varka Bhadram
@ 2014-09-24 8:57 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2014-09-24 8:57 UTC (permalink / raw)
To: Varka Bhadram; +Cc: linux-gpio, Alexandre Courbot, Varka Bhadram
On Sat, Sep 20, 2014 at 5:14 PM, Varka Bhadram <varkabhadram@gmail.com> wrote:
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH gpio v1 2/2] gpio: ks8695: fix 'else should follow close brace '}''
2014-09-22 9:48 ` Alexandre Courbot
@ 2014-09-27 13:18 ` Varka Bhadram
0 siblings, 0 replies; 5+ messages in thread
From: Varka Bhadram @ 2014-09-27 13:18 UTC (permalink / raw)
To: Alexandre Courbot; +Cc: linux-gpio, Linus Walleij, Varka Bhadram
On Monday 22 September 2014 03:18 PM, Alexandre Courbot wrote:
> On Sun, Sep 21, 2014 at 12:14 AM, Varka Bhadram <varkabhadram@gmail.com> wrote:
>> Signed-off-by: Varka Bhadram <varkab@cdac.in>
>> ---
>> drivers/gpio/gpio-ks8695.c | 9 +++------
>> 1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpio/gpio-ks8695.c b/drivers/gpio/gpio-ks8695.c
>> index ba2d2f1..10c7377 100644
>> --- a/drivers/gpio/gpio-ks8695.c
>> +++ b/drivers/gpio/gpio-ks8695.c
>> @@ -276,17 +276,14 @@ static int ks8695_gpio_show(struct seq_file *s, void *unused)
>> case IOPC_TM_EDGE:
>> seq_printf(s, "(Edges)"); break;
>> }
>> - }
>> - else
>> + } else
>> seq_printf(s, "GPIO\t");
> According to the kernel code formatting guidelines, this should actually be
>
> } else {
> seq_printf(s, "GPIO\t");
> }
Ok i will change it . Thanks...
--
Regards,
Varka Bhadram
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-27 13:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-20 15:14 [PATCH gpio v1 1/2] gpio: ks8695: fix switch case indentation Varka Bhadram
2014-09-20 15:14 ` [PATCH gpio v1 2/2] gpio: ks8695: fix 'else should follow close brace '}'' Varka Bhadram
2014-09-22 9:48 ` Alexandre Courbot
2014-09-27 13:18 ` Varka Bhadram
2014-09-24 8:57 ` [PATCH gpio v1 1/2] gpio: ks8695: fix switch case indentation Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.