From: Linus Walleij <linus.walleij@linaro.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: Sean Wang <sean.wang@kernel.org>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Zhiyong Tao <zhiyong.tao@mediatek.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] pinctrl: mediatek: use spin lock in mtk_rmw
Date: Thu, 22 Apr 2021 01:12:35 +0200 [thread overview]
Message-ID: <CACRpkdb6KM-smFQ9BdVQgWCNOu-4_t=g8k3_NUZ8HH0Pjr=LGg@mail.gmail.com> (raw)
In-Reply-To: <20210406144540.3467756-1-tzungbi@google.com>
On Tue, Apr 6, 2021 at 4:46 PM Tzung-Bi Shih <tzungbi@google.com> wrote:
> Commit 42a46434e9b1 ("pinctrl: add lock in mtk_rmw function.") uses
> mutex lock in mtk_rmw. However the function is possible called from
> atomic context.
>
> For example call trace:
> mutex_lock+0x28/0x64
> mtk_rmw+0x38/0x80
> mtk_hw_set_value+0x100/0x138
> mtk_gpio_set+0x48/0x58
> gpiod_set_raw_value_commit+0xf4/0x110
> gpiod_set_value_nocheck+0x4c/0x80
> gpiod_set_value+0x4c/0x6c
> max98357a_daiops_trigger+0x8c/0x9c
> soc_pcm_trigger+0x5c/0x10c
>
> The max98357a_daiops_trigger() could run in either atomic or non-atomic
> context. As a result, dmesg shows some similar messages: "BUG: sleeping
> function called from invalid context at kernel/locking/mutex.c:254".
>
> Uses spin lock in mtk_rmw instead.
>
> Fixes: 42a46434e9b1 ("pinctrl: add lock in mtk_rmw function.")
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
Patch applied.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Zhiyong Tao <zhiyong.tao@mediatek.com>,
Sean Wang <sean.wang@kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] pinctrl: mediatek: use spin lock in mtk_rmw
Date: Thu, 22 Apr 2021 01:12:35 +0200 [thread overview]
Message-ID: <CACRpkdb6KM-smFQ9BdVQgWCNOu-4_t=g8k3_NUZ8HH0Pjr=LGg@mail.gmail.com> (raw)
In-Reply-To: <20210406144540.3467756-1-tzungbi@google.com>
On Tue, Apr 6, 2021 at 4:46 PM Tzung-Bi Shih <tzungbi@google.com> wrote:
> Commit 42a46434e9b1 ("pinctrl: add lock in mtk_rmw function.") uses
> mutex lock in mtk_rmw. However the function is possible called from
> atomic context.
>
> For example call trace:
> mutex_lock+0x28/0x64
> mtk_rmw+0x38/0x80
> mtk_hw_set_value+0x100/0x138
> mtk_gpio_set+0x48/0x58
> gpiod_set_raw_value_commit+0xf4/0x110
> gpiod_set_value_nocheck+0x4c/0x80
> gpiod_set_value+0x4c/0x6c
> max98357a_daiops_trigger+0x8c/0x9c
> soc_pcm_trigger+0x5c/0x10c
>
> The max98357a_daiops_trigger() could run in either atomic or non-atomic
> context. As a result, dmesg shows some similar messages: "BUG: sleeping
> function called from invalid context at kernel/locking/mutex.c:254".
>
> Uses spin lock in mtk_rmw instead.
>
> Fixes: 42a46434e9b1 ("pinctrl: add lock in mtk_rmw function.")
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
Patch applied.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: Sean Wang <sean.wang@kernel.org>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Zhiyong Tao <zhiyong.tao@mediatek.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] pinctrl: mediatek: use spin lock in mtk_rmw
Date: Thu, 22 Apr 2021 01:12:35 +0200 [thread overview]
Message-ID: <CACRpkdb6KM-smFQ9BdVQgWCNOu-4_t=g8k3_NUZ8HH0Pjr=LGg@mail.gmail.com> (raw)
In-Reply-To: <20210406144540.3467756-1-tzungbi@google.com>
On Tue, Apr 6, 2021 at 4:46 PM Tzung-Bi Shih <tzungbi@google.com> wrote:
> Commit 42a46434e9b1 ("pinctrl: add lock in mtk_rmw function.") uses
> mutex lock in mtk_rmw. However the function is possible called from
> atomic context.
>
> For example call trace:
> mutex_lock+0x28/0x64
> mtk_rmw+0x38/0x80
> mtk_hw_set_value+0x100/0x138
> mtk_gpio_set+0x48/0x58
> gpiod_set_raw_value_commit+0xf4/0x110
> gpiod_set_value_nocheck+0x4c/0x80
> gpiod_set_value+0x4c/0x6c
> max98357a_daiops_trigger+0x8c/0x9c
> soc_pcm_trigger+0x5c/0x10c
>
> The max98357a_daiops_trigger() could run in either atomic or non-atomic
> context. As a result, dmesg shows some similar messages: "BUG: sleeping
> function called from invalid context at kernel/locking/mutex.c:254".
>
> Uses spin lock in mtk_rmw instead.
>
> Fixes: 42a46434e9b1 ("pinctrl: add lock in mtk_rmw function.")
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
Patch applied.
Yours,
Linus Walleij
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: Sean Wang <sean.wang@kernel.org>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Zhiyong Tao <zhiyong.tao@mediatek.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] pinctrl: mediatek: use spin lock in mtk_rmw
Date: Thu, 22 Apr 2021 01:12:35 +0200 [thread overview]
Message-ID: <CACRpkdb6KM-smFQ9BdVQgWCNOu-4_t=g8k3_NUZ8HH0Pjr=LGg@mail.gmail.com> (raw)
In-Reply-To: <20210406144540.3467756-1-tzungbi@google.com>
On Tue, Apr 6, 2021 at 4:46 PM Tzung-Bi Shih <tzungbi@google.com> wrote:
> Commit 42a46434e9b1 ("pinctrl: add lock in mtk_rmw function.") uses
> mutex lock in mtk_rmw. However the function is possible called from
> atomic context.
>
> For example call trace:
> mutex_lock+0x28/0x64
> mtk_rmw+0x38/0x80
> mtk_hw_set_value+0x100/0x138
> mtk_gpio_set+0x48/0x58
> gpiod_set_raw_value_commit+0xf4/0x110
> gpiod_set_value_nocheck+0x4c/0x80
> gpiod_set_value+0x4c/0x6c
> max98357a_daiops_trigger+0x8c/0x9c
> soc_pcm_trigger+0x5c/0x10c
>
> The max98357a_daiops_trigger() could run in either atomic or non-atomic
> context. As a result, dmesg shows some similar messages: "BUG: sleeping
> function called from invalid context at kernel/locking/mutex.c:254".
>
> Uses spin lock in mtk_rmw instead.
>
> Fixes: 42a46434e9b1 ("pinctrl: add lock in mtk_rmw function.")
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
Patch applied.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-21 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 14:45 [PATCH] pinctrl: mediatek: use spin lock in mtk_rmw Tzung-Bi Shih
2021-04-06 14:45 ` Tzung-Bi Shih
2021-04-06 14:45 ` Tzung-Bi Shih
2021-04-06 14:45 ` Tzung-Bi Shih
2021-04-21 23:12 ` Linus Walleij [this message]
2021-04-21 23:12 ` Linus Walleij
2021-04-21 23:12 ` Linus Walleij
2021-04-21 23:12 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdb6KM-smFQ9BdVQgWCNOu-4_t=g8k3_NUZ8HH0Pjr=LGg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@kernel.org \
--cc=tzungbi@google.com \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.