* [PATCH] iio: gyro: mpu3050: Explicity make a 'poison' value big endian
@ 2019-10-13 10:02 jic23
2019-10-16 12:19 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 10:02 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Linus Walleij
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This clearly has no actual affect but it does show sparse and similar
static analysers that we are doing this intentionally.
CHECK drivers/iio/gyro/mpu3050-core.c
drivers/iio/gyro/mpu3050-core.c:546:48: warning: incorrect type in assignment (different base types)
drivers/iio/gyro/mpu3050-core.c:546:48: expected restricted __be16 <noident>
drivers/iio/gyro/mpu3050-core.c:546:48: got int
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
drivers/iio/gyro/mpu3050-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c
index 80154bca18b6..8e908a749f95 100644
--- a/drivers/iio/gyro/mpu3050-core.c
+++ b/drivers/iio/gyro/mpu3050-core.c
@@ -543,7 +543,7 @@ static irqreturn_t mpu3050_trigger_handler(int irq, void *p)
toread = bytes_per_datum;
offset = 1;
/* Put in some dummy value */
- fifo_values[0] = 0xAAAA;
+ fifo_values[0] = cpu_to_be16(0xAAAA);
}
ret = regmap_bulk_read(mpu3050->map,
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: gyro: mpu3050: Explicity make a 'poison' value big endian
2019-10-13 10:02 [PATCH] iio: gyro: mpu3050: Explicity make a 'poison' value big endian jic23
@ 2019-10-16 12:19 ` Linus Walleij
2019-10-18 18:55 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2019-10-16 12:19 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Jonathan Cameron
On Sun, Oct 13, 2019 at 12:05 PM <jic23@kernel.org> wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> This clearly has no actual affect but it does show sparse and similar
> static analysers that we are doing this intentionally.
>
> CHECK drivers/iio/gyro/mpu3050-core.c
> drivers/iio/gyro/mpu3050-core.c:546:48: warning: incorrect type in assignment (different base types)
> drivers/iio/gyro/mpu3050-core.c:546:48: expected restricted __be16 <noident>
> drivers/iio/gyro/mpu3050-core.c:546:48: got int
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: gyro: mpu3050: Explicity make a 'poison' value big endian
2019-10-16 12:19 ` Linus Walleij
@ 2019-10-18 18:55 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-10-18 18:55 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-iio, Jonathan Cameron
On Wed, 16 Oct 2019 14:19:46 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:
> On Sun, Oct 13, 2019 at 12:05 PM <jic23@kernel.org> wrote:
>
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > This clearly has no actual affect but it does show sparse and similar
> > static analysers that we are doing this intentionally.
> >
> > CHECK drivers/iio/gyro/mpu3050-core.c
> > drivers/iio/gyro/mpu3050-core.c:546:48: warning: incorrect type in assignment (different base types)
> > drivers/iio/gyro/mpu3050-core.c:546:48: expected restricted __be16 <noident>
> > drivers/iio/gyro/mpu3050-core.c:546:48: got int
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Yours,
> Linus Walleij
Applied. Thanks,
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-18 18:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 10:02 [PATCH] iio: gyro: mpu3050: Explicity make a 'poison' value big endian jic23
2019-10-16 12:19 ` Linus Walleij
2019-10-18 18:55 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.