All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] m5mols/m5mols.h: document new reset field
@ 2022-03-08  8:42 Hans Verkuil
  2022-03-09 23:39 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2022-03-08  8:42 UTC (permalink / raw)
  To: linux-media; +Cc: Linus Walleij

The new reset field in struct m5mols_info was not documented,
add this.

This fixes a kerneldoc warning:

drivers/media/i2c/m5mols/m5mols.h:244: warning: Function parameter or member 'reset' not described in 'm5mols_info'

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: aaaf357fa61c (media: m5mols: Convert to use GPIO descriptors)
---
diff --git a/drivers/media/i2c/m5mols/m5mols.h b/drivers/media/i2c/m5mols/m5mols.h
index b56eb0a8ee97..d8545d2280af 100644
--- a/drivers/media/i2c/m5mols/m5mols.h
+++ b/drivers/media/i2c/m5mols/m5mols.h
@@ -182,6 +182,7 @@ struct m5mols_version {
  * @stabilization: image stabilization control
  * @jpeg_quality: JPEG compression quality control
  * @set_power: optional power callback to the board code
+ * @reset: GPIO driving the reset pin of M-5MOLS
  * @lock: mutex protecting the structure fields below
  * @ffmt: current fmt according to resolution type
  * @res_type: current resolution type

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] m5mols/m5mols.h: document new reset field
  2022-03-08  8:42 [PATCH] m5mols/m5mols.h: document new reset field Hans Verkuil
@ 2022-03-09 23:39 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2022-03-09 23:39 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: linux-media

On Tue, Mar 8, 2022 at 9:42 AM Hans Verkuil <hverkuil@xs4all.nl> wrote:

> The new reset field in struct m5mols_info was not documented,
> add this.
>
> This fixes a kerneldoc warning:
>
> drivers/media/i2c/m5mols/m5mols.h:244: warning: Function parameter or member 'reset' not described in 'm5mols_info'
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Fixes: aaaf357fa61c (media: m5mols: Convert to use GPIO descriptors)

Sorry for missing this!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-09 23:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-08  8:42 [PATCH] m5mols/m5mols.h: document new reset field Hans Verkuil
2022-03-09 23:39 ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.