All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] gpio: xgene: Fix missing spin_lock_init()
@ 2014-09-21  4:31 Axel Lin
  2014-09-21  4:32 ` [PATCH 2/3] gpio: xgene: Remove unneeded forward declation for struct xgene_gpio Axel Lin
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Axel Lin @ 2014-09-21  4:31 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Feng Kan, Alexandre Courbot, linux-gpio

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/gpio/gpio-xgene.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-xgene.c b/drivers/gpio/gpio-xgene.c
index e25ba14..256c785 100644
--- a/drivers/gpio/gpio-xgene.c
+++ b/drivers/gpio/gpio-xgene.c
@@ -189,6 +189,7 @@ static int xgene_gpio_probe(struct platform_device *pdev)
 
 	gpio->chip.ngpio = XGENE_MAX_GPIOS;
 
+	spin_lock_init(&gpio->lock);
 	gpio->chip.dev = &pdev->dev;
 	gpio->chip.direction_input = xgene_gpio_dir_in;
 	gpio->chip.direction_output = xgene_gpio_dir_out;
-- 
1.9.1




^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/3] gpio: xgene: Remove unneeded forward declation for struct xgene_gpio
  2014-09-21  4:31 [PATCH 1/3] gpio: xgene: Fix missing spin_lock_init() Axel Lin
@ 2014-09-21  4:32 ` Axel Lin
  2014-09-24  9:02   ` Linus Walleij
  2014-09-21  4:32 ` [PATCH 3/3] gpio: xgene: Remove unneeded #ifdef CONFIG_OF guard Axel Lin
  2014-09-24  9:01 ` [PATCH 1/3] gpio: xgene: Fix missing spin_lock_init() Linus Walleij
  2 siblings, 1 reply; 6+ messages in thread
From: Axel Lin @ 2014-09-21  4:32 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Feng Kan, Alexandre Courbot, linux-gpio

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/gpio/gpio-xgene.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-xgene.c b/drivers/gpio/gpio-xgene.c
index 256c785..cef92f4 100644
--- a/drivers/gpio/gpio-xgene.c
+++ b/drivers/gpio/gpio-xgene.c
@@ -38,8 +38,6 @@
 #define GPIO_BIT_OFFSET(x)	(x % XGENE_GPIOS_PER_BANK)
 #define GPIO_BANK_OFFSET(x)	((x / XGENE_GPIOS_PER_BANK) * GPIO_BANK_STRIDE)
 
-struct xgene_gpio;
-
 struct xgene_gpio {
 	struct gpio_chip	chip;
 	void __iomem		*base;
-- 
1.9.1




^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 3/3] gpio: xgene: Remove unneeded #ifdef CONFIG_OF guard
  2014-09-21  4:31 [PATCH 1/3] gpio: xgene: Fix missing spin_lock_init() Axel Lin
  2014-09-21  4:32 ` [PATCH 2/3] gpio: xgene: Remove unneeded forward declation for struct xgene_gpio Axel Lin
@ 2014-09-21  4:32 ` Axel Lin
  2014-09-24  9:03   ` Linus Walleij
  2014-09-24  9:01 ` [PATCH 1/3] gpio: xgene: Fix missing spin_lock_init() Linus Walleij
  2 siblings, 1 reply; 6+ messages in thread
From: Axel Lin @ 2014-09-21  4:32 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Feng Kan, Alexandre Courbot, linux-gpio

This driver depends on OF_GPIO, so it won't be built if !CONFIG_OF.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/gpio/gpio-xgene.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-xgene.c b/drivers/gpio/gpio-xgene.c
index cef92f4..82263e4 100644
--- a/drivers/gpio/gpio-xgene.c
+++ b/drivers/gpio/gpio-xgene.c
@@ -223,13 +223,11 @@ static int xgene_gpio_remove(struct platform_device *pdev)
 	return ret;
 }
 
-#ifdef CONFIG_OF
 static const struct of_device_id xgene_gpio_of_match[] = {
 	{ .compatible = "apm,xgene-gpio", },
 	{},
 };
 MODULE_DEVICE_TABLE(of, xgene_gpio_of_match);
-#endif
 
 static struct platform_driver xgene_gpio_driver = {
 	.driver = {
-- 
1.9.1




^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] gpio: xgene: Fix missing spin_lock_init()
  2014-09-21  4:31 [PATCH 1/3] gpio: xgene: Fix missing spin_lock_init() Axel Lin
  2014-09-21  4:32 ` [PATCH 2/3] gpio: xgene: Remove unneeded forward declation for struct xgene_gpio Axel Lin
  2014-09-21  4:32 ` [PATCH 3/3] gpio: xgene: Remove unneeded #ifdef CONFIG_OF guard Axel Lin
@ 2014-09-24  9:01 ` Linus Walleij
  2 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2014-09-24  9:01 UTC (permalink / raw)
  To: Axel Lin; +Cc: Feng Kan, Alexandre Courbot, linux-gpio

On Sun, Sep 21, 2014 at 6:31 AM, Axel Lin <axel.lin@ingics.com> wrote:

> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] gpio: xgene: Remove unneeded forward declation for struct xgene_gpio
  2014-09-21  4:32 ` [PATCH 2/3] gpio: xgene: Remove unneeded forward declation for struct xgene_gpio Axel Lin
@ 2014-09-24  9:02   ` Linus Walleij
  0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2014-09-24  9:02 UTC (permalink / raw)
  To: Axel Lin; +Cc: Feng Kan, Alexandre Courbot, linux-gpio

On Sun, Sep 21, 2014 at 6:32 AM, Axel Lin <axel.lin@ingics.com> wrote:

> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] gpio: xgene: Remove unneeded #ifdef CONFIG_OF guard
  2014-09-21  4:32 ` [PATCH 3/3] gpio: xgene: Remove unneeded #ifdef CONFIG_OF guard Axel Lin
@ 2014-09-24  9:03   ` Linus Walleij
  0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2014-09-24  9:03 UTC (permalink / raw)
  To: Axel Lin; +Cc: Feng Kan, Alexandre Courbot, linux-gpio

On Sun, Sep 21, 2014 at 6:32 AM, Axel Lin <axel.lin@ingics.com> wrote:

> This driver depends on OF_GPIO, so it won't be built if !CONFIG_OF.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-24  9:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-21  4:31 [PATCH 1/3] gpio: xgene: Fix missing spin_lock_init() Axel Lin
2014-09-21  4:32 ` [PATCH 2/3] gpio: xgene: Remove unneeded forward declation for struct xgene_gpio Axel Lin
2014-09-24  9:02   ` Linus Walleij
2014-09-21  4:32 ` [PATCH 3/3] gpio: xgene: Remove unneeded #ifdef CONFIG_OF guard Axel Lin
2014-09-24  9:03   ` Linus Walleij
2014-09-24  9:01 ` [PATCH 1/3] gpio: xgene: Fix missing spin_lock_init() Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.