From: Linus Walleij <linus.walleij@linaro.org>
To: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexandre Courbot <gnurou@gmail.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
JawaharBalaji Thirumalaisamy <jawaharb@juniper.net>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Debjit Ghosh <dghosh@juniper.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mohammad Kamil <mkamil@juniper.net>,
Georgi Vlaev <gvlaev@juniper.net>,
Lee Jones <lee.jones@linaro.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 3/6] gpio: gpio-cbc: Document bindings of CBC FPGA GPIO block
Date: Fri, 21 Oct 2016 10:45:20 +0200 [thread overview]
Message-ID: <CACRpkdbG45GFWM2HgypcTHyBg3rJ96tw+sfy+33BaGbs3bPgJw@mail.gmail.com> (raw)
In-Reply-To: <1475853614-22409-4-git-send-email-pantelis.antoniou@konsulko.com>
On Fri, Oct 7, 2016 at 5:20 PM, Pantelis Antoniou
<pantelis.antoniou@konsulko.com> wrote:
> From: Georgi Vlaev <gvlaev@juniper.net>
>
> Add device tree bindings document for the GPIO driver of
> Juniper's CBC FPGA.
>
> Signed-off-by: Georgi Vlaev <gvlaev@juniper.net>
> [Ported from Juniper kernel]
> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> ---
> .../devicetree/bindings/gpio/jnx,gpio-cbc.txt | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt
>
> diff --git a/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt b/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt
> new file mode 100644
> index 0000000..d205d0b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt
> @@ -0,0 +1,30 @@
> +Juniper CBC FPGA GPIO block
> +
> +Required properties:
> +
> +- compatible:
> + Must be "jnx,cbc-gpio"
> +
> +Optional properties:
> +
> +- reg:
> + Address and length of the register set for the device. This is optional since
> + usually the parent MFD driver fills it in.
> +
> +- #gpio-cells:
> + Should be <2>. The first cell is the pin number (within the controller's
> + pin space), and the second is used for the following flags:
> + bit[0]: direction (0 = out, 1 = in)
> + bit[1]: init high
> + bit[2]: active low
Can't you just refer to the generic bindings?
Apart from that it looks fine.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Frank Rowand <frowand.list@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Debjit Ghosh <dghosh@juniper.net>,
Georgi Vlaev <gvlaev@juniper.net>,
Guenter Roeck <linux@roeck-us.net>,
JawaharBalaji Thirumalaisamy <jawaharb@juniper.net>,
Mohammad Kamil <mkamil@juniper.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH 3/6] gpio: gpio-cbc: Document bindings of CBC FPGA GPIO block
Date: Fri, 21 Oct 2016 10:45:20 +0200 [thread overview]
Message-ID: <CACRpkdbG45GFWM2HgypcTHyBg3rJ96tw+sfy+33BaGbs3bPgJw@mail.gmail.com> (raw)
In-Reply-To: <1475853614-22409-4-git-send-email-pantelis.antoniou@konsulko.com>
On Fri, Oct 7, 2016 at 5:20 PM, Pantelis Antoniou
<pantelis.antoniou@konsulko.com> wrote:
> From: Georgi Vlaev <gvlaev@juniper.net>
>
> Add device tree bindings document for the GPIO driver of
> Juniper's CBC FPGA.
>
> Signed-off-by: Georgi Vlaev <gvlaev@juniper.net>
> [Ported from Juniper kernel]
> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> ---
> .../devicetree/bindings/gpio/jnx,gpio-cbc.txt | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt
>
> diff --git a/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt b/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt
> new file mode 100644
> index 0000000..d205d0b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt
> @@ -0,0 +1,30 @@
> +Juniper CBC FPGA GPIO block
> +
> +Required properties:
> +
> +- compatible:
> + Must be "jnx,cbc-gpio"
> +
> +Optional properties:
> +
> +- reg:
> + Address and length of the register set for the device. This is optional since
> + usually the parent MFD driver fills it in.
> +
> +- #gpio-cells:
> + Should be <2>. The first cell is the pin number (within the controller's
> + pin space), and the second is used for the following flags:
> + bit[0]: direction (0 = out, 1 = in)
> + bit[1]: init high
> + bit[2]: active low
Can't you just refer to the generic bindings?
Apart from that it looks fine.
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-10-21 8:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 15:20 [PATCH 0/6] Introduce Juniper CBC FPGA Pantelis Antoniou
2016-10-07 15:20 ` Pantelis Antoniou
2016-10-07 15:20 ` [PATCH 1/6] mfd: Add support for the PTX1K " Pantelis Antoniou
2016-10-07 15:20 ` Pantelis Antoniou
2016-10-07 15:20 ` [PATCH 2/6] gpio: Add support for PTX1K CBC FPGA spare GPIOs Pantelis Antoniou
2016-10-07 15:20 ` Pantelis Antoniou
2016-10-21 8:44 ` Linus Walleij
2016-10-07 15:20 ` [PATCH 3/6] gpio: gpio-cbc: Document bindings of CBC FPGA GPIO block Pantelis Antoniou
2016-10-07 15:20 ` Pantelis Antoniou
2016-10-21 8:45 ` Linus Walleij [this message]
2016-10-21 8:45 ` Linus Walleij
2016-10-07 15:20 ` [PATCH 4/6] gpio: cbc-presence: Add CBC presence detect as GPIO driver Pantelis Antoniou
2016-10-07 15:20 ` Pantelis Antoniou
2016-10-21 8:49 ` Linus Walleij
2016-10-07 15:20 ` [PATCH 5/6] gpio: gpio-cbc-presense: Document bindings of CBC FPGA presence Pantelis Antoniou
2016-10-07 15:20 ` Pantelis Antoniou
2016-10-07 15:20 ` [PATCH 6/6] staging: jnx: CBD-FPGA infrastructure Pantelis Antoniou
2016-10-07 15:20 ` Pantelis Antoniou
2016-10-07 15:39 ` [PATCH 0/6] Introduce Juniper CBC FPGA Greg Kroah-Hartman
2016-10-07 15:39 ` Greg Kroah-Hartman
[not found] ` <20161007153944.GA13519-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-10-07 15:44 ` Pantelis Antoniou
2016-10-07 15:44 ` Pantelis Antoniou
2016-10-07 18:53 ` Pantelis Antoniou
2016-10-07 20:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbG45GFWM2HgypcTHyBg3rJ96tw+sfy+33BaGbs3bPgJw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=dghosh@juniper.net \
--cc=frowand.list@gmail.com \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gvlaev@juniper.net \
--cc=jawaharb@juniper.net \
--cc=lee.jones@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mkamil@juniper.net \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.