* [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC
@ 2013-02-07 11:57 Sachin Kamat
2013-02-07 11:57 ` [PATCH 2/2] mmc: dw_mmc: exynos: Add pinctrl support Sachin Kamat
2013-02-14 15:25 ` [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC Sachin Kamat
0 siblings, 2 replies; 12+ messages in thread
From: Sachin Kamat @ 2013-02-07 11:57 UTC (permalink / raw)
To: linux-mmc
Cc: cjb, tgih.jun, jh80.chung, sachin.kamat, patches, Thomas Abraham
Added compatibility string for Exynos4412 SoC.
Cc: Thomas Abraham <thomas.abraham@linaro.org>
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/mmc/host/dw_mmc-exynos.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index 72fd0f2..f15b4d3 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -209,6 +209,8 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
};
static const struct of_device_id dw_mci_exynos_match[] = {
+ { .compatible = "samsung,exynos4412-dw-mshc",
+ .data = &exynos5250_drv_data, },
{ .compatible = "samsung,exynos5250-dw-mshc",
.data = &exynos5250_drv_data, },
{},
--
1.7.4.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] mmc: dw_mmc: exynos: Add pinctrl support
2013-02-07 11:57 [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC Sachin Kamat
@ 2013-02-07 11:57 ` Sachin Kamat
2013-02-07 15:30 ` Linus Walleij
2013-02-14 15:25 ` [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC Sachin Kamat
1 sibling, 1 reply; 12+ messages in thread
From: Sachin Kamat @ 2013-02-07 11:57 UTC (permalink / raw)
To: linux-mmc
Cc: cjb, tgih.jun, jh80.chung, sachin.kamat, patches, Thomas Abraham,
Linus Walleij
Added support for pin configuration using pinctrl subsystem.
Cc: Thomas Abraham <thomas.abraham@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/mmc/host/dw_mmc-exynos.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index f15b4d3..31f5f47 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -11,11 +11,13 @@
#include <linux/module.h>
#include <linux/platform_device.h>
+#include <linux/err.h>
#include <linux/clk.h>
#include <linux/mmc/host.h>
#include <linux/mmc/dw_mmc.h>
#include <linux/of.h>
#include <linux/of_gpio.h>
+#include <linux/pinctrl/consumer.h>
#include "dw_mmc.h"
#include "dw_mmc-pltfm.h"
@@ -36,6 +38,8 @@
#define EXYNOS4210_FIXED_CIU_CLK_DIV 2
#define EXYNOS4412_FIXED_CIU_CLK_DIV 4
+static struct pinctrl *pctrl;
+
/* Variations in Exynos specific dw-mshc controller */
enum dw_mci_exynos_type {
DW_MCI_TYPE_EXYNOS4210,
@@ -160,6 +164,10 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host,
if (!slot_np)
return -EINVAL;
+ pctrl = devm_pinctrl_get_select_default(host->dev);
+ if (!IS_ERR(pctrl))
+ return 0;
+
/* cmd + clock + bus-width pins */
for (idx = 0; idx < NUM_PINS(bus_width); idx++) {
gpio = of_get_gpio(slot_np, idx);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] mmc: dw_mmc: exynos: Add pinctrl support
2013-02-07 11:57 ` [PATCH 2/2] mmc: dw_mmc: exynos: Add pinctrl support Sachin Kamat
@ 2013-02-07 15:30 ` Linus Walleij
2013-02-25 4:39 ` Sachin Kamat
0 siblings, 1 reply; 12+ messages in thread
From: Linus Walleij @ 2013-02-07 15:30 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-mmc, cjb, tgih.jun, jh80.chung, patches, Thomas Abraham
On Thu, Feb 7, 2013 at 12:57 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Added support for pin configuration using pinctrl subsystem.
>
> Cc: Thomas Abraham <thomas.abraham@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
NACK.
In the v3.9 merge window we will merge this patch:
http://marc.info/?l=linux-kernel&m=135887740715083&w=2
That should do the trick. Just define your tables properly.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC
2013-02-07 11:57 [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC Sachin Kamat
2013-02-07 11:57 ` [PATCH 2/2] mmc: dw_mmc: exynos: Add pinctrl support Sachin Kamat
@ 2013-02-14 15:25 ` Sachin Kamat
2013-02-15 5:09 ` Alim Akhtar
1 sibling, 1 reply; 12+ messages in thread
From: Sachin Kamat @ 2013-02-14 15:25 UTC (permalink / raw)
To: linux-mmc
Cc: cjb, tgih.jun, jh80.chung, sachin.kamat, patches, Thomas Abraham
On 07/02/2013, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Added compatibility string for Exynos4412 SoC.
>
> Cc: Thomas Abraham <thomas.abraham@linaro.org>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Any comments on this patch?
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c
> b/drivers/mmc/host/dw_mmc-exynos.c
> index 72fd0f2..f15b4d3 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -209,6 +209,8 @@ static const struct dw_mci_drv_data exynos5250_drv_data
> = {
> };
>
> static const struct of_device_id dw_mci_exynos_match[] = {
> + { .compatible = "samsung,exynos4412-dw-mshc",
> + .data = &exynos5250_drv_data, },
> { .compatible = "samsung,exynos5250-dw-mshc",
> .data = &exynos5250_drv_data, },
> {},
> --
> 1.7.4.1
>
>
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC
2013-02-14 15:25 ` [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC Sachin Kamat
@ 2013-02-15 5:09 ` Alim Akhtar
2013-02-15 5:24 ` Jaehoon Chung
0 siblings, 1 reply; 12+ messages in thread
From: Alim Akhtar @ 2013-02-15 5:09 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-mmc, cjb, tgih.jun, jh80.chung, patches, Thomas Abraham
Hi Sachin,
On Thu, Feb 14, 2013 at 8:55 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> On 07/02/2013, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> Added compatibility string for Exynos4412 SoC.
>>
>> Cc: Thomas Abraham <thomas.abraham@linaro.org>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>
> Any comments on this patch?
>
>> ---
>> drivers/mmc/host/dw_mmc-exynos.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc-exynos.c
>> b/drivers/mmc/host/dw_mmc-exynos.c
>> index 72fd0f2..f15b4d3 100644
>> --- a/drivers/mmc/host/dw_mmc-exynos.c
>> +++ b/drivers/mmc/host/dw_mmc-exynos.c
>> @@ -209,6 +209,8 @@ static const struct dw_mci_drv_data exynos5250_drv_data
>> = {
>> };
>>
>> static const struct of_device_id dw_mci_exynos_match[] = {
>> + { .compatible = "samsung,exynos4412-dw-mshc",
>> + .data = &exynos5250_drv_data, },
>> { .compatible = "samsung,exynos5250-dw-mshc",
>> .data = &exynos5250_drv_data, },
>> {},
Looks like dw_mci_drv_data is a generic enough to be used for all
exynos SoCs including exynos4210. My thought is, if 4412 and 5250 is
using the same drv_data(please check 4210 once), let rename them as
exynos. In that case we still have different compatible name and not
so __confusing__ .data field.
I am ok if maintainers suggested something else/better here.
>>
>> 1.7.4.1
>>
>>
>
>
> --
> With warm regards,
> Sachin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Alim
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC
2013-02-15 5:09 ` Alim Akhtar
@ 2013-02-15 5:24 ` Jaehoon Chung
2013-02-15 9:10 ` Sachin Kamat
2013-02-18 8:46 ` Sachin Kamat
0 siblings, 2 replies; 12+ messages in thread
From: Jaehoon Chung @ 2013-02-15 5:24 UTC (permalink / raw)
To: Alim Akhtar
Cc: Sachin Kamat, linux-mmc, cjb, tgih.jun, jh80.chung, patches,
Thomas Abraham
On 02/15/2013 02:09 PM, Alim Akhtar wrote:
> Hi Sachin,
>
> On Thu, Feb 14, 2013 at 8:55 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> On 07/02/2013, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>>> Added compatibility string for Exynos4412 SoC.
>>>
>>> Cc: Thomas Abraham <thomas.abraham@linaro.org>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>
>> Any comments on this patch?
>>
>>> ---
>>> drivers/mmc/host/dw_mmc-exynos.c | 2 ++
>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/dw_mmc-exynos.c
>>> b/drivers/mmc/host/dw_mmc-exynos.c
>>> index 72fd0f2..f15b4d3 100644
>>> --- a/drivers/mmc/host/dw_mmc-exynos.c
>>> +++ b/drivers/mmc/host/dw_mmc-exynos.c
>>> @@ -209,6 +209,8 @@ static const struct dw_mci_drv_data exynos5250_drv_data
>>> = {
>>> };
>>>
>>> static const struct of_device_id dw_mci_exynos_match[] = {
>>> + { .compatible = "samsung,exynos4412-dw-mshc",
>>> + .data = &exynos5250_drv_data, },
>>> { .compatible = "samsung,exynos5250-dw-mshc",
>>> .data = &exynos5250_drv_data, },
>>> {},
>
> Looks like dw_mci_drv_data is a generic enough to be used for all
> exynos SoCs including exynos4210. My thought is, if 4412 and 5250 is
> using the same drv_data(please check 4210 once), let rename them as
> exynos. In that case we still have different compatible name and not
> so __confusing__ .data field.
I agreed Alim's opinion. Actually, i mentioned this point at the Dongin's patch.
If using same drv_data, i would prefer to use "&exynos_drv_data" instead of &exynos5250_drv_data.
This patch could be separated into two patches. like this "compatibility for exynos4412 SOC" and "rename the drv_data"
Best Regards,
Jaehoon Chung
> I am ok if maintainers suggested something else/better here.
>>>
>>> 1.7.4.1
>>>
>>>
>>
>>
>> --
>> With warm regards,
>> Sachin
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC
2013-02-15 5:24 ` Jaehoon Chung
@ 2013-02-15 9:10 ` Sachin Kamat
2013-02-18 8:46 ` Sachin Kamat
1 sibling, 0 replies; 12+ messages in thread
From: Sachin Kamat @ 2013-02-15 9:10 UTC (permalink / raw)
To: Jaehoon Chung
Cc: Alim Akhtar, linux-mmc, cjb, tgih.jun, patches, Thomas Abraham
On 15/02/2013, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> On 02/15/2013 02:09 PM, Alim Akhtar wrote:
>> Hi Sachin,
>>
>> On Thu, Feb 14, 2013 at 8:55 PM, Sachin Kamat <sachin.kamat@linaro.org>
>> wrote:
>>> On 07/02/2013, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>>>> Added compatibility string for Exynos4412 SoC.
>>>>
>>>> Cc: Thomas Abraham <thomas.abraham@linaro.org>
>>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>>
>>> Any comments on this patch?
>>>
>>>> ---
>>>> drivers/mmc/host/dw_mmc-exynos.c | 2 ++
>>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/mmc/host/dw_mmc-exynos.c
>>>> b/drivers/mmc/host/dw_mmc-exynos.c
>>>> index 72fd0f2..f15b4d3 100644
>>>> --- a/drivers/mmc/host/dw_mmc-exynos.c
>>>> +++ b/drivers/mmc/host/dw_mmc-exynos.c
>>>> @@ -209,6 +209,8 @@ static const struct dw_mci_drv_data
>>>> exynos5250_drv_data
>>>> = {
>>>> };
>>>>
>>>> static const struct of_device_id dw_mci_exynos_match[] = {
>>>> + { .compatible = "samsung,exynos4412-dw-mshc",
>>>> + .data = &exynos5250_drv_data, },
>>>> { .compatible = "samsung,exynos5250-dw-mshc",
>>>> .data = &exynos5250_drv_data, },
>>>> {},
>>
>> Looks like dw_mci_drv_data is a generic enough to be used for all
>> exynos SoCs including exynos4210. My thought is, if 4412 and 5250 is
>> using the same drv_data(please check 4210 once), let rename them as
>> exynos. In that case we still have different compatible name and not
>> so __confusing__ .data field.
> I agreed Alim's opinion. Actually, i mentioned this point at the Dongin's
> patch.
> If using same drv_data, i would prefer to use "&exynos_drv_data" instead of
> &exynos5250_drv_data.
>
> This patch could be separated into two patches. like this "compatibility for
> exynos4412 SOC" and "rename the drv_data"
>
If the driver data is same for all exynos socs, then it makes sense to
name it just exynos. I will update and resend accordingly.
> Best Regards,
> Jaehoon Chung
>> I am ok if maintainers suggested something else/better here.
>>>>
>>>> 1.7.4.1
>>>>
>>>>
>>>
>>>
>>> --
>>> With warm regards,
>>> Sachin
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC
2013-02-15 5:24 ` Jaehoon Chung
2013-02-15 9:10 ` Sachin Kamat
@ 2013-02-18 8:46 ` Sachin Kamat
2013-02-18 9:04 ` Dongjin Kim
1 sibling, 1 reply; 12+ messages in thread
From: Sachin Kamat @ 2013-02-18 8:46 UTC (permalink / raw)
To: Jaehoon Chung
Cc: Alim Akhtar, linux-mmc, cjb, tgih.jun, patches, Thomas Abraham,
Dongjin Kim
>>> On 07/02/2013, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>>>> Added compatibility string for Exynos4412 SoC.
>>>>
> If using same drv_data, i would prefer to use "&exynos_drv_data" instead of &exynos5250_drv_data.
>
> This patch could be separated into two patches. like this "compatibility for exynos4412 SOC" and "rename the drv_data"
Came across this patch from Dongjin Kim [1] who has already attempetd
the above suggestion. Hence dropping my patch.
Dongjin,
Are you still working on this patch [1] as this has not yet been
accepted or merged?
[1] http://lkml.indiana.edu/hypermail/linux/kernel/1301.3/00450.html
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC
2013-02-18 8:46 ` Sachin Kamat
@ 2013-02-18 9:04 ` Dongjin Kim
2013-02-18 9:09 ` Sachin Kamat
0 siblings, 1 reply; 12+ messages in thread
From: Dongjin Kim @ 2013-02-18 9:04 UTC (permalink / raw)
To: Sachin Kamat
Cc: Jaehoon Chung, Alim Akhtar, linux-mmc, cjb, tgih.jun, patches,
Thomas Abraham
Hello Sachin,
I have one more patch which use '&exynos_drv_data' for its drv_data,
but not submitted yet.
I will send it soon anyway, anything else do you like to point out on
the patch? :)
Regards,
Dongjin.
On Mon, Feb 18, 2013 at 5:46 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>>>> On 07/02/2013, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>>>>> Added compatibility string for Exynos4412 SoC.
>>>>>
>> If using same drv_data, i would prefer to use "&exynos_drv_data" instead of &exynos5250_drv_data.
>>
>> This patch could be separated into two patches. like this "compatibility for exynos4412 SOC" and "rename the drv_data"
>
> Came across this patch from Dongjin Kim [1] who has already attempetd
> the above suggestion. Hence dropping my patch.
>
> Dongjin,
> Are you still working on this patch [1] as this has not yet been
> accepted or merged?
>
> [1] http://lkml.indiana.edu/hypermail/linux/kernel/1301.3/00450.html
>
> --
> With warm regards,
> Sachin
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC
2013-02-18 9:04 ` Dongjin Kim
@ 2013-02-18 9:09 ` Sachin Kamat
0 siblings, 0 replies; 12+ messages in thread
From: Sachin Kamat @ 2013-02-18 9:09 UTC (permalink / raw)
To: Dongjin Kim
Cc: Jaehoon Chung, Alim Akhtar, linux-mmc, cjb, tgih.jun, patches,
Thomas Abraham
Hi Dongjin,
On 18 February 2013 14:34, Dongjin Kim <tobetter@gmail.com> wrote:
> Hello Sachin,
>
> I have one more patch which use '&exynos_drv_data' for its drv_data,
> but not submitted yet.
> I will send it soon anyway, anything else do you like to point out on
> the patch? :)
Please verify if the capabilities of Exynos 4412 and 5 are same? Other
comments are already provided by Jaehoon and Alim.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] mmc: dw_mmc: exynos: Add pinctrl support
2013-02-07 15:30 ` Linus Walleij
@ 2013-02-25 4:39 ` Sachin Kamat
2013-02-27 23:19 ` Linus Walleij
0 siblings, 1 reply; 12+ messages in thread
From: Sachin Kamat @ 2013-02-25 4:39 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-mmc, cjb, tgih.jun, jh80.chung
On 7 February 2013 21:00, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, Feb 7, 2013 at 12:57 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>
>> Added support for pin configuration using pinctrl subsystem.
>>
>
> NACK.
>
> In the v3.9 merge window we will merge this patch:
> http://marc.info/?l=linux-kernel&m=135887740715083&w=2
>
> That should do the trick. Just define your tables properly.
>
Just a small clarification needed in this regard.
On systems that do not use pinctrl and need to configure the gpios, we
used to check the return value of devm_pinctrl_get_select_default()
for error and then parse the dt file for gpios and configure them if
needed. Now your latest patch "drivers/pinctrl: grab default handles
from device core" suggests not to use boilerplate code as it will
handle pinctrl configuration based on dt entries for it. So in the
case like dw_mmc (in my patch above), please suggest best way to avoid
parsing gpios from dt file in case where we have pinctrl defined.
The following 3 lines (with +) wouldn't be required according to the
patch and hence 'for' loop would get executed (which I want to avoid
as the system supports pinctrl in this case).
+ pctrl = devm_pinctrl_get_select_default(host->dev);
+ if (!IS_ERR(pctrl))
+ return 0;
+
/* cmd + clock + bus-width pins */
for (idx = 0; idx < NUM_PINS(bus_width); idx++) {
gpio = of_get_gpio(slot_np, idx);
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] mmc: dw_mmc: exynos: Add pinctrl support
2013-02-25 4:39 ` Sachin Kamat
@ 2013-02-27 23:19 ` Linus Walleij
0 siblings, 0 replies; 12+ messages in thread
From: Linus Walleij @ 2013-02-27 23:19 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-mmc, cjb, tgih.jun, jh80.chung
On Mon, Feb 25, 2013 at 5:39 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Just a small clarification needed in this regard.
> On systems that do not use pinctrl and need to configure the gpios, we
> used to check the return value of devm_pinctrl_get_select_default()
> for error and then parse the dt file for gpios and configure them if
> needed.
The idea of pinctrl_get_select_default() is (as you could guess
from it's name) to get a pin ctrl handle and select the default state.
The return code from that function tells you whether that was
successful or not.
It does *NOT* tell you to go and look up GPIO values if it wasn't!
Then the function would be named
bool pinctrl_is_used_on_this_system().
Please review the recent conversation I had with Tomasz and
Heiko on this, especially this mail:
http://marc.info/?l=linux-kernel&m=136166647121345&w=2
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-02-27 23:19 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-07 11:57 [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC Sachin Kamat
2013-02-07 11:57 ` [PATCH 2/2] mmc: dw_mmc: exynos: Add pinctrl support Sachin Kamat
2013-02-07 15:30 ` Linus Walleij
2013-02-25 4:39 ` Sachin Kamat
2013-02-27 23:19 ` Linus Walleij
2013-02-14 15:25 ` [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC Sachin Kamat
2013-02-15 5:09 ` Alim Akhtar
2013-02-15 5:24 ` Jaehoon Chung
2013-02-15 9:10 ` Sachin Kamat
2013-02-18 8:46 ` Sachin Kamat
2013-02-18 9:04 ` Dongjin Kim
2013-02-18 9:09 ` Sachin Kamat
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.