* [PATCH] pinctrl: u300: make u300_pmx_registers static
@ 2016-06-09 10:55 Ben Dooks
2016-06-13 7:28 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2016-06-09 10:55 UTC (permalink / raw)
To: linux-kernel; +Cc: Ben Dooks, Linus Walleij, linux-gpio
The array u300_pmx_registers is not declared or used outside
of the driver, so make it static to avoid the following warning:
drivers/pinctrl/pinctrl-u300.c:673:11: warning: symbol 'u300_pmx_registers' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
---
drivers/pinctrl/pinctrl-u300.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-u300.c b/drivers/pinctrl/pinctrl-u300.c
index d1af908..9cc80a5 100644
--- a/drivers/pinctrl/pinctrl-u300.c
+++ b/drivers/pinctrl/pinctrl-u300.c
@@ -670,7 +670,7 @@ struct u300_pmx {
* u300_pmx_registers - the array of registers read/written for each pinmux
* shunt setting
*/
-const u32 u300_pmx_registers[] = {
+static const u32 u300_pmx_registers[] = {
U300_SYSCON_PMC1LR,
U300_SYSCON_PMC1HR,
U300_SYSCON_PMC2R,
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: u300: make u300_pmx_registers static
2016-06-09 10:55 [PATCH] pinctrl: u300: make u300_pmx_registers static Ben Dooks
@ 2016-06-13 7:28 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2016-06-13 7:28 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-kernel, linux-gpio
On Thu, Jun 9, 2016 at 12:55 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> The array u300_pmx_registers is not declared or used outside
> of the driver, so make it static to avoid the following warning:
>
> drivers/pinctrl/pinctrl-u300.c:673:11: warning: symbol 'u300_pmx_registers' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-13 7:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-09 10:55 [PATCH] pinctrl: u300: make u300_pmx_registers static Ben Dooks
2016-06-13 7:28 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.