All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	Jassi Brar <jaswinder.singh@linaro.org>,
	Masami Hiramatsu <masami.hiramatsu@linaro.org>
Subject: Re: [PATCH 0/2] GPIO support for Socionext Synquacer
Date: Tue, 31 Oct 2017 14:10:05 +0100	[thread overview]
Message-ID: <CACRpkdbRKLyWhBiLr7CPh26nQ2-KRKyy=pk_SO0TWi97BUssdw@mail.gmail.com> (raw)
In-Reply-To: <CAKv+Gu9iGLsmhOkBfJkcVKUaV26-dwTHaFgDsiwutAahkG6BrA@mail.gmail.com>

On Tue, Oct 31, 2017 at 1:59 PM, Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:

> OK, so i now have
>
> # cat /sys/kernel/debug/gpio

"lsgpio" from tools/gpio/lsgpio.c is even nicer, but OK :)

> gpiochip0: GPIOs 480-511, parent: platform/51000000.gpio, 51000000.gpio:
>  gpio-480 (DSW3-PIN1           |dsw3_1              ) in  lo
>  gpio-481 (DSW3-PIN2           |dsw3_2              ) in  lo
>  gpio-482 (DSW3-PIN3           |dsw3_3              ) in  lo
>  gpio-483 (DSW3-PIN4           |dsw3_4              ) in  hi
>  gpio-484 (DSW3-PIN5           |dsw3_5              ) in  hi
>  gpio-485 (DSW3-PIN6           |dsw3_6              ) in  lo
>  gpio-486 (DSW3-PIN7           |dsw3_7              ) in  lo
>  gpio-487 (DSW3-PIN8           |dsw3_8              ) in  lo
>  gpio-488 (NC                  )
>  gpio-489 (PWROFF#             )
>  gpio-490 (GPIO-A              )
>  gpio-491 (GPIO-B              )
>  gpio-492 (GPIO-C              )
>  gpio-493 (GPIO-D              )
>  gpio-494 (PCIE1EXTINT         )
>  gpio-495 (PCIE0EXTINT         )
>  gpio-496 (PHY2-INT#           )
>  gpio-497 (PHY1-INT#           )
>  gpio-498 (GPIO-E              )
>  gpio-499 (GPIO-F              )
>  gpio-500 (GPIO-G              )
>  gpio-501 (GPIO-H              )
>  gpio-502 (GPIO-I              )
>  gpio-503 (GPIO-J              )
>  gpio-504 (GPIO-K              )
>  gpio-505 (GPIO-L              )
>  gpio-506 (PEC-PD26            )
>  gpio-507 (PEC-PD27            )
>  gpio-508 (PEC-PD28            )
>  gpio-509 (PEC-PD29            )
>  gpio-510 (PEC-PD30            )
>  gpio-511 (PEC-PD31            )
>
> after adding this
>
>     gpio-line-names = "DSW3-PIN1", "DSW3-PIN2", "DSW3-PIN3", "DSW3-PIN4",
>                       "DSW3-PIN5", "DSW3-PIN6", "DSW3-PIN7", "DSW3-PIN8",
>                       "NC", "PWROFF#",
>                       "GPIO-A", "GPIO-B", "GPIO-C", "GPIO-D",
>                       "PCIE1EXTINT", "PCIE0EXTINT",
>                       "PHY2-INT#", "PHY1-INT#",
>                       "GPIO-E", "GPIO-F", "GPIO-G", "GPIO-H",
>                       "GPIO-I", "GPIO-J", "GPIO-K", "GPIO-L",
>                       "PEC-PD26", "PEC-PD27", "PEC-PD28",
>                       "PEC-PD29", "PEC-PD30", "PEC-PD31";
>
> to the DT node of the GPIO controller.

Perfect. Proper naming of GPIO-A thru L gives userspace an
easy time to get a grip on the right GPIO line on the Low Speed
Connector.

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

  reply	other threads:[~2017-10-31 13:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27 20:21 [PATCH 0/2] GPIO support for Socionext Synquacer Ard Biesheuvel
2017-10-27 20:21 ` [PATCH 1/2] gpio: mb86s7x: share with other SoCs as module Ard Biesheuvel
2017-10-30 17:15   ` Ard Biesheuvel
2017-10-31 12:12   ` Linus Walleij
2017-10-27 20:21 ` [PATCH 2/2] gpio: mb86s70: Revert "Return error if requesting an already assigned gpio" Ard Biesheuvel
2017-10-28  1:53   ` Axel Lin
2017-10-31 12:14   ` Linus Walleij
2017-10-31 12:20 ` [PATCH 0/2] GPIO support for Socionext Synquacer Linus Walleij
2017-10-31 12:27   ` Ard Biesheuvel
2017-10-31 12:59     ` Ard Biesheuvel
2017-10-31 13:10       ` Linus Walleij [this message]
2017-10-31 13:13     ` Linus Walleij
2017-10-31 13:19       ` Ard Biesheuvel
2017-10-31 13:19     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdbRKLyWhBiLr7CPh26nQ2-KRKyy=pk_SO0TWi97BUssdw@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=daniel.thompson@linaro.org \
    --cc=jaswinder.singh@linaro.org \
    --cc=leif.lindholm@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=masami.hiramatsu@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.