From: Linus Walleij <linus.walleij@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Jassi Brar <jaswinder.singh@linaro.org>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>
Subject: Re: [PATCH 0/2] GPIO support for Socionext Synquacer
Date: Tue, 31 Oct 2017 13:20:59 +0100 [thread overview]
Message-ID: <CACRpkdbfM6SuXxkbfcmJ-JxK1Mt=oxy1qN3rEawoNb8gpmjM9Q@mail.gmail.com> (raw)
In-Reply-To: <20171027202148.4188-1-ard.biesheuvel@linaro.org>
On Fri, Oct 27, 2017 at 10:21 PM, Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
> The Socionext Synquacer SC2A11, which is used in the arm64 Developer Box,
> shares its GPIO IP with a Fujitsu SoC for which we already have support
> in the tree. So let's tweak it so that we can reuse it.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
>
> Ard Biesheuvel (2):
> gpio: mb86s7x: share with other SoCs as module
> gpio: mb86s70: Revert "Return error if requesting an already assigned
> gpio"
Nice. We might need to look into the following wrt this driver:
- Using generic MMIO GPIO, i.e. select GPIO_GENERIC in Kconfig
and a patch such as commit 6d125412fc16802012a17665638f49b0b0c81f18
"gpio: iop: Use generic GPIO MMIO functions for driver"
apart from reduced code size this brings the .get_multiple() and
.set_multiple() callbacks for FREE.
The fact that the driver is so simple that it should have been using
MMIO/GENERIC GPIO is a plain oversight during review.
- When submitting the DTS for that developer box, make sure that
the 96boards header has proper GPIO line names from day 1,
see e.g.
commit bbaf867e2d3796bca465d07ffcd800a3bd570861
"arm64: dts: hikey: name the GPIO lines"
Ard: if you have this machine on your desk help with the above would
be much appreciated (plus it's fun!) thanks a bunch :)
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-10-31 12:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 20:21 [PATCH 0/2] GPIO support for Socionext Synquacer Ard Biesheuvel
2017-10-27 20:21 ` [PATCH 1/2] gpio: mb86s7x: share with other SoCs as module Ard Biesheuvel
2017-10-30 17:15 ` Ard Biesheuvel
2017-10-31 12:12 ` Linus Walleij
2017-10-27 20:21 ` [PATCH 2/2] gpio: mb86s70: Revert "Return error if requesting an already assigned gpio" Ard Biesheuvel
2017-10-28 1:53 ` Axel Lin
2017-10-31 12:14 ` Linus Walleij
2017-10-31 12:20 ` Linus Walleij [this message]
2017-10-31 12:27 ` [PATCH 0/2] GPIO support for Socionext Synquacer Ard Biesheuvel
2017-10-31 12:59 ` Ard Biesheuvel
2017-10-31 13:10 ` Linus Walleij
2017-10-31 13:13 ` Linus Walleij
2017-10-31 13:19 ` Ard Biesheuvel
2017-10-31 13:19 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbfM6SuXxkbfcmJ-JxK1Mt=oxy1qN3rEawoNb8gpmjM9Q@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=jaswinder.singh@linaro.org \
--cc=leif.lindholm@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.